All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nir Lichtman <nir@lichtman.org>
To: Doug Anderson <dianders@chromium.org>
Cc: jason.wessel@windriver.com, daniel.thompson@linaro.org,
	corbet@lwn.net, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] Documentation: English fixes in kgdb/kdb article
Date: Fri, 18 Oct 2024 22:21:13 +0000	[thread overview]
Message-ID: <20241018222113.GA799331@lichtman.org> (raw)
In-Reply-To: <CAD=FV=UwNAkam8HFhdPLRCXHf05LUXdJF++d-pvpFrCLtOypPQ@mail.gmail.com>

On Fri, Oct 18, 2024 at 12:46:14PM -0700, Doug Anderson wrote:
> Hi,
> 
> On Fri, Oct 18, 2024 at 10:55 AM Nir Lichtman <nir@lichtman.org> wrote:
> >
> > @@ -201,7 +201,7 @@ Using loadable module or built-in
> >  Configure kgdboc at runtime with sysfs
> >  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> >
> > -At run time you can enable or disable kgdboc by echoing a parameters
> > +At run time you can enable or disable kgdboc by writing parameters
> >  into sysfs. Here are two examples:
> 
> In response to v1, Matthew wanted you to change "the sysfs" into
> "sysfs". In the above it's no longer "the sysfs" but it's not part of
> your patch (no "-" of the old line with the "the" and "+" of the new
> line without the "the". Huh? This causes the patch to fail to apply.
> 
> Other than that, this all looks fine to me.
> 
> Reviewed-by: Douglas Anderson <dianders@chromium.org>

Thanks, sorry about that mistake, will send a v3 with a fix shortly.

  reply	other threads:[~2024-10-18 22:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-18 16:31 [PATCH] Documentation: English fixes in kgdb/kdb article Nir Lichtman
2024-10-18 17:27 ` Matthew Wilcox
2024-10-18 17:49   ` Nir Lichtman
2024-10-18 17:56     ` Matthew Wilcox
2024-10-18 17:55 ` [PATCH v2] " Nir Lichtman
2024-10-18 19:46   ` Doug Anderson
2024-10-18 22:21     ` Nir Lichtman [this message]
2024-10-18 22:35   ` [PATCH v3] " Nir Lichtman
2024-10-18 22:49     ` Doug Anderson
2024-10-18 23:10     ` Jonathan Corbet
2024-10-19  5:50       ` Nir Lichtman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241018222113.GA799331@lichtman.org \
    --to=nir@lichtman.org \
    --cc=corbet@lwn.net \
    --cc=daniel.thompson@linaro.org \
    --cc=dianders@chromium.org \
    --cc=jason.wessel@windriver.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.