From: Simon Horman <horms@kernel.org>
To: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
brett.creeley@amd.com, mateusz.polchlopek@intel.com
Subject: Re: [Intel-wired-lan] [iwl-next v1] ice: only allow Tx promiscuous for multicast
Date: Sat, 19 Oct 2024 09:11:52 +0100 [thread overview]
Message-ID: <20241019081152.GH1697@kernel.org> (raw)
In-Reply-To: <20241017070816.189630-1-michal.swiatkowski@linux.intel.com>
On Thu, Oct 17, 2024 at 09:08:16AM +0200, Michal Swiatkowski wrote:
> From: Brett Creeley <brett.creeley@intel.com>
>
> Currently when any VF is trusted and true promiscuous mode is enabled on
> the PF, the VF will receive all unicast traffic directed to the device's
> internal switch. This includes traffic external to the NIC and also from
> other VSI (i.e. VFs). This does not match the expected behavior as
> unicast traffic should only be visible from external sources in this
> case. Disable the Tx promiscuous mode bits for unicast promiscuous mode.
>
> Reviewed-by: Mateusz Polchlopek <mateusz.polchlopek@intel.com>
> Signed-off-by: Brett Creeley <brett.creeley@intel.com>
> Signed-off-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
brett.creeley@amd.com, mateusz.polchlopek@intel.com
Subject: Re: [iwl-next v1] ice: only allow Tx promiscuous for multicast
Date: Sat, 19 Oct 2024 09:11:52 +0100 [thread overview]
Message-ID: <20241019081152.GH1697@kernel.org> (raw)
In-Reply-To: <20241017070816.189630-1-michal.swiatkowski@linux.intel.com>
On Thu, Oct 17, 2024 at 09:08:16AM +0200, Michal Swiatkowski wrote:
> From: Brett Creeley <brett.creeley@intel.com>
>
> Currently when any VF is trusted and true promiscuous mode is enabled on
> the PF, the VF will receive all unicast traffic directed to the device's
> internal switch. This includes traffic external to the NIC and also from
> other VSI (i.e. VFs). This does not match the expected behavior as
> unicast traffic should only be visible from external sources in this
> case. Disable the Tx promiscuous mode bits for unicast promiscuous mode.
>
> Reviewed-by: Mateusz Polchlopek <mateusz.polchlopek@intel.com>
> Signed-off-by: Brett Creeley <brett.creeley@intel.com>
> Signed-off-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-10-19 8:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-17 7:08 [Intel-wired-lan] [iwl-next v1] ice: only allow Tx promiscuous for multicast Michal Swiatkowski
2024-10-17 7:08 ` Michal Swiatkowski
2024-10-19 8:11 ` Simon Horman [this message]
2024-10-19 8:11 ` Simon Horman
2024-10-29 15:14 ` [Intel-wired-lan] " Romanowski, Rafal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241019081152.GH1697@kernel.org \
--to=horms@kernel.org \
--cc=brett.creeley@amd.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=mateusz.polchlopek@intel.com \
--cc=michal.swiatkowski@linux.intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.