Re: [PATCH 6/6] build: limit scope of packed member warning disabling

[Stephen Hemminger <stephen@networkplumber.org>]

On Thu, 17 Oct 2024 15:22:13 +0100
Bruce Richardson <bruce.richardson@intel.com> wrote:

> The flag '-Wno-address-of-packed-member' is a global warning flag in
> DPDK. Rather than disabling this warning globally, it is better to just
> have it enabled for components that may need it. This patch limits the
> scope of it in the following ways:
> 
> * limit the use of the flag to the drivers subfolder only - all libs and
>   apps should be buildable without the warning.
> * exception is made for the vhost library and the ipsec-secgw example
>   for now, as making them buildable with the warning enabled is more
>   complicated. This exception can hopefully be removed in future.
> 
> Limiting the scope further within the drivers directory is also left for
> future consideration. However, since HW drivers often have to use packed
> structures to align with hardware-implemented data layouts, it may be
> more practical to keep the warning disabled in the longer term.
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
>  config/meson.build               | 1 -
>  drivers/meson.build              | 9 ++++++---
>  examples/ipsec-secgw/meson.build | 6 ++++++
>  lib/vhost/meson.build            | 5 ++++-
>  4 files changed, 16 insertions(+), 5 deletions(-)

Good first step, followups can fix ipsec and vhost later.

Acked-by: Stephen Hemminger <stephen@networkplumber.org>