From: Jonathan Cavitt <jonathan.cavitt@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: saurabhg.gupta@intel.com, alex.zuo@intel.com,
jonathan.cavitt@intel.com, umesh.nerlige.ramappa@intel.com,
john.c.harrison@intel.com
Subject: [PATCH] drm/xe/xe_guc_ads: save/restore OA registers
Date: Mon, 21 Oct 2024 22:24:01 +0000 [thread overview]
Message-ID: <20241021222401.95833-1-jonathan.cavitt@intel.com> (raw)
Several OA registers were missing from the save restore list for GuC and
could be lost during an engine reset. Add them to the list.
Suggested-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Suggested-by: John Harrison <john.c.harrison@intel.com>
Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
---
drivers/gpu/drm/xe/xe_guc_ads.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/drivers/gpu/drm/xe/xe_guc_ads.c b/drivers/gpu/drm/xe/xe_guc_ads.c
index 4e746ae98888..a196c4fb90fc 100644
--- a/drivers/gpu/drm/xe/xe_guc_ads.c
+++ b/drivers/gpu/drm/xe/xe_guc_ads.c
@@ -15,6 +15,7 @@
#include "regs/xe_engine_regs.h"
#include "regs/xe_gt_regs.h"
#include "regs/xe_guc_regs.h"
+#include "regs/xe_oa_regs.h"
#include "xe_bo.h"
#include "xe_gt.h"
#include "xe_gt_ccs_mode.h"
@@ -740,6 +741,11 @@ static unsigned int guc_mmio_regset_write(struct xe_guc_ads *ads,
guc_mmio_regset_write_one(ads, regset_map, e->reg, count++);
}
+ for (i = 0; i < RING_MAX_NONPRIV_SLOTS; i++)
+ guc_mmio_regset_write_one(ads, regset_map,
+ RING_FORCE_TO_NONPRIV(hwe->mmio_base, i),
+ count++);
+
/* Wa_1607983814 */
if (needs_wa_1607983814(xe) && hwe->class == XE_ENGINE_CLASS_RENDER) {
for (i = 0; i < LNCFCMOCS_REG_COUNT; i++) {
@@ -748,6 +754,14 @@ static unsigned int guc_mmio_regset_write(struct xe_guc_ads *ads,
}
}
+ guc_mmio_regset_write_one(ads, regset_map, EU_PERF_CNTL0, count++);
+ guc_mmio_regset_write_one(ads, regset_map, EU_PERF_CNTL1, count++);
+ guc_mmio_regset_write_one(ads, regset_map, EU_PERF_CNTL2, count++);
+ guc_mmio_regset_write_one(ads, regset_map, EU_PERF_CNTL3, count++);
+ guc_mmio_regset_write_one(ads, regset_map, EU_PERF_CNTL4, count++);
+ guc_mmio_regset_write_one(ads, regset_map, EU_PERF_CNTL5, count++);
+ guc_mmio_regset_write_one(ads, regset_map, EU_PERF_CNTL6, count++);
+
return count;
}
--
2.43.0
next reply other threads:[~2024-10-21 22:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-21 22:24 Jonathan Cavitt [this message]
2024-10-21 23:06 ` ✓ CI.Patch_applied: success for drm/xe/xe_guc_ads: save/restore OA registers Patchwork
2024-10-21 23:06 ` ✓ CI.checkpatch: " Patchwork
2024-10-21 23:07 ` ✓ CI.KUnit: " Patchwork
2024-10-21 23:11 ` [PATCH] " Dixit, Ashutosh
2024-10-21 23:19 ` Umesh Nerlige Ramappa
2024-10-21 23:26 ` Umesh Nerlige Ramappa
2024-10-21 23:19 ` ✓ CI.Build: success for " Patchwork
2024-10-21 23:21 ` ✓ CI.Hooks: " Patchwork
2024-10-21 23:22 ` ✓ CI.checksparse: " Patchwork
2024-10-21 23:43 ` ✗ CI.BAT: failure " Patchwork
2024-10-22 7:36 ` ✗ CI.FULL: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241021222401.95833-1-jonathan.cavitt@intel.com \
--to=jonathan.cavitt@intel.com \
--cc=alex.zuo@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=john.c.harrison@intel.com \
--cc=saurabhg.gupta@intel.com \
--cc=umesh.nerlige.ramappa@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.