All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Jonathan Cavitt <jonathan.cavitt@intel.com>
Cc: intel-xe@lists.freedesktop.org, saurabhg.gupta@intel.com,
	alex.zuo@intel.com,  umesh.nerlige.ramappa@intel.com,
	john.c.harrison@intel.com
Subject: Re: [PATCH] drm/xe/xe_guc_ads: save/restore OA registers
Date: Mon, 21 Oct 2024 16:11:39 -0700	[thread overview]
Message-ID: <85a5ex2gr8.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20241021222401.95833-1-jonathan.cavitt@intel.com>

On Mon, 21 Oct 2024 15:24:01 -0700, Jonathan Cavitt wrote:
>
> Several OA registers were missing from the save restore list for GuC and
> could be lost during an engine reset.  Add them to the list.
>
> Suggested-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
> Suggested-by: John Harrison <john.c.harrison@intel.com>
> Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>

Thanks for chasing this down.

Think we should consider this a fix and add:

Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/2249

And also, maybe,

Cc: stable@vger.kernel.org

For that we may also need a "Fixes:" tag?

Acked-by: Ashutosh Dixit <ashutosh.dixit@intel.com>

  parent reply	other threads:[~2024-10-21 23:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-21 22:24 [PATCH] drm/xe/xe_guc_ads: save/restore OA registers Jonathan Cavitt
2024-10-21 23:06 ` ✓ CI.Patch_applied: success for " Patchwork
2024-10-21 23:06 ` ✓ CI.checkpatch: " Patchwork
2024-10-21 23:07 ` ✓ CI.KUnit: " Patchwork
2024-10-21 23:11 ` Dixit, Ashutosh [this message]
2024-10-21 23:19   ` [PATCH] " Umesh Nerlige Ramappa
2024-10-21 23:26     ` Umesh Nerlige Ramappa
2024-10-21 23:19 ` ✓ CI.Build: success for " Patchwork
2024-10-21 23:21 ` ✓ CI.Hooks: " Patchwork
2024-10-21 23:22 ` ✓ CI.checksparse: " Patchwork
2024-10-21 23:43 ` ✗ CI.BAT: failure " Patchwork
2024-10-22  7:36 ` ✗ CI.FULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=85a5ex2gr8.wl-ashutosh.dixit@intel.com \
    --to=ashutosh.dixit@intel.com \
    --cc=alex.zuo@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=john.c.harrison@intel.com \
    --cc=jonathan.cavitt@intel.com \
    --cc=saurabhg.gupta@intel.com \
    --cc=umesh.nerlige.ramappa@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.