From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Guixin Liu <kanie@linux.alibaba.com>,
hch@lst.de, sagi@grimberg.me, kch@nvidia.com,
shinichiro.kawasaki@wdc.com, d.bogdanov@yadro.com,
linux-nvme@lists.infradead.org, Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH v17 2/2] nvmet: support reservation feature
Date: Tue, 22 Oct 2024 08:06:39 +0200 [thread overview]
Message-ID: <20241022060639.GA10510@lst.de> (raw)
In-Reply-To: <ZxcIxhQMYt2fsPiY@kbusch-mbp>
On Mon, Oct 21, 2024 at 08:07:02PM -0600, Keith Busch wrote:
> I see, thank you for the clarification. I hadn't been paying close
> enough attention at that discussion.
>
> So, minor problem here. This new feature is 6.13 material, but our
> upstream block branch has forked before that commit. IMO, I feel
> introducing that header movement after the merge window is poorly
> timed...
>
> Anyway, I don't think I can get away with something this large in 6.12,
> so it's going to have to be in our second 6.13 nvme pull request after
> the next rebase. I've set myself a reminder to merge this when that
> happens.
This absolutely is not 6.12 material obviously. But having the
block tree branched of before -rc2 seems a bit unusual and potentially
problematic anyway. Jens, can you rebase or full a recent rc in?
next prev parent reply other threads:[~2024-10-22 6:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-21 11:03 [PATCH v17 0/2] Implement the NVMe reservation feature Guixin Liu
2024-10-21 11:03 ` [PATCH v17 1/2] nvme: add reservation command's defines Guixin Liu
2024-10-21 11:03 ` [PATCH v17 2/2] nvmet: support reservation feature Guixin Liu
2024-10-21 22:33 ` Keith Busch
2024-10-22 1:43 ` Guixin Liu
2024-10-22 2:07 ` Keith Busch
2024-10-22 6:06 ` Christoph Hellwig [this message]
2024-10-22 14:13 ` Jens Axboe
2024-10-22 14:18 ` Jens Axboe
2024-10-22 14:19 ` Christoph Hellwig
2024-10-22 14:34 ` Keith Busch
2024-10-22 13:18 ` Sagi Grimberg
2024-10-22 14:20 ` Christoph Hellwig
2024-10-23 7:35 ` Guixin Liu
2024-10-23 12:24 ` Christoph Hellwig
2024-10-24 1:32 ` Guixin Liu
2024-10-23 7:06 ` Guixin Liu
2024-10-23 13:30 ` Dmitry Bogdanov
2024-10-24 2:04 ` Guixin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241022060639.GA10510@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=d.bogdanov@yadro.com \
--cc=kanie@linux.alibaba.com \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.