From: Christoph Hellwig <hch@lst.de>
To: Guixin Liu <kanie@linux.alibaba.com>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
kch@nvidia.com, shinichiro.kawasaki@wdc.com,
d.bogdanov@yadro.com, linux-nvme@lists.infradead.org
Subject: Re: [PATCH v17 2/2] nvmet: support reservation feature
Date: Wed, 23 Oct 2024 14:24:55 +0200 [thread overview]
Message-ID: <20241023122453.GA29256@lst.de> (raw)
In-Reply-To: <75748d86-5ed2-4310-b02c-500984e6feda@linux.alibaba.com>
On Wed, Oct 23, 2024 at 03:35:03PM +0800, Guixin Liu wrote:
>> Guixin, can you test the code with lockdep enabled and see if there
>> is other fallout as well? Thanks!
>
> You mean use semaphore to replace mutex pr_lock? If this works, I
>
> can send a v18.
That should work. Although semaphores are kinda frowned upon, so
better write up a comment why they are needed as well.
next prev parent reply other threads:[~2024-10-23 12:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-21 11:03 [PATCH v17 0/2] Implement the NVMe reservation feature Guixin Liu
2024-10-21 11:03 ` [PATCH v17 1/2] nvme: add reservation command's defines Guixin Liu
2024-10-21 11:03 ` [PATCH v17 2/2] nvmet: support reservation feature Guixin Liu
2024-10-21 22:33 ` Keith Busch
2024-10-22 1:43 ` Guixin Liu
2024-10-22 2:07 ` Keith Busch
2024-10-22 6:06 ` Christoph Hellwig
2024-10-22 14:13 ` Jens Axboe
2024-10-22 14:18 ` Jens Axboe
2024-10-22 14:19 ` Christoph Hellwig
2024-10-22 14:34 ` Keith Busch
2024-10-22 13:18 ` Sagi Grimberg
2024-10-22 14:20 ` Christoph Hellwig
2024-10-23 7:35 ` Guixin Liu
2024-10-23 12:24 ` Christoph Hellwig [this message]
2024-10-24 1:32 ` Guixin Liu
2024-10-23 7:06 ` Guixin Liu
2024-10-23 13:30 ` Dmitry Bogdanov
2024-10-24 2:04 ` Guixin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241023122453.GA29256@lst.de \
--to=hch@lst.de \
--cc=d.bogdanov@yadro.com \
--cc=kanie@linux.alibaba.com \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.