All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Kreimer <algonell@gmail.com>
To: git@vger.kernel.org
Cc: Andrew Kreimer <algonell@gmail.com>, Taylor Blau <me@ttaylorr.com>
Subject: [PATCH v2] t1016: clean up style
Date: Tue, 22 Oct 2024 14:07:30 +0300	[thread overview]
Message-ID: <20241022110730.7655-1-algonell@gmail.com> (raw)

Use `test_config`.

Remove whitespace after redirect operator.

Reported-by: Taylor Blau <me@ttaylorr.com>
Signed-off-by: Andrew Kreimer <algonell@gmail.com>
---
v1:
  - https://lore.kernel.org/all/20241020121729.27032-1-algonell@gmail.com/

v2:
  - Base on "ak/typofix":
    - https://lore.kernel.org/all/20241017112835.10100-1-algonell@gmail.com/
  - Tested:
    - ubuntu-latest, GitHub Actions.

 t/t1016-compatObjectFormat.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/t/t1016-compatObjectFormat.sh b/t/t1016-compatObjectFormat.sh
index 92024fe51d..8341a2fe83 100755
--- a/t/t1016-compatObjectFormat.sh
+++ b/t/t1016-compatObjectFormat.sh
@@ -116,8 +116,8 @@ do
 		git config core.repositoryformatversion 1 &&
 		git config extensions.objectformat $hash &&
 		git config extensions.compatobjectformat $(compat_hash $hash) &&
-		git config gpg.program $TEST_DIRECTORY/t1016/gpg &&
-		echo "Hello World!" > hello &&
+		test_config gpg.program $TEST_DIRECTORY/t1016/gpg &&
+		echo "Hello World!" >hello &&
 		eval hello_${hash}_oid=$(git hash-object hello) &&
 		git update-index --add hello &&
 		git commit -m "Initial commit" &&
-- 
2.39.5


             reply	other threads:[~2024-10-22 11:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-22 11:07 Andrew Kreimer [this message]
2024-10-22 16:36 ` [PATCH v2] t1016: clean up style Taylor Blau
2024-10-23 10:26   ` Andrew Kreimer
  -- strict thread matches above, loose matches on Subject: below --
2024-11-02 16:53 [PATCH] " Andrew Kreimer
2024-11-03 13:50 ` [PATCH v2] " Andrew Kreimer
2024-11-03 18:59   ` Kristoffer Haugsbakk
2024-11-03 23:42     ` Junio C Hamano
2024-11-04  9:06       ` Kristoffer Haugsbakk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241022110730.7655-1-algonell@gmail.com \
    --to=algonell@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=me@ttaylorr.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.