All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com>
Cc: "Andrew Kreimer" <algonell@gmail.com>,  git@vger.kernel.org
Subject: Re: [PATCH v2] t1016: clean up style
Date: Sun, 03 Nov 2024 15:42:35 -0800	[thread overview]
Message-ID: <xmqqcyjbyjdg.fsf@gitster.g> (raw)
In-Reply-To: <66df52dd-1b7c-4ca8-9752-646b5b223feb@app.fastmail.com> (Kristoffer Haugsbakk's message of "Sun, 03 Nov 2024 19:59:08 +0100")

"Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com> writes:

>> +	test_expect_success $PREREQ "Verify ${type} ${name}'s sha1 oid" '
>> +		git --git-dir=repo-sha256/.git rev-parse --output-object-format=sha1
>> ${sha256_oid} >${name}_sha1 &&
>> +		test_cmp ${name}_sha1 ${name}_sha1_expected
>> +	'
>
> At this point it _looks like_ some `test_expect_success` are moved
> around.  But my diff deceives me: all of the eight `test_` are provided
> in the same order in the preimage and postimage.

Yes, the output from "git show --histogram" seems to match the
corresponding blocks in preimage and postimage better in this case.

Thanks, both.

  reply	other threads:[~2024-11-03 23:42 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-02 16:53 [PATCH] t1016: clean up style Andrew Kreimer
2024-11-02 19:11 ` Kristoffer Haugsbakk
2024-11-03  2:42   ` Junio C Hamano
2024-11-03 13:49     ` Andrew Kreimer
2024-11-03 13:50 ` [PATCH v2] " Andrew Kreimer
2024-11-03 18:59   ` Kristoffer Haugsbakk
2024-11-03 23:42     ` Junio C Hamano [this message]
2024-11-04  9:06       ` Kristoffer Haugsbakk
  -- strict thread matches above, loose matches on Subject: below --
2024-10-22 11:07 Andrew Kreimer
2024-10-22 16:36 ` Taylor Blau
2024-10-23 10:26   ` Andrew Kreimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqcyjbyjdg.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=algonell@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=kristofferhaugsbakk@fastmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.