All of lore.kernel.org
 help / color / mirror / Atom feed
* sound/soc/intel/avs/boards/rt5682.c:219 avs_create_dai_link() warn: excess argument passed to 'devm_kasprintf'
@ 2023-11-29 10:16 kernel test robot
  0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2023-11-29 10:16 UTC (permalink / raw)
  To: oe-kbuild; +Cc: lkp, Dan Carpenter

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: "Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>
CC: Mark Brown <broonie@kernel.org>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   18d46e76d7c2eedd8577fae67e3f1d4db25018b0
commit: 2172c5b90d80aedc7cbe571e353ae45040e03a3b ASoC: Intel: avs: rt5682: Validate machine board configuration
date:   7 weeks ago
:::::: branch date: 12 hours ago
:::::: commit date: 7 weeks ago
config: arm64-randconfig-r081-20231127 (https://download.01.org/0day-ci/archive/20231129/202311291534.N6sBnJpC-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project.git f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce: (https://download.01.org/0day-ci/archive/20231129/202311291534.N6sBnJpC-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202311291534.N6sBnJpC-lkp@intel.com/

New smatch warnings:
sound/soc/intel/avs/boards/rt5682.c:219 avs_create_dai_link() warn: excess argument passed to 'devm_kasprintf'

Old smatch warnings:
sound/soc/intel/avs/boards/rt5682.c:226 avs_create_dai_link() warn: excess argument passed to 'devm_kasprintf'

vim +/devm_kasprintf +219 sound/soc/intel/avs/boards/rt5682.c

d24dbc865c2bd5 Amadeusz Sławiński 2023-03-03  205  
748102786b3ce0 Cezary Rojewski    2022-05-11  206  static int avs_create_dai_link(struct device *dev, const char *platform_name, int ssp_port,
2172c5b90d80ae Amadeusz Sławiński 2023-10-12  207  			       int tdm_slot, struct snd_soc_dai_link **dai_link)
748102786b3ce0 Cezary Rojewski    2022-05-11  208  {
748102786b3ce0 Cezary Rojewski    2022-05-11  209  	struct snd_soc_dai_link_component *platform;
748102786b3ce0 Cezary Rojewski    2022-05-11  210  	struct snd_soc_dai_link *dl;
748102786b3ce0 Cezary Rojewski    2022-05-11  211  
748102786b3ce0 Cezary Rojewski    2022-05-11  212  	dl = devm_kzalloc(dev, sizeof(*dl), GFP_KERNEL);
748102786b3ce0 Cezary Rojewski    2022-05-11  213  	platform = devm_kzalloc(dev, sizeof(*platform), GFP_KERNEL);
748102786b3ce0 Cezary Rojewski    2022-05-11  214  	if (!dl || !platform)
748102786b3ce0 Cezary Rojewski    2022-05-11  215  		return -ENOMEM;
748102786b3ce0 Cezary Rojewski    2022-05-11  216  
748102786b3ce0 Cezary Rojewski    2022-05-11  217  	platform->name = platform_name;
748102786b3ce0 Cezary Rojewski    2022-05-11  218  
2172c5b90d80ae Amadeusz Sławiński 2023-10-12 @219  	dl->name = devm_kasprintf(dev, GFP_KERNEL,
2172c5b90d80ae Amadeusz Sławiński 2023-10-12  220  				  AVS_STRING_FMT("SSP", "-Codec", ssp_port, tdm_slot));
748102786b3ce0 Cezary Rojewski    2022-05-11  221  	dl->cpus = devm_kzalloc(dev, sizeof(*dl->cpus), GFP_KERNEL);
748102786b3ce0 Cezary Rojewski    2022-05-11  222  	dl->codecs = devm_kzalloc(dev, sizeof(*dl->codecs), GFP_KERNEL);
748102786b3ce0 Cezary Rojewski    2022-05-11  223  	if (!dl->name || !dl->cpus || !dl->codecs)
748102786b3ce0 Cezary Rojewski    2022-05-11  224  		return -ENOMEM;
748102786b3ce0 Cezary Rojewski    2022-05-11  225  
2172c5b90d80ae Amadeusz Sławiński 2023-10-12  226  	dl->cpus->dai_name = devm_kasprintf(dev, GFP_KERNEL,
2172c5b90d80ae Amadeusz Sławiński 2023-10-12  227  					    AVS_STRING_FMT("SSP", " Pin", ssp_port, tdm_slot));
748102786b3ce0 Cezary Rojewski    2022-05-11  228  	dl->codecs->name = devm_kasprintf(dev, GFP_KERNEL, "i2c-10EC5682:00");
19bb7c3053ee54 Amadeusz Sławiński 2022-11-29  229  	dl->codecs->dai_name = devm_kasprintf(dev, GFP_KERNEL, AVS_RT5682_CODEC_DAI_NAME);
748102786b3ce0 Cezary Rojewski    2022-05-11  230  	if (!dl->cpus->dai_name || !dl->codecs->name || !dl->codecs->dai_name)
748102786b3ce0 Cezary Rojewski    2022-05-11  231  		return -ENOMEM;
748102786b3ce0 Cezary Rojewski    2022-05-11  232  
748102786b3ce0 Cezary Rojewski    2022-05-11  233  	dl->num_cpus = 1;
748102786b3ce0 Cezary Rojewski    2022-05-11  234  	dl->num_codecs = 1;
748102786b3ce0 Cezary Rojewski    2022-05-11  235  	dl->platforms = platform;
748102786b3ce0 Cezary Rojewski    2022-05-11  236  	dl->num_platforms = 1;
748102786b3ce0 Cezary Rojewski    2022-05-11  237  	dl->id = 0;
27cd41698de49c Cezary Rojewski    2023-06-29  238  	dl->dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBC_CFC;
748102786b3ce0 Cezary Rojewski    2022-05-11  239  	dl->init = avs_rt5682_codec_init;
a9d8723c72eada Amadeusz Sławiński 2022-11-29  240  	dl->exit = avs_rt5682_codec_exit;
d24dbc865c2bd5 Amadeusz Sławiński 2023-03-03  241  	dl->be_hw_params_fixup = avs_rt5682_be_fixup;
748102786b3ce0 Cezary Rojewski    2022-05-11  242  	dl->ops = &avs_rt5682_ops;
748102786b3ce0 Cezary Rojewski    2022-05-11  243  	dl->nonatomic = 1;
748102786b3ce0 Cezary Rojewski    2022-05-11  244  	dl->no_pcm = 1;
748102786b3ce0 Cezary Rojewski    2022-05-11  245  	dl->dpcm_capture = 1;
748102786b3ce0 Cezary Rojewski    2022-05-11  246  	dl->dpcm_playback = 1;
748102786b3ce0 Cezary Rojewski    2022-05-11  247  
748102786b3ce0 Cezary Rojewski    2022-05-11  248  	*dai_link = dl;
748102786b3ce0 Cezary Rojewski    2022-05-11  249  
748102786b3ce0 Cezary Rojewski    2022-05-11  250  	return 0;
748102786b3ce0 Cezary Rojewski    2022-05-11  251  }
748102786b3ce0 Cezary Rojewski    2022-05-11  252  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 4+ messages in thread

* sound/soc/intel/avs/boards/rt5682.c:219 avs_create_dai_link() warn: excess argument passed to 'devm_kasprintf'
@ 2023-12-10  8:35 kernel test robot
  0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2023-12-10  8:35 UTC (permalink / raw)
  To: oe-kbuild; +Cc: lkp, Dan Carpenter

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: "Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>
CC: Mark Brown <broonie@kernel.org>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   c527f5606aa545233a4d2c6d5c636ed82b8633ef
commit: 2172c5b90d80aedc7cbe571e353ae45040e03a3b ASoC: Intel: avs: rt5682: Validate machine board configuration
date:   8 weeks ago
:::::: branch date: 5 hours ago
:::::: commit date: 8 weeks ago
config: arm64-randconfig-r081-20231127 (https://download.01.org/0day-ci/archive/20231210/202312101652.6krC3ZJW-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project.git f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce: (https://download.01.org/0day-ci/archive/20231210/202312101652.6krC3ZJW-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202312101652.6krC3ZJW-lkp@intel.com/

New smatch warnings:
sound/soc/intel/avs/boards/rt5682.c:219 avs_create_dai_link() warn: excess argument passed to 'devm_kasprintf'

Old smatch warnings:
sound/soc/intel/avs/boards/rt5682.c:226 avs_create_dai_link() warn: excess argument passed to 'devm_kasprintf'

vim +/devm_kasprintf +219 sound/soc/intel/avs/boards/rt5682.c

d24dbc865c2bd5 Amadeusz Sławiński 2023-03-03  205  
748102786b3ce0 Cezary Rojewski    2022-05-11  206  static int avs_create_dai_link(struct device *dev, const char *platform_name, int ssp_port,
2172c5b90d80ae Amadeusz Sławiński 2023-10-12  207  			       int tdm_slot, struct snd_soc_dai_link **dai_link)
748102786b3ce0 Cezary Rojewski    2022-05-11  208  {
748102786b3ce0 Cezary Rojewski    2022-05-11  209  	struct snd_soc_dai_link_component *platform;
748102786b3ce0 Cezary Rojewski    2022-05-11  210  	struct snd_soc_dai_link *dl;
748102786b3ce0 Cezary Rojewski    2022-05-11  211  
748102786b3ce0 Cezary Rojewski    2022-05-11  212  	dl = devm_kzalloc(dev, sizeof(*dl), GFP_KERNEL);
748102786b3ce0 Cezary Rojewski    2022-05-11  213  	platform = devm_kzalloc(dev, sizeof(*platform), GFP_KERNEL);
748102786b3ce0 Cezary Rojewski    2022-05-11  214  	if (!dl || !platform)
748102786b3ce0 Cezary Rojewski    2022-05-11  215  		return -ENOMEM;
748102786b3ce0 Cezary Rojewski    2022-05-11  216  
748102786b3ce0 Cezary Rojewski    2022-05-11  217  	platform->name = platform_name;
748102786b3ce0 Cezary Rojewski    2022-05-11  218  
2172c5b90d80ae Amadeusz Sławiński 2023-10-12 @219  	dl->name = devm_kasprintf(dev, GFP_KERNEL,
2172c5b90d80ae Amadeusz Sławiński 2023-10-12  220  				  AVS_STRING_FMT("SSP", "-Codec", ssp_port, tdm_slot));
748102786b3ce0 Cezary Rojewski    2022-05-11  221  	dl->cpus = devm_kzalloc(dev, sizeof(*dl->cpus), GFP_KERNEL);
748102786b3ce0 Cezary Rojewski    2022-05-11  222  	dl->codecs = devm_kzalloc(dev, sizeof(*dl->codecs), GFP_KERNEL);
748102786b3ce0 Cezary Rojewski    2022-05-11  223  	if (!dl->name || !dl->cpus || !dl->codecs)
748102786b3ce0 Cezary Rojewski    2022-05-11  224  		return -ENOMEM;
748102786b3ce0 Cezary Rojewski    2022-05-11  225  
2172c5b90d80ae Amadeusz Sławiński 2023-10-12  226  	dl->cpus->dai_name = devm_kasprintf(dev, GFP_KERNEL,
2172c5b90d80ae Amadeusz Sławiński 2023-10-12  227  					    AVS_STRING_FMT("SSP", " Pin", ssp_port, tdm_slot));
748102786b3ce0 Cezary Rojewski    2022-05-11  228  	dl->codecs->name = devm_kasprintf(dev, GFP_KERNEL, "i2c-10EC5682:00");
19bb7c3053ee54 Amadeusz Sławiński 2022-11-29  229  	dl->codecs->dai_name = devm_kasprintf(dev, GFP_KERNEL, AVS_RT5682_CODEC_DAI_NAME);
748102786b3ce0 Cezary Rojewski    2022-05-11  230  	if (!dl->cpus->dai_name || !dl->codecs->name || !dl->codecs->dai_name)
748102786b3ce0 Cezary Rojewski    2022-05-11  231  		return -ENOMEM;
748102786b3ce0 Cezary Rojewski    2022-05-11  232  
748102786b3ce0 Cezary Rojewski    2022-05-11  233  	dl->num_cpus = 1;
748102786b3ce0 Cezary Rojewski    2022-05-11  234  	dl->num_codecs = 1;
748102786b3ce0 Cezary Rojewski    2022-05-11  235  	dl->platforms = platform;
748102786b3ce0 Cezary Rojewski    2022-05-11  236  	dl->num_platforms = 1;
748102786b3ce0 Cezary Rojewski    2022-05-11  237  	dl->id = 0;
27cd41698de49c Cezary Rojewski    2023-06-29  238  	dl->dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBC_CFC;
748102786b3ce0 Cezary Rojewski    2022-05-11  239  	dl->init = avs_rt5682_codec_init;
a9d8723c72eada Amadeusz Sławiński 2022-11-29  240  	dl->exit = avs_rt5682_codec_exit;
d24dbc865c2bd5 Amadeusz Sławiński 2023-03-03  241  	dl->be_hw_params_fixup = avs_rt5682_be_fixup;
748102786b3ce0 Cezary Rojewski    2022-05-11  242  	dl->ops = &avs_rt5682_ops;
748102786b3ce0 Cezary Rojewski    2022-05-11  243  	dl->nonatomic = 1;
748102786b3ce0 Cezary Rojewski    2022-05-11  244  	dl->no_pcm = 1;
748102786b3ce0 Cezary Rojewski    2022-05-11  245  	dl->dpcm_capture = 1;
748102786b3ce0 Cezary Rojewski    2022-05-11  246  	dl->dpcm_playback = 1;
748102786b3ce0 Cezary Rojewski    2022-05-11  247  
748102786b3ce0 Cezary Rojewski    2022-05-11  248  	*dai_link = dl;
748102786b3ce0 Cezary Rojewski    2022-05-11  249  
748102786b3ce0 Cezary Rojewski    2022-05-11  250  	return 0;
748102786b3ce0 Cezary Rojewski    2022-05-11  251  }
748102786b3ce0 Cezary Rojewski    2022-05-11  252  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 4+ messages in thread

* sound/soc/intel/avs/boards/rt5682.c:219 avs_create_dai_link() warn: excess argument passed to 'devm_kasprintf'
@ 2024-10-23 18:50 kernel test robot
  0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2024-10-23 18:50 UTC (permalink / raw)
  To: oe-kbuild; +Cc: lkp, Dan Carpenter

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: "Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>
CC: Mark Brown <broonie@kernel.org>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   c2ee9f594da826bea183ed14f2cc029c719bf4da
commit: 2172c5b90d80aedc7cbe571e353ae45040e03a3b ASoC: Intel: avs: rt5682: Validate machine board configuration
date:   1 year ago
:::::: branch date: 2 days ago
:::::: commit date: 1 year ago
config: sparc64-randconfig-r073-20241023 (https://download.01.org/0day-ci/archive/20241024/202410240230.Zlkr83mc-lkp@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 14.1.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202410240230.Zlkr83mc-lkp@intel.com/

New smatch warnings:
sound/soc/intel/avs/boards/rt5682.c:219 avs_create_dai_link() warn: excess argument passed to 'devm_kasprintf'

Old smatch warnings:
sound/soc/intel/avs/boards/rt5682.c:226 avs_create_dai_link() warn: excess argument passed to 'devm_kasprintf'

vim +/devm_kasprintf +219 sound/soc/intel/avs/boards/rt5682.c

d24dbc865c2bd5 Amadeusz Sławiński 2023-03-03  205  
748102786b3ce0 Cezary Rojewski    2022-05-11  206  static int avs_create_dai_link(struct device *dev, const char *platform_name, int ssp_port,
2172c5b90d80ae Amadeusz Sławiński 2023-10-12  207  			       int tdm_slot, struct snd_soc_dai_link **dai_link)
748102786b3ce0 Cezary Rojewski    2022-05-11  208  {
748102786b3ce0 Cezary Rojewski    2022-05-11  209  	struct snd_soc_dai_link_component *platform;
748102786b3ce0 Cezary Rojewski    2022-05-11  210  	struct snd_soc_dai_link *dl;
748102786b3ce0 Cezary Rojewski    2022-05-11  211  
748102786b3ce0 Cezary Rojewski    2022-05-11  212  	dl = devm_kzalloc(dev, sizeof(*dl), GFP_KERNEL);
748102786b3ce0 Cezary Rojewski    2022-05-11  213  	platform = devm_kzalloc(dev, sizeof(*platform), GFP_KERNEL);
748102786b3ce0 Cezary Rojewski    2022-05-11  214  	if (!dl || !platform)
748102786b3ce0 Cezary Rojewski    2022-05-11  215  		return -ENOMEM;
748102786b3ce0 Cezary Rojewski    2022-05-11  216  
748102786b3ce0 Cezary Rojewski    2022-05-11  217  	platform->name = platform_name;
748102786b3ce0 Cezary Rojewski    2022-05-11  218  
2172c5b90d80ae Amadeusz Sławiński 2023-10-12 @219  	dl->name = devm_kasprintf(dev, GFP_KERNEL,
2172c5b90d80ae Amadeusz Sławiński 2023-10-12  220  				  AVS_STRING_FMT("SSP", "-Codec", ssp_port, tdm_slot));
748102786b3ce0 Cezary Rojewski    2022-05-11  221  	dl->cpus = devm_kzalloc(dev, sizeof(*dl->cpus), GFP_KERNEL);
748102786b3ce0 Cezary Rojewski    2022-05-11  222  	dl->codecs = devm_kzalloc(dev, sizeof(*dl->codecs), GFP_KERNEL);
748102786b3ce0 Cezary Rojewski    2022-05-11  223  	if (!dl->name || !dl->cpus || !dl->codecs)
748102786b3ce0 Cezary Rojewski    2022-05-11  224  		return -ENOMEM;
748102786b3ce0 Cezary Rojewski    2022-05-11  225  
2172c5b90d80ae Amadeusz Sławiński 2023-10-12  226  	dl->cpus->dai_name = devm_kasprintf(dev, GFP_KERNEL,
2172c5b90d80ae Amadeusz Sławiński 2023-10-12  227  					    AVS_STRING_FMT("SSP", " Pin", ssp_port, tdm_slot));
748102786b3ce0 Cezary Rojewski    2022-05-11  228  	dl->codecs->name = devm_kasprintf(dev, GFP_KERNEL, "i2c-10EC5682:00");
19bb7c3053ee54 Amadeusz Sławiński 2022-11-29  229  	dl->codecs->dai_name = devm_kasprintf(dev, GFP_KERNEL, AVS_RT5682_CODEC_DAI_NAME);
748102786b3ce0 Cezary Rojewski    2022-05-11  230  	if (!dl->cpus->dai_name || !dl->codecs->name || !dl->codecs->dai_name)
748102786b3ce0 Cezary Rojewski    2022-05-11  231  		return -ENOMEM;
748102786b3ce0 Cezary Rojewski    2022-05-11  232  
748102786b3ce0 Cezary Rojewski    2022-05-11  233  	dl->num_cpus = 1;
748102786b3ce0 Cezary Rojewski    2022-05-11  234  	dl->num_codecs = 1;
748102786b3ce0 Cezary Rojewski    2022-05-11  235  	dl->platforms = platform;
748102786b3ce0 Cezary Rojewski    2022-05-11  236  	dl->num_platforms = 1;
748102786b3ce0 Cezary Rojewski    2022-05-11  237  	dl->id = 0;
27cd41698de49c Cezary Rojewski    2023-06-29  238  	dl->dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBC_CFC;
748102786b3ce0 Cezary Rojewski    2022-05-11  239  	dl->init = avs_rt5682_codec_init;
a9d8723c72eada Amadeusz Sławiński 2022-11-29  240  	dl->exit = avs_rt5682_codec_exit;
d24dbc865c2bd5 Amadeusz Sławiński 2023-03-03  241  	dl->be_hw_params_fixup = avs_rt5682_be_fixup;
748102786b3ce0 Cezary Rojewski    2022-05-11  242  	dl->ops = &avs_rt5682_ops;
748102786b3ce0 Cezary Rojewski    2022-05-11  243  	dl->nonatomic = 1;
748102786b3ce0 Cezary Rojewski    2022-05-11  244  	dl->no_pcm = 1;
748102786b3ce0 Cezary Rojewski    2022-05-11  245  	dl->dpcm_capture = 1;
748102786b3ce0 Cezary Rojewski    2022-05-11  246  	dl->dpcm_playback = 1;
748102786b3ce0 Cezary Rojewski    2022-05-11  247  
748102786b3ce0 Cezary Rojewski    2022-05-11  248  	*dai_link = dl;
748102786b3ce0 Cezary Rojewski    2022-05-11  249  
748102786b3ce0 Cezary Rojewski    2022-05-11  250  	return 0;
748102786b3ce0 Cezary Rojewski    2022-05-11  251  }
748102786b3ce0 Cezary Rojewski    2022-05-11  252  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 4+ messages in thread

* sound/soc/intel/avs/boards/rt5682.c:219 avs_create_dai_link() warn: excess argument passed to 'devm_kasprintf'
@ 2024-10-25  3:51 kernel test robot
  0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2024-10-25  3:51 UTC (permalink / raw)
  To: oe-kbuild; +Cc: lkp, Dan Carpenter

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: "Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>
CC: Mark Brown <broonie@kernel.org>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   ae90f6a6170d7a7a1aa4fddf664fbd093e3023bc
commit: 2172c5b90d80aedc7cbe571e353ae45040e03a3b ASoC: Intel: avs: rt5682: Validate machine board configuration
date:   1 year ago
:::::: branch date: 4 hours ago
:::::: commit date: 1 year ago
config: sparc64-randconfig-r073-20241023 (https://download.01.org/0day-ci/archive/20241025/202410251155.ddFJ0tcv-lkp@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 14.1.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202410251155.ddFJ0tcv-lkp@intel.com/

New smatch warnings:
sound/soc/intel/avs/boards/rt5682.c:219 avs_create_dai_link() warn: excess argument passed to 'devm_kasprintf'

Old smatch warnings:
sound/soc/intel/avs/boards/rt5682.c:226 avs_create_dai_link() warn: excess argument passed to 'devm_kasprintf'

vim +/devm_kasprintf +219 sound/soc/intel/avs/boards/rt5682.c

d24dbc865c2bd5 Amadeusz Sławiński 2023-03-03  205  
748102786b3ce0 Cezary Rojewski    2022-05-11  206  static int avs_create_dai_link(struct device *dev, const char *platform_name, int ssp_port,
2172c5b90d80ae Amadeusz Sławiński 2023-10-12  207  			       int tdm_slot, struct snd_soc_dai_link **dai_link)
748102786b3ce0 Cezary Rojewski    2022-05-11  208  {
748102786b3ce0 Cezary Rojewski    2022-05-11  209  	struct snd_soc_dai_link_component *platform;
748102786b3ce0 Cezary Rojewski    2022-05-11  210  	struct snd_soc_dai_link *dl;
748102786b3ce0 Cezary Rojewski    2022-05-11  211  
748102786b3ce0 Cezary Rojewski    2022-05-11  212  	dl = devm_kzalloc(dev, sizeof(*dl), GFP_KERNEL);
748102786b3ce0 Cezary Rojewski    2022-05-11  213  	platform = devm_kzalloc(dev, sizeof(*platform), GFP_KERNEL);
748102786b3ce0 Cezary Rojewski    2022-05-11  214  	if (!dl || !platform)
748102786b3ce0 Cezary Rojewski    2022-05-11  215  		return -ENOMEM;
748102786b3ce0 Cezary Rojewski    2022-05-11  216  
748102786b3ce0 Cezary Rojewski    2022-05-11  217  	platform->name = platform_name;
748102786b3ce0 Cezary Rojewski    2022-05-11  218  
2172c5b90d80ae Amadeusz Sławiński 2023-10-12 @219  	dl->name = devm_kasprintf(dev, GFP_KERNEL,
2172c5b90d80ae Amadeusz Sławiński 2023-10-12  220  				  AVS_STRING_FMT("SSP", "-Codec", ssp_port, tdm_slot));
748102786b3ce0 Cezary Rojewski    2022-05-11  221  	dl->cpus = devm_kzalloc(dev, sizeof(*dl->cpus), GFP_KERNEL);
748102786b3ce0 Cezary Rojewski    2022-05-11  222  	dl->codecs = devm_kzalloc(dev, sizeof(*dl->codecs), GFP_KERNEL);
748102786b3ce0 Cezary Rojewski    2022-05-11  223  	if (!dl->name || !dl->cpus || !dl->codecs)
748102786b3ce0 Cezary Rojewski    2022-05-11  224  		return -ENOMEM;
748102786b3ce0 Cezary Rojewski    2022-05-11  225  
2172c5b90d80ae Amadeusz Sławiński 2023-10-12  226  	dl->cpus->dai_name = devm_kasprintf(dev, GFP_KERNEL,
2172c5b90d80ae Amadeusz Sławiński 2023-10-12  227  					    AVS_STRING_FMT("SSP", " Pin", ssp_port, tdm_slot));
748102786b3ce0 Cezary Rojewski    2022-05-11  228  	dl->codecs->name = devm_kasprintf(dev, GFP_KERNEL, "i2c-10EC5682:00");
19bb7c3053ee54 Amadeusz Sławiński 2022-11-29  229  	dl->codecs->dai_name = devm_kasprintf(dev, GFP_KERNEL, AVS_RT5682_CODEC_DAI_NAME);
748102786b3ce0 Cezary Rojewski    2022-05-11  230  	if (!dl->cpus->dai_name || !dl->codecs->name || !dl->codecs->dai_name)
748102786b3ce0 Cezary Rojewski    2022-05-11  231  		return -ENOMEM;
748102786b3ce0 Cezary Rojewski    2022-05-11  232  
748102786b3ce0 Cezary Rojewski    2022-05-11  233  	dl->num_cpus = 1;
748102786b3ce0 Cezary Rojewski    2022-05-11  234  	dl->num_codecs = 1;
748102786b3ce0 Cezary Rojewski    2022-05-11  235  	dl->platforms = platform;
748102786b3ce0 Cezary Rojewski    2022-05-11  236  	dl->num_platforms = 1;
748102786b3ce0 Cezary Rojewski    2022-05-11  237  	dl->id = 0;
27cd41698de49c Cezary Rojewski    2023-06-29  238  	dl->dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBC_CFC;
748102786b3ce0 Cezary Rojewski    2022-05-11  239  	dl->init = avs_rt5682_codec_init;
a9d8723c72eada Amadeusz Sławiński 2022-11-29  240  	dl->exit = avs_rt5682_codec_exit;
d24dbc865c2bd5 Amadeusz Sławiński 2023-03-03  241  	dl->be_hw_params_fixup = avs_rt5682_be_fixup;
748102786b3ce0 Cezary Rojewski    2022-05-11  242  	dl->ops = &avs_rt5682_ops;
748102786b3ce0 Cezary Rojewski    2022-05-11  243  	dl->nonatomic = 1;
748102786b3ce0 Cezary Rojewski    2022-05-11  244  	dl->no_pcm = 1;
748102786b3ce0 Cezary Rojewski    2022-05-11  245  	dl->dpcm_capture = 1;
748102786b3ce0 Cezary Rojewski    2022-05-11  246  	dl->dpcm_playback = 1;
748102786b3ce0 Cezary Rojewski    2022-05-11  247  
748102786b3ce0 Cezary Rojewski    2022-05-11  248  	*dai_link = dl;
748102786b3ce0 Cezary Rojewski    2022-05-11  249  
748102786b3ce0 Cezary Rojewski    2022-05-11  250  	return 0;
748102786b3ce0 Cezary Rojewski    2022-05-11  251  }
748102786b3ce0 Cezary Rojewski    2022-05-11  252  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-10-25  3:51 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-23 18:50 sound/soc/intel/avs/boards/rt5682.c:219 avs_create_dai_link() warn: excess argument passed to 'devm_kasprintf' kernel test robot
  -- strict thread matches above, loose matches on Subject: below --
2024-10-25  3:51 kernel test robot
2023-12-10  8:35 kernel test robot
2023-11-29 10:16 kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.