From: Simon Horman <horms@kernel.org>
To: Yue Haibing <yuehaibing@huawei.com>
Cc: anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, ast@kernel.org, daniel@iogearbox.net,
hawk@kernel.org, john.fastabend@gmail.com,
maciej.fijalkowski@intel.com, vedang.patel@intel.com,
jithu.joseph@intel.com, andre.guedes@intel.com,
jacob.e.keller@intel.com, sven.auhagen@voleatech.de,
alexander.h.duyck@intel.com, intel-wired-lan@lists.osuosl.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
bpf@vger.kernel.org
Subject: Re: [PATCH v4 net-next 4/4] ixgbevf: Fix passing 0 to ERR_PTR in ixgbevf_run_xdp()
Date: Sat, 26 Oct 2024 16:38:10 +0100 [thread overview]
Message-ID: <20241026153810.GN1507976@kernel.org> (raw)
In-Reply-To: <20241026041249.1267664-5-yuehaibing@huawei.com>
On Sat, Oct 26, 2024 at 12:12:49PM +0800, Yue Haibing wrote:
> ixgbevf_run_xdp() converts customed xdp action to a negative error code
> with the sk_buff pointer type which be checked with IS_ERR in
> ixgbevf_clean_rx_irq(). Remove this error pointer handing instead use
> plain int return value.
>
> Fixes: c7aec59657b6 ("ixgbevf: Add XDP support for pass and drop actions")
> Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
> Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
Reviewed-by: Simon Horman <horms@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Yue Haibing <yuehaibing@huawei.com>
Cc: alexander.h.duyck@intel.com, andre.guedes@intel.com,
maciej.fijalkowski@intel.com, hawk@kernel.org,
daniel@iogearbox.net, jithu.joseph@intel.com,
przemyslaw.kitszel@intel.com, john.fastabend@gmail.com,
ast@kernel.org, linux-kernel@vger.kernel.org,
edumazet@google.com, netdev@vger.kernel.org,
anthony.l.nguyen@intel.com, intel-wired-lan@lists.osuosl.org,
jacob.e.keller@intel.com, kuba@kernel.org, bpf@vger.kernel.org,
pabeni@redhat.com, davem@davemloft.net, vedang.patel@intel.com
Subject: Re: [Intel-wired-lan] [PATCH v4 net-next 4/4] ixgbevf: Fix passing 0 to ERR_PTR in ixgbevf_run_xdp()
Date: Sat, 26 Oct 2024 16:38:10 +0100 [thread overview]
Message-ID: <20241026153810.GN1507976@kernel.org> (raw)
In-Reply-To: <20241026041249.1267664-5-yuehaibing@huawei.com>
On Sat, Oct 26, 2024 at 12:12:49PM +0800, Yue Haibing wrote:
> ixgbevf_run_xdp() converts customed xdp action to a negative error code
> with the sk_buff pointer type which be checked with IS_ERR in
> ixgbevf_clean_rx_irq(). Remove this error pointer handing instead use
> plain int return value.
>
> Fixes: c7aec59657b6 ("ixgbevf: Add XDP support for pass and drop actions")
> Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
> Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-10-26 15:38 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-26 4:12 [PATCH v4 net-next 0/4] Fix passing 0 to ERR_PTR in intel ether drivers Yue Haibing
2024-10-26 4:12 ` [Intel-wired-lan] " Yue Haibing
2024-10-26 4:12 ` [PATCH v4 net-next 1/4] igc: Fix passing 0 to ERR_PTR in igc_xdp_run_prog() Yue Haibing
2024-10-26 4:12 ` [Intel-wired-lan] " Yue Haibing
2024-10-26 15:37 ` Simon Horman
2024-10-26 15:37 ` [Intel-wired-lan] " Simon Horman
2024-11-06 13:22 ` Avigail Dahan
2024-10-26 4:12 ` [PATCH v4 net-next 2/4] igb: Fix passing 0 to ERR_PTR in igb_run_xdp() Yue Haibing
2024-10-26 4:12 ` [Intel-wired-lan] " Yue Haibing
2024-10-26 15:37 ` Simon Horman
2024-10-26 15:37 ` [Intel-wired-lan] " Simon Horman
2024-11-12 12:26 ` Rout, ChandanX
2024-11-12 12:26 ` Rout, ChandanX
2024-10-26 4:12 ` [PATCH v4 net-next 3/4] ixgbe: Fix passing 0 to ERR_PTR in ixgbe_run_xdp() Yue Haibing
2024-10-26 4:12 ` [Intel-wired-lan] " Yue Haibing
2024-10-26 15:37 ` Simon Horman
2024-10-26 15:37 ` [Intel-wired-lan] " Simon Horman
2024-11-12 12:25 ` Rout, ChandanX
2024-11-12 12:25 ` Rout, ChandanX
2024-10-26 4:12 ` [PATCH v4 net-next 4/4] ixgbevf: Fix passing 0 to ERR_PTR in ixgbevf_run_xdp() Yue Haibing
2024-10-26 4:12 ` [Intel-wired-lan] " Yue Haibing
2024-10-26 15:38 ` Simon Horman [this message]
2024-10-26 15:38 ` Simon Horman
2024-11-12 12:22 ` Rout, ChandanX
2024-11-12 12:22 ` Rout, ChandanX
2024-10-29 14:44 ` [PATCH v4 net-next 0/4] Fix passing 0 to ERR_PTR in intel ether drivers Jakub Kicinski
2024-10-29 14:44 ` [Intel-wired-lan] " Jakub Kicinski
2024-10-29 18:37 ` Tony Nguyen
2024-10-29 18:37 ` [Intel-wired-lan] " Tony Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241026153810.GN1507976@kernel.org \
--to=horms@kernel.org \
--cc=alexander.h.duyck@intel.com \
--cc=andre.guedes@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacob.e.keller@intel.com \
--cc=jithu.joseph@intel.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=sven.auhagen@voleatech.de \
--cc=vedang.patel@intel.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.