From: Jakub Kicinski <kuba@kernel.org>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>,
Michael Chan <michael.chan@broadcom.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Potnuri Bharat Teja <bharat@chelsio.com>,
Christian Benvenuti <benve@cisco.com>,
Satish Kharat <satishkh@cisco.com>,
Manish Chopra <manishc@marvell.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH 2/2][next] net: ethtool: Avoid thousands of -Wflex-array-member-not-at-end warnings
Date: Mon, 28 Oct 2024 17:32:48 -0700 [thread overview]
Message-ID: <20241028173248.582080ae@kernel.org> (raw)
In-Reply-To: <158eb222-d875-4f96-b027-83854e5f4275@embeddedor.com>
On Mon, 28 Oct 2024 17:32:53 -0600 Gustavo A. R. Silva wrote:
> >> Additionally, update the type of some variables in various functions
> >> that don't access the flexible-array member, changing them to the
> >> newly created `struct ethtool_link_settings_hdr`.
> >
> > Why? Please avoid unnecessary code changes.
>
> This is actually necessary. As the type of the conflicting middle members
> changed, those instances that expect the type to be `struct ethtool_link_settings`
> should be adjusted to the new type. Another option is to leave the type
> unchanged and instead use container_of. See below.
Ah, that makes sense. So they need to be included int the newly split
patch. Please rephrase the commit message a bit, the current paragraph
reads as if this was a code cleanup.
next prev parent reply other threads:[~2024-10-29 0:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-21 19:01 [PATCH 0/2][next] UAPI: net/ethtool: Avoid thousands of -Wflex-array-member-not-at-end warnings Gustavo A. R. Silva
2024-10-21 19:01 ` [PATCH 1/2][next] UAPI: ethtool: Use __struct_group() in struct ethtool_link_settings Gustavo A. R. Silva
2024-10-21 20:11 ` Andrew Lunn
2024-10-23 21:30 ` Gustavo A. R. Silva
2024-10-21 19:02 ` [PATCH 2/2][next] net: ethtool: Avoid thousands of -Wflex-array-member-not-at-end warnings Gustavo A. R. Silva
2024-10-28 23:21 ` Jakub Kicinski
2024-10-28 23:32 ` Gustavo A. R. Silva
2024-10-29 0:32 ` Jakub Kicinski [this message]
2024-10-29 2:37 ` Gustavo A. R. Silva
2024-10-29 13:56 ` Jakub Kicinski
2024-10-29 13:58 ` Jakub Kicinski
2024-10-29 16:55 ` Gustavo A. R. Silva
2024-10-29 18:08 ` Jakub Kicinski
2024-10-29 18:18 ` Gustavo A. R. Silva
2024-10-29 18:39 ` Jakub Kicinski
2024-10-29 18:48 ` Gustavo A. R. Silva
2024-10-29 18:54 ` Jakub Kicinski
2024-10-29 19:18 ` Gustavo A. R. Silva
2024-10-29 20:00 ` Jakub Kicinski
2024-10-29 22:06 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241028173248.582080ae@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=benve@cisco.com \
--cc=bharat@chelsio.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gustavo@embeddedor.com \
--cc=gustavoars@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manishc@marvell.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=satishkh@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.