All of lore.kernel.org
 help / color / mirror / Atom feed
* [frank-w-bpi-r2-4.14:6.12-rsslro 63/70] drivers/net/ethernet/mediatek/mtk_eth_soc.c:3149:33: warning: variable 'ip4dst' is uninitialized when used here
@ 2024-10-28 13:12 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2024-10-28 13:12 UTC (permalink / raw)
  To: Frank Wunderlich; +Cc: oe-kbuild-all

tree:   https://github.com/frank-w/BPI-R2-4.14 6.12-rsslro
head:   edb2a7a8be4be71a6502d19afd5b069f6d9fbacc
commit: 581f68b8ee8e130ab90cabf695798606e12711de [63/70] net: lro patch from balika011
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20241028/202410282145.2sawKayp-lkp@intel.com/config)
compiler: clang version 19.1.2 (https://github.com/llvm/llvm-project 7ba7d8e2f7b6445b60679da826210cdde29eaf8b)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241028/202410282145.2sawKayp-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410282145.2sawKayp-lkp@intel.com/

All warnings (new ones prefixed by >>):

   In file included from drivers/net/ethernet/mediatek/mtk_eth_soc.c:10:
   In file included from include/linux/of_mdio.h:12:
   In file included from include/linux/phy.h:16:
   In file included from include/linux/ethtool.h:18:
   In file included from include/linux/if_ether.h:19:
   In file included from include/linux/skbuff.h:17:
   In file included from include/linux/bvec.h:10:
   In file included from include/linux/highmem.h:8:
   In file included from include/linux/cacheflush.h:5:
   In file included from arch/x86/include/asm/cacheflush.h:5:
   In file included from include/linux/mm.h:2213:
   include/linux/vmstat.h:504:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
     504 |         return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~ ^
     505 |                            item];
         |                            ~~~~
   include/linux/vmstat.h:511:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
     511 |         return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~ ^
     512 |                            NR_VM_NUMA_EVENT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~~
   include/linux/vmstat.h:518:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
     518 |         return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
         |                               ~~~~~~~~~~~ ^ ~~~
   include/linux/vmstat.h:524:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
     524 |         return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~ ^
     525 |                            NR_VM_NUMA_EVENT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/ethernet/mediatek/mtk_eth_soc.c:1897:34: error: incompatible pointer types passing 'struct net_device **' to parameter of type 'struct net_device *'; remove & [-Werror,-Wincompatible-pointer-types]
    1897 |         err = __xdp_rxq_info_reg(xdp_q, &eth->dummy_dev, id,
         |                                         ^~~~~~~~~~~~~~~
   include/net/xdp.h:335:29: note: passing argument to parameter 'dev' here
     335 |                        struct net_device *dev, u32 queue_index,
         |                                           ^
>> drivers/net/ethernet/mediatek/mtk_eth_soc.c:3149:33: warning: variable 'ip4dst' is uninitialized when used here [-Wuninitialized]
    3149 |         mac->hwlro_ip[fsp->location] = ip4dst;
         |                                        ^~~~~~
   drivers/net/ethernet/mediatek/mtk_eth_soc.c:3138:12: note: initialize the variable 'ip4dst' to silence this warning
    3138 |         u32 ip4dst;
         |                   ^
         |                    = 0
   drivers/net/ethernet/mediatek/mtk_eth_soc.c:5694:20: error: incompatible pointer types passing 'struct net_device **' to parameter of type 'struct net_device *'; remove & [-Werror,-Wincompatible-pointer-types]
    5694 |         init_dummy_netdev(&eth->dummy_dev);
         |                           ^~~~~~~~~~~~~~~
   include/linux/netdevice.h:3123:43: note: passing argument to parameter 'dev' here
    3123 | void init_dummy_netdev(struct net_device *dev);
         |                                           ^
   drivers/net/ethernet/mediatek/mtk_eth_soc.c:5695:17: error: incompatible pointer types passing 'struct net_device **' to parameter of type 'struct net_device *'; remove & [-Werror,-Wincompatible-pointer-types]
    5695 |         netif_napi_add(&eth->dummy_dev, &eth->tx_napi, mtk_napi_tx);
         |                        ^~~~~~~~~~~~~~~
   include/linux/netdevice.h:2635:35: note: passing argument to parameter 'dev' here
    2635 | netif_napi_add(struct net_device *dev, struct napi_struct *napi,
         |                                   ^
   drivers/net/ethernet/mediatek/mtk_eth_soc.c:5696:17: error: incompatible pointer types passing 'struct net_device **' to parameter of type 'struct net_device *'; remove & [-Werror,-Wincompatible-pointer-types]
    5696 |         netif_napi_add(&eth->dummy_dev, &eth->rx_napi[0].napi, mtk_napi_rx);
         |                        ^~~~~~~~~~~~~~~
   include/linux/netdevice.h:2635:35: note: passing argument to parameter 'dev' here
    2635 | netif_napi_add(struct net_device *dev, struct napi_struct *napi,
         |                                   ^
   drivers/net/ethernet/mediatek/mtk_eth_soc.c:5700:19: error: incompatible pointer types passing 'struct net_device **' to parameter of type 'struct net_device *'; remove & [-Werror,-Wincompatible-pointer-types]
    5700 |                         netif_napi_add(&eth->dummy_dev, &eth->rx_napi[MTK_RSS_RING(i)].napi,
         |                                        ^~~~~~~~~~~~~~~
   include/linux/netdevice.h:2635:35: note: passing argument to parameter 'dev' here
    2635 | netif_napi_add(struct net_device *dev, struct napi_struct *napi,
         |                                   ^
   drivers/net/ethernet/mediatek/mtk_eth_soc.c:5706:19: error: incompatible pointer types passing 'struct net_device **' to parameter of type 'struct net_device *'; remove & [-Werror,-Wincompatible-pointer-types]
    5706 |                         netif_napi_add(&eth->dummy_dev, &eth->rx_napi[MTK_HW_LRO_RING(i)].napi,
         |                                        ^~~~~~~~~~~~~~~
   include/linux/netdevice.h:2635:35: note: passing argument to parameter 'dev' here
    2635 | netif_napi_add(struct net_device *dev, struct napi_struct *napi,
         |                                   ^
   drivers/net/ethernet/mediatek/mtk_eth_soc.c:5717:1: warning: unused label 'err_unreg_netdev' [-Wunused-label]
    5717 | err_unreg_netdev:
         | ^~~~~~~~~~~~~~~~~
   drivers/net/ethernet/mediatek/mtk_eth_soc.c:5788:20: error: use of undeclared identifier 'MTK_RX_DONE_INT'
    5788 |                 .irq_done_mask = MTK_RX_DONE_INT,
         |                                  ^
   drivers/net/ethernet/mediatek/mtk_eth_soc.c:5817:20: error: use of undeclared identifier 'MTK_RX_DONE_INT'
    5817 |                 .irq_done_mask = MTK_RX_DONE_INT,
         |                                  ^
   drivers/net/ethernet/mediatek/mtk_eth_soc.c:5848:20: error: use of undeclared identifier 'MTK_RX_DONE_INT'
    5848 |                 .irq_done_mask = MTK_RX_DONE_INT,
         |                                  ^
   drivers/net/ethernet/mediatek/mtk_eth_soc.c:5878:20: error: use of undeclared identifier 'MTK_RX_DONE_INT'
    5878 |                 .irq_done_mask = MTK_RX_DONE_INT,
         |                                  ^
   drivers/net/ethernet/mediatek/mtk_eth_soc.c:5905:20: error: use of undeclared identifier 'MTK_RX_DONE_INT'
    5905 |                 .irq_done_mask = MTK_RX_DONE_INT,
         |                                  ^
   drivers/net/ethernet/mediatek/mtk_eth_soc.c:5936:20: error: use of undeclared identifier 'MTK_RX_DONE_INT'
    5936 |                 .irq_done_mask = MTK_RX_DONE_INT,
         |                                  ^
   drivers/net/ethernet/mediatek/mtk_eth_soc.c:5967:20: error: use of undeclared identifier 'MTK_RX_DONE_INT'
    5967 |                 .irq_done_mask = MTK_RX_DONE_INT,
         |                                  ^
   drivers/net/ethernet/mediatek/mtk_eth_soc.c:5998:20: error: use of undeclared identifier 'MTK_RX_DONE_INT_V2'
    5998 |                 .irq_done_mask = MTK_RX_DONE_INT_V2,
         |                                  ^
   drivers/net/ethernet/mediatek/mtk_eth_soc.c:6022:20: error: use of undeclared identifier 'MTK_RX_DONE_INT'
    6022 |                 .irq_done_mask = MTK_RX_DONE_INT,
         |                                  ^
   6 warnings and 15 errors generated.

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for MODVERSIONS
   Depends on [n]: MODULES [=y] && !COMPILE_TEST [=y]
   Selected by [y]:
   - RANDSTRUCT_FULL [=y] && (CC_HAS_RANDSTRUCT [=y] || GCC_PLUGINS [=n]) && MODULES [=y]


vim +/ip4dst +3149 drivers/net/ethernet/mediatek/mtk_eth_soc.c

  3129	
  3130	static int mtk_hwlro_add_ipaddr(struct net_device *dev,
  3131					struct ethtool_rxnfc *cmd)
  3132	{
  3133		struct ethtool_rx_flow_spec *fsp =
  3134			(struct ethtool_rx_flow_spec *)&cmd->fs;
  3135		struct mtk_mac *mac = netdev_priv(dev);
  3136		struct mtk_eth *eth = mac->hw;
  3137		int hwlro_idx;
  3138		u32 ip4dst;
  3139	
  3140	printk(KERN_ALERT "DEBUG: Passed %s %d\n",__FUNCTION__,__LINE__);
  3141		if ((fsp->flow_type != TCP_V4_FLOW) ||
  3142		    (!fsp->h_u.tcp_ip4_spec.ip4dst) ||
  3143		    (fsp->location > 1))
  3144			return -EINVAL;
  3145	printk(KERN_ALERT "DEBUG: Passed %s %d\n",__FUNCTION__,__LINE__);
  3146		mac->hwlro_ip[fsp->location] = htonl(fsp->h_u.tcp_ip4_spec.ip4dst);
  3147		hwlro_idx = (mac->id * MTK_MAX_LRO_IP_CNT) + fsp->location;
  3148	
> 3149		mac->hwlro_ip[fsp->location] = ip4dst;
  3150	
  3151		mac->hwlro_ip_cnt = mtk_hwlro_get_ip_cnt(mac);
  3152	
  3153		mtk_hwlro_val_ipaddr(eth, hwlro_idx, mac->hwlro_ip[fsp->location]);
  3154	
  3155		return 0;
  3156	}
  3157	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2024-10-28 13:13 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-28 13:12 [frank-w-bpi-r2-4.14:6.12-rsslro 63/70] drivers/net/ethernet/mediatek/mtk_eth_soc.c:3149:33: warning: variable 'ip4dst' is uninitialized when used here kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.