All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Cc: Simon Glass <sjg@chromium.org>,
	u-boot@lists.denx.de, Caleb Connolly <caleb.connolly@linaro.org>,
	Ilias Apalodimas <ilias.apalodimas@linaro.org>
Subject: Re: [PATCH 3/3] test/lib/uuid: Make lib_test_dynamic_uuid depend on SANDBOX
Date: Mon, 28 Oct 2024 17:22:47 -0600	[thread overview]
Message-ID: <20241028232247.GW4959@bill-the-cat> (raw)
In-Reply-To: <e229e1d4-c2c9-4697-aa39-925a9ae5c75a@canonical.com>

[-- Attachment #1: Type: text/plain, Size: 1540 bytes --]

On Mon, Oct 28, 2024 at 11:01:05PM +0100, Heinrich Schuchardt wrote:
> On 10/28/24 22:34, Tom Rini wrote:
> > On Mon, Oct 28, 2024 at 10:24:58PM +0100, Heinrich Schuchardt wrote:
> > > On 10/28/24 17:48, Tom Rini wrote:
> > > > The dynamic UUID test checks for the sandbox specific capsule UUID to be
> > > > used, so we can only perform this test on sandbox currently.
> > > 
> > > The tested function is gen_v5_guid(). This function is used to generated
> > > capsule UUIDs. It receives the test data provided in dynamic_uuid_test_data
> > > test_data[]:
> > > 
> > > * compatible string
> > > * image name
> > > 
> > > The generated UUID is compared to a UUID provided in the test data.
> > > 
> > > By chance the chosen test data contains the string 'sandbox'.
> > > 
> > > It is not obvious why this test should depend on running on the sandbox.
> > > 
> > > Where did it fail for you?
> > 
> > On Pi 3, I forget if it was rpi_3 or rpi_arm64_defconfig (with tweaks
> > like enabling CONFIG_UNIT_TEST).
> > 
> 
> On qemu_arm64_defconfig the tests runs fine:
> 
> => ut lib lib_test_dynamic_uuid
> Test: lib_test_dynamic_uuid: uuid.c
> Failures: 0
> 
> Missing CONFIG_SANDBOX cannot be the cause of the issue that you observed.

Hunh, OK. Lets for now go with it being related to the 32bit UUID
problem:
https://lore.kernel.org/u-boot/4b60130d-030f-405c-a753-eeb52a5e7b1d@foss.st.com
and that it was on 32bit Pi only where I saw that failure, as indeed I
don't on 64bit Pi now. Thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

  reply	other threads:[~2024-10-28 23:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-28 16:48 [PATCH 1/3] test/cmd: Make some "ut dm" tests only available on sandbox Tom Rini
2024-10-28 16:48 ` [PATCH 2/3] test/hush: Add CONFIG_CONSOLE_RECORD where required Tom Rini
2024-10-28 21:08   ` Heinrich Schuchardt
2024-10-28 16:48 ` [PATCH 3/3] test/lib/uuid: Make lib_test_dynamic_uuid depend on SANDBOX Tom Rini
2024-10-28 21:24   ` Heinrich Schuchardt
2024-10-28 21:34     ` Tom Rini
2024-10-28 22:01       ` Heinrich Schuchardt
2024-10-28 23:22         ` Tom Rini [this message]
2024-10-28 21:02 ` [PATCH 1/3] test/cmd: Make some "ut dm" tests only available on sandbox Heinrich Schuchardt
2024-10-29 22:28 ` (subset) " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241028232247.GW4959@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=caleb.connolly@linaro.org \
    --cc=heinrich.schuchardt@canonical.com \
    --cc=ilias.apalodimas@linaro.org \
    --cc=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.