Re: [PATCH 3/3] test/lib/uuid: Make lib_test_dynamic_uuid depend on SANDBOX

[Heinrich Schuchardt <heinrich.schuchardt@canonical.com>]

On 10/28/24 17:48, Tom Rini wrote:
> The dynamic UUID test checks for the sandbox specific capsule UUID to be
> used, so we can only perform this test on sandbox currently.

The tested function is gen_v5_guid(). This function is used to generated 
capsule UUIDs. It receives the test data provided in 
dynamic_uuid_test_data test_data[]:

* compatible string
* image name

The generated UUID is compared to a UUID provided in the test data.

By chance the chosen test data contains the string 'sandbox'.

It is not obvious why this test should depend on running on the sandbox.

Where did it fail for you?

Best regards

Heinrich

> 
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
>   test/lib/uuid.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/test/lib/uuid.c b/test/lib/uuid.c
> index d00e9563a472..55ef9e7454d7 100644
> --- a/test/lib/uuid.c
> +++ b/test/lib/uuid.c
> @@ -84,6 +84,7 @@ static int lib_test_uuid_bits(struct unit_test_state *uts)
>   LIB_TEST(lib_test_uuid_bits, 0);
>   #endif
>   
> +#ifdef CONFIG_SANDBOX
>   struct dynamic_uuid_test_data {
>   	const char *compatible;
>   	const u16 *images[4];
> @@ -159,3 +160,4 @@ static int lib_test_dynamic_uuid(struct unit_test_state *uts)
>   }
>   
>   LIB_TEST(lib_test_dynamic_uuid, 0);
> +#endif