From: Christoph Hellwig <hch@lst.de>
To: Chaitanya Kulkarni <chaitanyak@nvidia.com>
Cc: Christoph Hellwig <hch@lst.de>,
Kundan Kumar <kundan.kumar@samsung.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH 2/2] block: remove bio_add_zone_append_page
Date: Wed, 30 Oct 2024 14:47:00 +0100 [thread overview]
Message-ID: <20241030134700.GA27762@lst.de> (raw)
In-Reply-To: <790362cd-dfbb-4ca7-879a-68463156b69a@nvidia.com>
On Wed, Oct 30, 2024 at 07:30:49AM +0000, Chaitanya Kulkarni wrote:
> if that is true should we just use the bio_add_hw_page() ? since
> bio_add_pc_page() is a simple wrapper over bio_add_hw_page() without
> the additional checks present in bio_add_zone_append_page() ?
bio_add_hw_page is currently static. But just renaming bio_add_pc_page
to bio_add_hw_page and finding a different name for the version with
the same_page argument sounds like a good idea, but that's for a follow
on patch. I can look into that.
> unless for some reason I failed to understand REQ_OP_ZONE_APPEND
> is categorized here as a passthru request, then sorry for wasting
> your time ...
It is not a passthrough request, but it is treated as one.
next prev parent reply other threads:[~2024-10-30 13:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-30 5:18 drop some broken zone append support code Christoph Hellwig
2024-10-30 5:18 ` [PATCH 1/2] block: remove zone append special casing from the direct I/O path Christoph Hellwig
2024-10-30 18:32 ` Chaitanya Kulkarni
2024-10-31 16:54 ` Jens Axboe
2024-10-30 5:18 ` [PATCH 2/2] block: remove bio_add_zone_append_page Christoph Hellwig
2024-10-30 7:30 ` Chaitanya Kulkarni
2024-10-30 13:47 ` Christoph Hellwig [this message]
2024-10-30 18:31 ` Chaitanya Kulkarni
2024-10-30 18:47 ` drop some broken zone append support code Johannes Thumshirn
2024-10-31 12:58 ` hch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241030134700.GA27762@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=chaitanyak@nvidia.com \
--cc=kundan.kumar@samsung.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.