From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
Cc: Chaitanya Kulkarni <chaitanyak@nvidia.com>,
Kundan Kumar <kundan.kumar@samsung.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH 1/2] block: remove zone append special casing from the direct I/O path
Date: Wed, 30 Oct 2024 18:32:40 +0000 [thread overview]
Message-ID: <8ad0f4e6-c232-4d88-adbd-894facd24089@nvidia.com> (raw)
In-Reply-To: <20241030051859.280923-2-hch@lst.de>
On 10/29/24 22:18, Christoph Hellwig wrote:
> This code is unused, and all future zoned file systems should follow
> the btrfs lead of splitting the bios themselves to the zoned limits
> in the I/O submission handler, because if they didn't they would be
> hit by commit ed9832bc08db ("block: introduce folio awareness and add
> a bigger size from folio") breaking this code when the zone append
> limit (that is usually the max_hw_sectors limit) is smaller than the
> largest possible folio size.
>
> Signed-off-by: Christoph Hellwig<hch@lst.de>
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
next prev parent reply other threads:[~2024-10-30 18:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-30 5:18 drop some broken zone append support code Christoph Hellwig
2024-10-30 5:18 ` [PATCH 1/2] block: remove zone append special casing from the direct I/O path Christoph Hellwig
2024-10-30 18:32 ` Chaitanya Kulkarni [this message]
2024-10-31 16:54 ` Jens Axboe
2024-10-30 5:18 ` [PATCH 2/2] block: remove bio_add_zone_append_page Christoph Hellwig
2024-10-30 7:30 ` Chaitanya Kulkarni
2024-10-30 13:47 ` Christoph Hellwig
2024-10-30 18:31 ` Chaitanya Kulkarni
2024-10-30 18:47 ` drop some broken zone append support code Johannes Thumshirn
2024-10-31 12:58 ` hch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ad0f4e6-c232-4d88-adbd-894facd24089@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kundan.kumar@samsung.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.