From: Andreas Kemnade <andreas@kemnade.info>
To: Mithil Bavishi <bavishimithil@gmail.com>
Cc: Aaro Koskinen <aaro.koskinen@iki.fi>,
Kevin Hilman <khilman@baylibre.com>,
Roger Quadros <rogerq@kernel.org>,
Tony Lindgren <tony@atomide.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH v1 2/6] arm/dts: Add common device tree for Samsung Galaxy Tab 2 series
Date: Wed, 30 Oct 2024 20:55:35 +0100 [thread overview]
Message-ID: <20241030205535.7ea507ea@akair> (raw)
In-Reply-To: <20241030194136.297648-3-bavishimithil@gmail.com>
Hi,
a quick first pass of review.
Am Wed, 30 Oct 2024 19:41:32 +0000
schrieb Mithil Bavishi <bavishimithil@gmail.com>:
> Create common device tree for Samsung Espresso series devices
>
> Differentiate based on screen sizes, panels, touch controllers,
> and batteries
>
> Signed-off-by: Mithil Bavishi <bavishimithil@gmail.com>
> ---
[...]
> + backlight_pins: pinmux_backlight_pins {
- instead of _ in node names please, also for other places:
backlight_pins: pinmux-backlight-pins
[...]
> +
> +#include "twl6030.dtsi"
> +
really??? you include both twl6030 and twl6032. That does not make any
sense. Including twl6030_omap4.dtsi might make sense but not
twl6030.dtsi.
Regards,
Andreas
next prev parent reply other threads:[~2024-10-30 19:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-30 19:41 [PATCH v1 0/6] Initial support for Samsung Galaxy Tab 2 series Mithil Bavishi
2024-10-30 19:41 ` [PATCH v1 1/6] ARM: dts: twl6032: Add DTS file for TWL6032 PMIC Mithil Bavishi
2024-10-30 19:41 ` [PATCH v1 2/6] arm/dts: Add common device tree for Samsung Galaxy Tab 2 series Mithil Bavishi
2024-10-30 19:55 ` Andreas Kemnade [this message]
2024-10-30 19:41 ` [PATCH v1 3/6] dt-bindings: omap: Add Samaung Galaxy Tab 2 7.0 Mithil Bavishi
2024-10-30 19:41 ` [PATCH v1 4/6] arm/dts: Add initial support for " Mithil Bavishi
2024-10-30 20:37 ` Andreas Kemnade
2024-10-30 19:41 ` [PATCH v1 5/6] dt-bindings: omap: Add Samaung Galaxy Tab 2 10.1 Mithil Bavishi
2024-10-30 19:41 ` [PATCH v1 6/6] arm/dts: Add initial support for " Mithil Bavishi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241030205535.7ea507ea@akair \
--to=andreas@kemnade.info \
--cc=aaro.koskinen@iki.fi \
--cc=bavishimithil@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh@kernel.org \
--cc=rogerq@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.