All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Kemnade <andreas@kemnade.info>
To: Mithil Bavishi <bavishimithil@gmail.com>
Cc: Aaro Koskinen <aaro.koskinen@iki.fi>,
	Kevin Hilman <khilman@baylibre.com>,
	Roger Quadros <rogerq@kernel.org>,
	Tony Lindgren <tony@atomide.com>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH v1 4/6] arm/dts: Add initial support for Galaxy Tab 2 7.0
Date: Wed, 30 Oct 2024 21:37:13 +0100	[thread overview]
Message-ID: <20241030213713.45223f64@akair> (raw)
In-Reply-To: <20241030194136.297648-5-bavishimithil@gmail.com>

Am Wed, 30 Oct 2024 19:41:34 +0000
schrieb Mithil Bavishi <bavishimithil@gmail.com>:

> Create a device tree for the 3 inch variants (P3100, P3110, P3113)
> 
> Signed-off-by: Mithil Bavishi <bavishimithil@gmail.com>
> ---
>  arch/arm/boot/dts/ti/omap/Makefile            |  1 +
>  .../dts/ti/omap/omap4-samsung-espresso7.dts   | 70
> +++++++++++++++++++ 2 files changed, 71 insertions(+)
>  create mode 100644
> arch/arm/boot/dts/ti/omap/omap4-samsung-espresso7.dts
> 
  DTC     arch/arm/boot/dts/ti/omap/omap4-samsung-espresso7.dtb
arch/arm/boot/dts/ti/omap/twl6032.dtsi:67.37-70.4: ERROR
(phandle_references):
/ocp/interconnect@48000000/segment@0/target-module@70000/i2c@0/twl@48/usb-comparator:
Reference to non-existent node or label "ldosb"

  also defined at arch/arm/boot/dts/ti/omap/twl6030.dtsi:83.37-86.4
  also defined at
  arch/arm/boot/dts/ti/omap/omap4-samsung-espresso-common.dtsi:616.21-618.3
  ERROR: Input tree has errors, aborting (use -f to force output)

I think you accidently submitted a wrong/outdated version. You had
removed the twl6030.dtsi include in pmOS after I pointed that out to
you in an issue there. Any further review is futile.

From:
https://gitlab.com/postmarketOS/pmaports/-/issues/2825:
>Mighty
>@MightyM17
>· 4 months ago
>Reporter
>Oh, there's a hanging include "twl6030.dtsi" thats causing us trouble,
>I'll port the usb regs and comparator to twl6032.dtsi and it should
>work fine.

that is a clear sign that somehow an old version seems to pop up.

Regards,
Andreas

  reply	other threads:[~2024-10-30 20:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-30 19:41 [PATCH v1 0/6] Initial support for Samsung Galaxy Tab 2 series Mithil Bavishi
2024-10-30 19:41 ` [PATCH v1 1/6] ARM: dts: twl6032: Add DTS file for TWL6032 PMIC Mithil Bavishi
2024-10-30 19:41 ` [PATCH v1 2/6] arm/dts: Add common device tree for Samsung Galaxy Tab 2 series Mithil Bavishi
2024-10-30 19:55   ` Andreas Kemnade
2024-10-30 19:41 ` [PATCH v1 3/6] dt-bindings: omap: Add Samaung Galaxy Tab 2 7.0 Mithil Bavishi
2024-10-30 19:41 ` [PATCH v1 4/6] arm/dts: Add initial support for " Mithil Bavishi
2024-10-30 20:37   ` Andreas Kemnade [this message]
2024-10-30 19:41 ` [PATCH v1 5/6] dt-bindings: omap: Add Samaung Galaxy Tab 2 10.1 Mithil Bavishi
2024-10-30 19:41 ` [PATCH v1 6/6] arm/dts: Add initial support for " Mithil Bavishi
  -- strict thread matches above, loose matches on Subject: below --
2024-10-31  8:09 [PATCH v1 4/6] arm/dts: Add initial support for Galaxy Tab 2 7.0 kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241030213713.45223f64@akair \
    --to=andreas@kemnade.info \
    --cc=aaro.koskinen@iki.fi \
    --cc=bavishimithil@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=khilman@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=rogerq@kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.