From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Phil Sutter <phil@nwl.cc>, Florian Westphal <fw@strlen.de>,
netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft] tests: monitor: fix up test case breakage
Date: Thu, 31 Oct 2024 00:29:14 +0100 [thread overview]
Message-ID: <20241030232914.GA31019@breakpoint.cc> (raw)
In-Reply-To: <ZyKxY6WZJrKioMDt@calendula>
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> I can also revert the patch if you don't like, but it is saving _a
> lot_ of memory from userspace for the silly one element per line case.
I think your patch is fine, the question is if we should ditch the
test case instead of reordering the expected output.
next prev parent reply other threads:[~2024-10-30 23:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-29 20:12 [PATCH nft] tests: monitor: fix up test case breakage Florian Westphal
2024-10-29 21:27 ` Pablo Neira Ayuso
2024-10-30 18:19 ` Phil Sutter
2024-10-30 18:54 ` Florian Westphal
2024-10-30 21:38 ` Pablo Neira Ayuso
2024-10-30 22:21 ` Pablo Neira Ayuso
2024-10-30 23:29 ` Florian Westphal [this message]
2024-10-31 13:07 ` Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241030232914.GA31019@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.