All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft] tests: monitor: fix up test case breakage
Date: Tue, 29 Oct 2024 22:27:18 +0100	[thread overview]
Message-ID: <ZyFTNpldqHmUdQh2@calendula> (raw)
In-Reply-To: <20241029201221.17865-1-fw@strlen.de>

On Tue, Oct 29, 2024 at 09:12:19PM +0100, Florian Westphal wrote:
> Monitor test fails:
> 
> echo: running tests from file set-simple.t
> echo output differs!
> --- /tmp/tmp.FGtiyL99bB/tmp.2QxLSjzQqk  2024-10-29 20:54:41.308293201 +0100
> +++ /tmp/tmp.FGtiyL99bB/tmp.A5rp0Z0dBJ  2024-10-29 20:54:41.317293201 +0100
> @@ -1,2 +1,3 @@
> -add element ip t portrange { 1024-65535 }
>  add element ip t portrange { 100-200 }
> +add element ip t portrange { 1024-65535 }
> +# new generation 510 by process 129009 (nft)
> 
> I also noticed -j mode did not work correctly, add missing json annotations
> in set-concat-interval.t while at it.

Thanks for fixing up tests.

  reply	other threads:[~2024-10-29 21:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-29 20:12 [PATCH nft] tests: monitor: fix up test case breakage Florian Westphal
2024-10-29 21:27 ` Pablo Neira Ayuso [this message]
2024-10-30 18:19 ` Phil Sutter
2024-10-30 18:54   ` Florian Westphal
2024-10-30 21:38   ` Pablo Neira Ayuso
2024-10-30 22:21     ` Pablo Neira Ayuso
2024-10-30 23:29       ` Florian Westphal
2024-10-31 13:07         ` Phil Sutter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZyFTNpldqHmUdQh2@calendula \
    --to=pablo@netfilter.org \
    --cc=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.