[Buildroot] [PATCH 1/1] package/libv4l: fix TARGET_NLS_LIBS

[Buildroot] [PATCH 1/1] package/libv4l: fix TARGET_NLS_LIBS

[Bernd Kuhls]

When switching the build system to meson in buildroot commit
41ce1cc690b0837a1822079317bf317ddaeac17b the way TARGET_NLS_LIBS was
passed to the build system was not updated causing build errors.

Fixes:
http://autobuild.buildroot.net/results/96b/96b08078ea412b97a4719321ad0fdad4003e42c5/

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
Please note that this build error first occured on Sep 12, long before
meson was bumped to 1.6.0:
http://autobuild.buildroot.net/results/6cf/6cf2bddef3f31eef21465ee98e13440dca65ca0f/

 package/libv4l/libv4l.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/package/libv4l/libv4l.mk b/package/libv4l/libv4l.mk
index 072d7efcf3..e8bcc2bdfc 100644
--- a/package/libv4l/libv4l.mk
+++ b/package/libv4l/libv4l.mk
@@ -10,6 +10,7 @@ LIBV4L_SITE = https://linuxtv.org/downloads/v4l-utils
 LIBV4L_INSTALL_STAGING = YES
 LIBV4L_DEPENDENCIES = host-pkgconf
 LIBV4L_CONF_OPTS = -Ddoxygen-doc=disabled -Dqvidcap=disabled -Dv4l2-tracer=disabled
+LIBV4L_LDFLAGS = $(TARGET_LDFLAGS)
 
 # v4l-utils components have different licences, see v4l-utils.spec for details
 LIBV4L_LICENSE = GPL-2.0+ (utilities), LGPL-2.1+ (libraries)
@@ -21,7 +22,7 @@ endif
 
 ifeq ($(BR2_PACKAGE_ARGP_STANDALONE),y)
 LIBV4L_DEPENDENCIES += argp-standalone $(TARGET_NLS_DEPENDENCIES)
-LIBV4L_CONF_ENV += LIBS=$(TARGET_NLS_LIBS)
+LIBV4L_LDFLAGS += $(TARGET_NLS_LIBS)
 endif
 
 LIBV4L_DEPENDENCIES += $(if $(BR2_PACKAGE_LIBICONV),libiconv)
-- 
2.39.5

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/libv4l: fix TARGET_NLS_LIBS

[Thomas Petazzoni via buildroot]

On Wed, 30 Oct 2024 23:25:33 +0100
Bernd Kuhls <bernd@kuhls.net> wrote:

> When switching the build system to meson in buildroot commit
> 41ce1cc690b0837a1822079317bf317ddaeac17b the way TARGET_NLS_LIBS was
> passed to the build system was not updated causing build errors.
> 
> Fixes:
> http://autobuild.buildroot.net/results/96b/96b08078ea412b97a4719321ad0fdad4003e42c5/
> 
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> ---
> Please note that this build error first occured on Sep 12, long before
> meson was bumped to 1.6.0:
> http://autobuild.buildroot.net/results/6cf/6cf2bddef3f31eef21465ee98e13440dca65ca0f/

Applied to master. Thanks a _lot_ for the research of since when the
problem started occurring: much appreciated!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot