* [PATCH V3 0/3] Indiedroid Nova Audio/HDMI Updates
@ 2024-10-31 15:05 ` Chris Morgan
0 siblings, 0 replies; 10+ messages in thread
From: Chris Morgan @ 2024-10-31 15:05 UTC (permalink / raw)
To: linux-rockchip
Cc: devicetree, honyuenkwun, heiko, conor+dt, krzk+dt, robh,
Chris Morgan
From: Chris Morgan <macromorgan@hotmail.com>
This series is for a handful of fixes and updates for the Indiedroid
Nova. This series corrects the device name of the audio card to stop
a kernel log error, and adds support for both the HDMI and GPU (now
that HDMI support has been queued for linux-next).
Changes since v1:
- Corrected HDMI port from mini HDMI (c) to micro HDMI (d).
- Explained why I enable hdmim0_rx_hpdin in contrast to the other
rk3588 boards.
- Split HDMI0 and GPU patches into different patches.
Changes since v2:
- Removed hdmim0_rx_hpdin as it is not necessary.
Chris Morgan (3):
arm64: dts: rockchip: correct analog audio name on Indiedroid Nova
arm64: dts: rockchip: Enable GPU on Indiedroid Nova
arm64: dts: rockchip: Enable HDMI0 on Indiedroid Nova
.../dts/rockchip/rk3588s-indiedroid-nova.dts | 57 ++++++++++++++++++-
1 file changed, 56 insertions(+), 1 deletion(-)
--
2.43.0
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH V3 1/3] arm64: dts: rockchip: correct analog audio name on Indiedroid Nova
2024-10-31 15:05 ` Chris Morgan
@ 2024-10-31 15:05 ` Chris Morgan
-1 siblings, 0 replies; 10+ messages in thread
From: Chris Morgan @ 2024-10-31 15:05 UTC (permalink / raw)
To: linux-rockchip
Cc: devicetree, honyuenkwun, heiko, conor+dt, krzk+dt, robh,
Chris Morgan
From: Chris Morgan <macromorgan@hotmail.com>
Correct the audio name for the Indiedroid Nova from
rockchip,es8388-codec to rockchip,es8388. This name change corrects a
kernel log error of "ASoC: driver name too long 'rockchip,es8388-codec'
-> 'rockchip_es8388'".
Fixes: 3900160e164b ("arm64: dts: rockchip: Add Indiedroid Nova board")
Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
---
arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts b/arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts
index d8c50fdcca3b..a4b930f6987f 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts
@@ -62,7 +62,7 @@ sdio_pwrseq: sdio-pwrseq {
sound {
compatible = "audio-graph-card";
- label = "rockchip,es8388-codec";
+ label = "rockchip,es8388";
widgets = "Microphone", "Mic Jack",
"Headphone", "Headphones";
routing = "LINPUT2", "Mic Jack",
--
2.43.0
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH V3 1/3] arm64: dts: rockchip: correct analog audio name on Indiedroid Nova
@ 2024-10-31 15:05 ` Chris Morgan
0 siblings, 0 replies; 10+ messages in thread
From: Chris Morgan @ 2024-10-31 15:05 UTC (permalink / raw)
To: linux-rockchip
Cc: devicetree, honyuenkwun, heiko, conor+dt, krzk+dt, robh,
Chris Morgan
From: Chris Morgan <macromorgan@hotmail.com>
Correct the audio name for the Indiedroid Nova from
rockchip,es8388-codec to rockchip,es8388. This name change corrects a
kernel log error of "ASoC: driver name too long 'rockchip,es8388-codec'
-> 'rockchip_es8388'".
Fixes: 3900160e164b ("arm64: dts: rockchip: Add Indiedroid Nova board")
Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
---
arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts b/arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts
index d8c50fdcca3b..a4b930f6987f 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts
@@ -62,7 +62,7 @@ sdio_pwrseq: sdio-pwrseq {
sound {
compatible = "audio-graph-card";
- label = "rockchip,es8388-codec";
+ label = "rockchip,es8388";
widgets = "Microphone", "Mic Jack",
"Headphone", "Headphones";
routing = "LINPUT2", "Mic Jack",
--
2.43.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH V3 2/3] arm64: dts: rockchip: Enable GPU on Indiedroid Nova
2024-10-31 15:05 ` Chris Morgan
@ 2024-10-31 15:05 ` Chris Morgan
-1 siblings, 0 replies; 10+ messages in thread
From: Chris Morgan @ 2024-10-31 15:05 UTC (permalink / raw)
To: linux-rockchip
Cc: devicetree, honyuenkwun, heiko, conor+dt, krzk+dt, robh,
Chris Morgan
From: Chris Morgan <macromorgan@hotmail.com>
Enable the GPU for the Indiedroid Nova.
Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
---
arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts b/arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts
index a4b930f6987f..065d44735001 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts
@@ -242,6 +242,11 @@ &gpio4 {
"", "", "", "";
};
+&gpu {
+ mali-supply = <&vdd_gpu_s0>;
+ status = "okay";
+};
+
&i2c0 {
pinctrl-0 = <&i2c0m2_xfer>;
pinctrl-names = "default";
--
2.43.0
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH V3 2/3] arm64: dts: rockchip: Enable GPU on Indiedroid Nova
@ 2024-10-31 15:05 ` Chris Morgan
0 siblings, 0 replies; 10+ messages in thread
From: Chris Morgan @ 2024-10-31 15:05 UTC (permalink / raw)
To: linux-rockchip
Cc: devicetree, honyuenkwun, heiko, conor+dt, krzk+dt, robh,
Chris Morgan
From: Chris Morgan <macromorgan@hotmail.com>
Enable the GPU for the Indiedroid Nova.
Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
---
arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts b/arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts
index a4b930f6987f..065d44735001 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts
@@ -242,6 +242,11 @@ &gpio4 {
"", "", "", "";
};
+&gpu {
+ mali-supply = <&vdd_gpu_s0>;
+ status = "okay";
+};
+
&i2c0 {
pinctrl-0 = <&i2c0m2_xfer>;
pinctrl-names = "default";
--
2.43.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH V3 3/3] arm64: dts: rockchip: Enable HDMI0 on Indiedroid Nova
2024-10-31 15:05 ` Chris Morgan
@ 2024-10-31 15:05 ` Chris Morgan
-1 siblings, 0 replies; 10+ messages in thread
From: Chris Morgan @ 2024-10-31 15:05 UTC (permalink / raw)
To: linux-rockchip
Cc: devicetree, honyuenkwun, heiko, conor+dt, krzk+dt, robh,
Chris Morgan
From: Chris Morgan <macromorgan@hotmail.com>
Enable the HDMI0 port for the Indiedroid Nova.
Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
---
.../dts/rockchip/rk3588s-indiedroid-nova.dts | 50 +++++++++++++++++++
1 file changed, 50 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts b/arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts
index 065d44735001..3a41b9c00010 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts
@@ -5,6 +5,7 @@
#include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/input/linux-event-codes.h>
#include <dt-bindings/pinctrl/rockchip.h>
+#include <dt-bindings/soc/rockchip,vop2.h>
#include <dt-bindings/usb/pd.h>
#include "rk3588s.dtsi"
@@ -50,6 +51,17 @@ chosen {
stdout-path = "serial2:1500000n8";
};
+ hdmi0-con {
+ compatible = "hdmi-connector";
+ type = "d";
+
+ port {
+ hdmi0_con_in: endpoint {
+ remote-endpoint = <&hdmi0_out_con>;
+ };
+ };
+ };
+
sdio_pwrseq: sdio-pwrseq {
compatible = "mmc-pwrseq-simple";
clock-names = "ext_clock";
@@ -247,6 +259,29 @@ &gpu {
status = "okay";
};
+&hdmi0 {
+ pinctrl-0 = <&hdmim0_tx0_scl>, <&hdmim0_tx0_sda>,
+ <&hdmim0_tx0_hpd>, <&hdmim0_tx0_cec>;
+ pinctrl-names = "default";
+ status = "okay";
+};
+
+&hdmi0_in {
+ hdmi0_in_vp0: endpoint {
+ remote-endpoint = <&vp0_out_hdmi0>;
+ };
+};
+
+&hdmi0_out {
+ hdmi0_out_con: endpoint {
+ remote-endpoint = <&hdmi0_con_in>;
+ };
+};
+
+&hdptxphy_hdmi0 {
+ status = "okay";
+};
+
&i2c0 {
pinctrl-0 = <&i2c0m2_xfer>;
pinctrl-names = "default";
@@ -924,3 +959,18 @@ usbdp_phy0_dp_altmode_mux: endpoint@1 {
};
};
};
+
+&vop {
+ status = "okay";
+};
+
+&vop_mmu {
+ status = "okay";
+};
+
+&vp0 {
+ vp0_out_hdmi0: endpoint@ROCKCHIP_VOP2_EP_HDMI0 {
+ reg = <ROCKCHIP_VOP2_EP_HDMI0>;
+ remote-endpoint = <&hdmi0_in_vp0>;
+ };
+};
--
2.43.0
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH V3 3/3] arm64: dts: rockchip: Enable HDMI0 on Indiedroid Nova
@ 2024-10-31 15:05 ` Chris Morgan
0 siblings, 0 replies; 10+ messages in thread
From: Chris Morgan @ 2024-10-31 15:05 UTC (permalink / raw)
To: linux-rockchip
Cc: devicetree, honyuenkwun, heiko, conor+dt, krzk+dt, robh,
Chris Morgan
From: Chris Morgan <macromorgan@hotmail.com>
Enable the HDMI0 port for the Indiedroid Nova.
Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
---
.../dts/rockchip/rk3588s-indiedroid-nova.dts | 50 +++++++++++++++++++
1 file changed, 50 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts b/arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts
index 065d44735001..3a41b9c00010 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts
@@ -5,6 +5,7 @@
#include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/input/linux-event-codes.h>
#include <dt-bindings/pinctrl/rockchip.h>
+#include <dt-bindings/soc/rockchip,vop2.h>
#include <dt-bindings/usb/pd.h>
#include "rk3588s.dtsi"
@@ -50,6 +51,17 @@ chosen {
stdout-path = "serial2:1500000n8";
};
+ hdmi0-con {
+ compatible = "hdmi-connector";
+ type = "d";
+
+ port {
+ hdmi0_con_in: endpoint {
+ remote-endpoint = <&hdmi0_out_con>;
+ };
+ };
+ };
+
sdio_pwrseq: sdio-pwrseq {
compatible = "mmc-pwrseq-simple";
clock-names = "ext_clock";
@@ -247,6 +259,29 @@ &gpu {
status = "okay";
};
+&hdmi0 {
+ pinctrl-0 = <&hdmim0_tx0_scl>, <&hdmim0_tx0_sda>,
+ <&hdmim0_tx0_hpd>, <&hdmim0_tx0_cec>;
+ pinctrl-names = "default";
+ status = "okay";
+};
+
+&hdmi0_in {
+ hdmi0_in_vp0: endpoint {
+ remote-endpoint = <&vp0_out_hdmi0>;
+ };
+};
+
+&hdmi0_out {
+ hdmi0_out_con: endpoint {
+ remote-endpoint = <&hdmi0_con_in>;
+ };
+};
+
+&hdptxphy_hdmi0 {
+ status = "okay";
+};
+
&i2c0 {
pinctrl-0 = <&i2c0m2_xfer>;
pinctrl-names = "default";
@@ -924,3 +959,18 @@ usbdp_phy0_dp_altmode_mux: endpoint@1 {
};
};
};
+
+&vop {
+ status = "okay";
+};
+
+&vop_mmu {
+ status = "okay";
+};
+
+&vp0 {
+ vp0_out_hdmi0: endpoint@ROCKCHIP_VOP2_EP_HDMI0 {
+ reg = <ROCKCHIP_VOP2_EP_HDMI0>;
+ remote-endpoint = <&hdmi0_in_vp0>;
+ };
+};
--
2.43.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH V3 0/3] Indiedroid Nova Audio/HDMI Updates
2024-10-31 15:05 ` Chris Morgan
@ 2024-11-09 18:27 ` Heiko Stuebner
-1 siblings, 0 replies; 10+ messages in thread
From: Heiko Stuebner @ 2024-11-09 18:27 UTC (permalink / raw)
To: linux-rockchip, Chris Morgan
Cc: Heiko Stuebner, Chris Morgan, conor+dt, devicetree, honyuenkwun,
krzk+dt, robh
On Thu, 31 Oct 2024 10:05:02 -0500, Chris Morgan wrote:
> From: Chris Morgan <macromorgan@hotmail.com>
>
> This series is for a handful of fixes and updates for the Indiedroid
> Nova. This series corrects the device name of the audio card to stop
> a kernel log error, and adds support for both the HDMI and GPU (now
> that HDMI support has been queued for linux-next).
>
> [...]
Applied, thanks!
[1/3] arm64: dts: rockchip: correct analog audio name on Indiedroid Nova
commit: 42d85557527266804579bc5d20c101d93f6be3c6
[2/3] arm64: dts: rockchip: Enable GPU on Indiedroid Nova
commit: 3143ef4f01757b7069d3d7d7b02e4dcb5790d285
[3/3] arm64: dts: rockchip: Enable HDMI0 on Indiedroid Nova
commit: 2f4a0c2b29c9d82f9c322a641a59fddc41af1289
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH V3 0/3] Indiedroid Nova Audio/HDMI Updates
@ 2024-11-09 18:27 ` Heiko Stuebner
0 siblings, 0 replies; 10+ messages in thread
From: Heiko Stuebner @ 2024-11-09 18:27 UTC (permalink / raw)
To: linux-rockchip, Chris Morgan
Cc: Heiko Stuebner, Chris Morgan, conor+dt, devicetree, honyuenkwun,
krzk+dt, robh
On Thu, 31 Oct 2024 10:05:02 -0500, Chris Morgan wrote:
> From: Chris Morgan <macromorgan@hotmail.com>
>
> This series is for a handful of fixes and updates for the Indiedroid
> Nova. This series corrects the device name of the audio card to stop
> a kernel log error, and adds support for both the HDMI and GPU (now
> that HDMI support has been queued for linux-next).
>
> [...]
Applied, thanks!
[1/3] arm64: dts: rockchip: correct analog audio name on Indiedroid Nova
commit: 42d85557527266804579bc5d20c101d93f6be3c6
[2/3] arm64: dts: rockchip: Enable GPU on Indiedroid Nova
commit: 3143ef4f01757b7069d3d7d7b02e4dcb5790d285
[3/3] arm64: dts: rockchip: Enable HDMI0 on Indiedroid Nova
commit: 2f4a0c2b29c9d82f9c322a641a59fddc41af1289
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 10+ messages in thread