* [android-common:android11-kiwi-5.4 387/387] drivers/md/dm-bow.c:666 dm_bow_ctr() warn: missing error code 'ret'
@ 2024-11-01 12:58 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2024-11-01 12:58 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp, Dan Carpenter
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
TO: cros-kernel-buildreports@googlegroups.com
tree: https://android.googlesource.com/kernel/common android11-kiwi-5.4
head: 6a622c20579dfeb7db056fc9b624d4abb73c8081
commit: 0ce3eb37e9eab307def1bad31c028d86ae7b2ea1 [387/387] ANDROID: dm-bow: Add dm-bow feature
:::::: branch date: 4 days ago
:::::: commit date: 6 years ago
config: x86_64-randconfig-161-20241029 (https://download.01.org/0day-ci/archive/20241101/202411012054.D1zpW7a2-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202411012054.D1zpW7a2-lkp@intel.com/
smatch warnings:
drivers/md/dm-bow.c:666 dm_bow_ctr() warn: missing error code 'ret'
vim +/ret +666 drivers/md/dm-bow.c
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 621
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 622 static int dm_bow_ctr(struct dm_target *ti, unsigned int argc, char **argv)
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 623 {
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 624 struct bow_context *bc;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 625 struct bow_range *br;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 626 int ret;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 627 struct mapped_device *md = dm_table_get_md(ti->table);
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 628
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 629 if (argc != 1) {
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 630 ti->error = "Invalid argument count";
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 631 return -EINVAL;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 632 }
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 633
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 634 bc = kzalloc(sizeof(*bc), GFP_KERNEL);
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 635 if (!bc) {
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 636 ti->error = "Cannot allocate bow context";
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 637 return -ENOMEM;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 638 }
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 639
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 640 ti->num_flush_bios = 1;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 641 ti->num_discard_bios = 1;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 642 ti->num_write_same_bios = 1;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 643 ti->private = bc;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 644
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 645 ret = dm_get_device(ti, argv[0], dm_table_get_mode(ti->table),
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 646 &bc->dev);
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 647 if (ret) {
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 648 ti->error = "Device lookup failed";
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 649 goto bad;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 650 }
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 651
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 652 if (bc->dev->bdev->bd_queue->limits.max_discard_sectors == 0) {
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 653 bc->dev->bdev->bd_queue->limits.discard_granularity = 1 << 12;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 654 bc->dev->bdev->bd_queue->limits.max_hw_discard_sectors = 1 << 15;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 655 bc->dev->bdev->bd_queue->limits.max_discard_sectors = 1 << 15;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 656 bc->forward_trims = false;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 657 } else {
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 658 bc->forward_trims = true;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 659 }
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 660
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 661 bc->block_size = bc->dev->bdev->bd_queue->limits.logical_block_size;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 662 bc->block_shift = ilog2(bc->block_size);
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 663 bc->log_sector = kzalloc(bc->block_size, GFP_KERNEL);
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 664 if (!bc->log_sector) {
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 665 ti->error = "Cannot allocate log sector";
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 @666 goto bad;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 667 }
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 668
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 669 init_completion(&bc->kobj_holder.completion);
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 670 ret = kobject_init_and_add(&bc->kobj_holder.kobj, &bow_ktype,
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 671 &disk_to_dev(dm_disk(md))->kobj, "%s",
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 672 "bow");
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 673 if (ret) {
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 674 ti->error = "Cannot create sysfs node";
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 675 goto bad;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 676 }
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 677
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 678 mutex_init(&bc->ranges_lock);
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 679 bc->ranges = RB_ROOT;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 680 bc->bufio = dm_bufio_client_create(bc->dev->bdev, bc->block_size, 1, 0,
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 681 NULL, NULL);
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 682 if (IS_ERR(bc->bufio)) {
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 683 ti->error = "Cannot initialize dm-bufio";
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 684 ret = PTR_ERR(bc->bufio);
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 685 bc->bufio = NULL;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 686 goto bad;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 687 }
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 688
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 689 bc->workqueue = alloc_workqueue("dm-bow",
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 690 WQ_CPU_INTENSIVE | WQ_MEM_RECLAIM
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 691 | WQ_UNBOUND, num_online_cpus());
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 692 if (!bc->workqueue) {
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 693 ti->error = "Cannot allocate workqueue";
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 694 ret = -ENOMEM;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 695 goto bad;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 696 }
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 697
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 698 INIT_LIST_HEAD(&bc->trimmed_list);
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 699
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 700 br = kzalloc(sizeof(*br), GFP_KERNEL);
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 701 if (!br) {
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 702 ti->error = "Cannot allocate ranges";
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 703 ret = -ENOMEM;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 704 goto bad;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 705 }
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 706
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 707 br->sector = ti->len;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 708 br->type = TOP;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 709 rb_link_node(&br->node, NULL, &bc->ranges.rb_node);
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 710 rb_insert_color(&br->node, &bc->ranges);
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 711
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 712 br = kzalloc(sizeof(*br), GFP_KERNEL);
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 713 if (!br) {
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 714 ti->error = "Cannot allocate ranges";
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 715 ret = -ENOMEM;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 716 goto bad;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 717 }
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 718
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 719 br->sector = 0;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 720 br->type = UNCHANGED;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 721 rb_link_node(&br->node, bc->ranges.rb_node,
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 722 &bc->ranges.rb_node->rb_left);
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 723 rb_insert_color(&br->node, &bc->ranges);
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 724
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 725 ti->discards_supported = true;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 726
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 727 return 0;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 728
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 729 bad:
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 730 dm_bow_dtr(ti);
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 731 return ret;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 732 }
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 733
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread* [android-common:android11-kiwi-5.4 387/387] drivers/md/dm-bow.c:666 dm_bow_ctr() warn: missing error code 'ret'
@ 2024-11-01 13:23 Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2024-11-01 13:23 UTC (permalink / raw)
To: oe-kbuild, cros-kernel-buildreports; +Cc: lkp, oe-kbuild-all
tree: https://android.googlesource.com/kernel/common android11-kiwi-5.4
head: 6a622c20579dfeb7db056fc9b624d4abb73c8081
commit: 0ce3eb37e9eab307def1bad31c028d86ae7b2ea1 [387/387] ANDROID: dm-bow: Add dm-bow feature
config: x86_64-randconfig-161-20241029 (https://download.01.org/0day-ci/archive/20241101/202411012054.D1zpW7a2-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202411012054.D1zpW7a2-lkp@intel.com/
smatch warnings:
drivers/md/dm-bow.c:666 dm_bow_ctr() warn: missing error code 'ret'
vim +/ret +666 drivers/md/dm-bow.c
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 622 static int dm_bow_ctr(struct dm_target *ti, unsigned int argc, char **argv)
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 623 {
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 624 struct bow_context *bc;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 625 struct bow_range *br;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 626 int ret;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 627 struct mapped_device *md = dm_table_get_md(ti->table);
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 628
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 629 if (argc != 1) {
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 630 ti->error = "Invalid argument count";
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 631 return -EINVAL;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 632 }
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 633
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 634 bc = kzalloc(sizeof(*bc), GFP_KERNEL);
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 635 if (!bc) {
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 636 ti->error = "Cannot allocate bow context";
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 637 return -ENOMEM;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 638 }
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 639
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 640 ti->num_flush_bios = 1;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 641 ti->num_discard_bios = 1;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 642 ti->num_write_same_bios = 1;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 643 ti->private = bc;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 644
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 645 ret = dm_get_device(ti, argv[0], dm_table_get_mode(ti->table),
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 646 &bc->dev);
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 647 if (ret) {
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 648 ti->error = "Device lookup failed";
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 649 goto bad;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 650 }
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 651
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 652 if (bc->dev->bdev->bd_queue->limits.max_discard_sectors == 0) {
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 653 bc->dev->bdev->bd_queue->limits.discard_granularity = 1 << 12;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 654 bc->dev->bdev->bd_queue->limits.max_hw_discard_sectors = 1 << 15;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 655 bc->dev->bdev->bd_queue->limits.max_discard_sectors = 1 << 15;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 656 bc->forward_trims = false;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 657 } else {
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 658 bc->forward_trims = true;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 659 }
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 660
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 661 bc->block_size = bc->dev->bdev->bd_queue->limits.logical_block_size;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 662 bc->block_shift = ilog2(bc->block_size);
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 663 bc->log_sector = kzalloc(bc->block_size, GFP_KERNEL);
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 664 if (!bc->log_sector) {
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 665 ti->error = "Cannot allocate log sector";
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 @666 goto bad;
Needs a "ret = -ENOMEM;"
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 667 }
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 668
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 669 init_completion(&bc->kobj_holder.completion);
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 670 ret = kobject_init_and_add(&bc->kobj_holder.kobj, &bow_ktype,
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 671 &disk_to_dev(dm_disk(md))->kobj, "%s",
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 672 "bow");
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 673 if (ret) {
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 674 ti->error = "Cannot create sysfs node";
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 675 goto bad;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 676 }
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 677
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 678 mutex_init(&bc->ranges_lock);
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 679 bc->ranges = RB_ROOT;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 680 bc->bufio = dm_bufio_client_create(bc->dev->bdev, bc->block_size, 1, 0,
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 681 NULL, NULL);
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 682 if (IS_ERR(bc->bufio)) {
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 683 ti->error = "Cannot initialize dm-bufio";
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 684 ret = PTR_ERR(bc->bufio);
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 685 bc->bufio = NULL;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 686 goto bad;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 687 }
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 688
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 689 bc->workqueue = alloc_workqueue("dm-bow",
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 690 WQ_CPU_INTENSIVE | WQ_MEM_RECLAIM
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 691 | WQ_UNBOUND, num_online_cpus());
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 692 if (!bc->workqueue) {
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 693 ti->error = "Cannot allocate workqueue";
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 694 ret = -ENOMEM;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 695 goto bad;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 696 }
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 697
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 698 INIT_LIST_HEAD(&bc->trimmed_list);
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 699
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 700 br = kzalloc(sizeof(*br), GFP_KERNEL);
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 701 if (!br) {
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 702 ti->error = "Cannot allocate ranges";
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 703 ret = -ENOMEM;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 704 goto bad;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 705 }
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 706
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 707 br->sector = ti->len;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 708 br->type = TOP;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 709 rb_link_node(&br->node, NULL, &bc->ranges.rb_node);
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 710 rb_insert_color(&br->node, &bc->ranges);
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 711
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 712 br = kzalloc(sizeof(*br), GFP_KERNEL);
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 713 if (!br) {
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 714 ti->error = "Cannot allocate ranges";
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 715 ret = -ENOMEM;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 716 goto bad;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 717 }
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 718
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 719 br->sector = 0;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 720 br->type = UNCHANGED;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 721 rb_link_node(&br->node, bc->ranges.rb_node,
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 722 &bc->ranges.rb_node->rb_left);
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 723 rb_insert_color(&br->node, &bc->ranges);
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 724
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 725 ti->discards_supported = true;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 726
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 727 return 0;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 728
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 729 bad:
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 730 dm_bow_dtr(ti);
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 731 return ret;
0ce3eb37e9eab3 Paul Lawrence 2018-10-23 732 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-11-01 13:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-01 12:58 [android-common:android11-kiwi-5.4 387/387] drivers/md/dm-bow.c:666 dm_bow_ctr() warn: missing error code 'ret' kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2024-11-01 13:23 Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.