From: "Krzysztof Wilczyński" <kw@linux.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: Niklas Cassel <cassel@kernel.org>,
Jingoo Han <jingoohan1@gmail.com>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Rob Herring <robh@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Damien Le Moal <dlemoal@kernel.org>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH 1/2] PCI: dwc: ep: Fix dw_pcie_ep_align_addr()
Date: Sat, 2 Nov 2024 20:37:31 +0900 [thread overview]
Message-ID: <20241102113731.GB2260768@rocinante> (raw)
In-Reply-To: <20241101071236.gddrtufnalhjf42k@thinkpad>
Hello,
> > ep->page_size is defined by the EPC drivers.
> > Some drivers e.g. pci-imx6.c defines this to 4K for imx95.
> >
> > dw_pcie_ep_init() will call pci_epc_mem_init() with ep->page_size.
> > pci_epc_mem_init() will call pci_epc_multi_mem_init().
> >
> > pci_epc_multi_mem_init() will initialize mem->window.page_size.
> > If the provided page_size (ep->page_size) is smaller than PAGE_SIZE,
> > it will initialize mem->window.page_size to PAGE_SIZE rather than
> > ep->page_size.
> >
> > Thus, mem->window.page_size can be larger than ep->page_size, e.g.
> > for a platform built with PAGE_SIZE == 64K, while using a EPC driver
> > that defines ep->page_size to 4k.
> >
> > Therefore, modify dw_pcie_ep_align_addr() to use
> > epc->mem->window.page_size rather than ep->page_size.
> >
> > [...]
>
> Fixes: a1cd1d901a5c ("PCI: dwc: endpoint: Implement the pci_epc_ops::align_addr() operation")
I squashed this patch into the one this aimed to fix.
Krzysztof
next prev parent reply other threads:[~2024-11-02 11:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-17 13:20 [PATCH 0/2] PCI: dwc: ep: Minor alignment cleanups Niklas Cassel
2024-10-17 13:20 ` [PATCH 1/2] PCI: dwc: ep: Fix dw_pcie_ep_align_addr() Niklas Cassel
2024-10-17 15:33 ` Frank Li
2024-11-01 7:12 ` Manivannan Sadhasivam
2024-11-02 11:37 ` Krzysztof Wilczyński [this message]
2024-10-17 13:20 ` [PATCH 2/2] PCI: dwc: ep: Use align addr function for dw_pcie_ep_raise_{msi,msix}_irq() Niklas Cassel
2024-10-17 15:36 ` Frank Li
2024-10-17 18:54 ` Niklas Cassel
2024-10-17 19:36 ` Frank Li
2024-10-31 20:28 ` Bjorn Helgaas
2024-10-31 22:36 ` Damien Le Moal
2024-11-01 18:25 ` Niklas Cassel
2024-11-01 7:16 ` Manivannan Sadhasivam
2024-11-02 11:41 ` Krzysztof Wilczyński
2024-10-20 0:59 ` [PATCH 0/2] PCI: dwc: ep: Minor alignment cleanups Damien Le Moal
2024-10-29 10:25 ` Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241102113731.GB2260768@rocinante \
--to=kw@linux.com \
--cc=bhelgaas@google.com \
--cc=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=jingoohan1@gmail.com \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.