From: Jakub Kicinski <kuba@kernel.org>
To: Caleb Sander Mateos <csander@purestorage.com>
Cc: "Andrew Lunn" <andrew+netdev@lunn.ch>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Arthur Kiyanovski" <akiyano@amazon.com>,
"Brett Creeley" <brett.creeley@amd.com>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
"Christophe Leroy" <christophe.leroy@csgroup.eu>,
"Claudiu Manoil" <claudiu.manoil@nxp.com>,
"David Arinzon" <darinzon@amazon.com>,
"David S. Miller" <davem@davemloft.net>,
"Doug Berger" <opendmb@gmail.com>,
"Eric Dumazet" <edumazet@google.com>,
"Eugenio Pérez" <eperezma@redhat.com>,
"Felix Fietkau" <nbd@nbd.name>,
"Florian Fainelli" <florian.fainelli@broadcom.com>,
"Geetha sowjanya" <gakula@marvell.com>,
hariprasad <hkelam@marvell.com>,
"Jason Wang" <jasowang@redhat.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"Leon Romanovsky" <leon@kernel.org>,
"Lorenzo Bianconi" <lorenzo@kernel.org>,
"Louis Peens" <louis.peens@corigine.com>,
"Mark Lee" <Mark-MC.Lee@mediatek.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Michael Chan" <michael.chan@broadcom.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Noam Dagan" <ndagan@amazon.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Przemek Kitszel" <przemyslaw.kitszel@intel.com>,
"Roy Pledge" <Roy.Pledge@nxp.com>,
"Saeed Bishara" <saeedb@amazon.com>,
"Saeed Mahameed" <saeedm@nvidia.com>,
"Sean Wang" <sean.wang@mediatek.com>,
"Shannon Nelson" <shannon.nelson@amd.com>,
"Shay Agroskin" <shayagr@amazon.com>,
"Simon Horman" <horms@kernel.org>,
"Subbaraya Sundeep" <sbhatta@marvell.com>,
"Sunil Goutham" <sgoutham@marvell.com>,
"Tal Gilboa" <talgi@nvidia.com>,
"Tariq Toukan" <tariqt@nvidia.com>,
"Tony Nguyen" <anthony.l.nguyen@intel.com>,
"Vladimir Oltean" <vladimir.oltean@nxp.com>,
"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
intel-wired-lan@lists.osuosl.org,
linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org, linux-rdma@vger.kernel.org,
netdev@vger.kernel.org, oss-drivers@corigine.com,
virtualization@lists.linux.dev
Subject: Re: [Intel-wired-lan] [resend PATCH 2/2] dim: pass dim_sample to net_dim() by reference
Date: Sun, 3 Nov 2024 12:21:38 -0800 [thread overview]
Message-ID: <20241103122138.6d0d62f6@kernel.org> (raw)
In-Reply-To: <20241031002326.3426181-2-csander@purestorage.com>
On Wed, 30 Oct 2024 18:23:26 -0600 Caleb Sander Mateos wrote:
> In a heavy TCP workload, mlx5e_handle_rx_dim() consumes 3% of CPU time,
> 94% of which is attributed to the first push instruction to copy
> dim_sample on the stack for the call to net_dim():
Change itself looks fine, so we can apply, but this seems surprising.
Are you sure this is not just some measurement problem?
Do you see 3% higher PPS with this change applied?
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Caleb Sander Mateos <csander@purestorage.com>
Cc: "Andrew Lunn" <andrew+netdev@lunn.ch>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Arthur Kiyanovski" <akiyano@amazon.com>,
"Brett Creeley" <brett.creeley@amd.com>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
"Christophe Leroy" <christophe.leroy@csgroup.eu>,
"Claudiu Manoil" <claudiu.manoil@nxp.com>,
"David Arinzon" <darinzon@amazon.com>,
"David S. Miller" <davem@davemloft.net>,
"Doug Berger" <opendmb@gmail.com>,
"Eric Dumazet" <edumazet@google.com>,
"Eugenio Pérez" <eperezma@redhat.com>,
"Felix Fietkau" <nbd@nbd.name>,
"Florian Fainelli" <florian.fainelli@broadcom.com>,
"Geetha sowjanya" <gakula@marvell.com>,
hariprasad <hkelam@marvell.com>,
"Jason Wang" <jasowang@redhat.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"Leon Romanovsky" <leon@kernel.org>,
"Lorenzo Bianconi" <lorenzo@kernel.org>,
"Louis Peens" <louis.peens@corigine.com>,
"Mark Lee" <Mark-MC.Lee@mediatek.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Michael Chan" <michael.chan@broadcom.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Noam Dagan" <ndagan@amazon.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Przemek Kitszel" <przemyslaw.kitszel@intel.com>,
"Roy Pledge" <Roy.Pledge@nxp.com>,
"Saeed Bishara" <saeedb@amazon.com>,
"Saeed Mahameed" <saeedm@nvidia.com>,
"Sean Wang" <sean.wang@mediatek.com>,
"Shannon Nelson" <shannon.nelson@amd.com>,
"Shay Agroskin" <shayagr@amazon.com>,
"Simon Horman" <horms@kernel.org>,
"Subbaraya Sundeep" <sbhatta@marvell.com>,
"Sunil Goutham" <sgoutham@marvell.com>,
"Tal Gilboa" <talgi@nvidia.com>,
"Tariq Toukan" <tariqt@nvidia.com>,
"Tony Nguyen" <anthony.l.nguyen@intel.com>,
"Vladimir Oltean" <vladimir.oltean@nxp.com>,
"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
intel-wired-lan@lists.osuosl.org,
linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org, linux-rdma@vger.kernel.org,
netdev@vger.kernel.org, oss-drivers@corigine.com,
virtualization@lists.linux.dev
Subject: Re: [resend PATCH 2/2] dim: pass dim_sample to net_dim() by reference
Date: Sun, 3 Nov 2024 12:21:38 -0800 [thread overview]
Message-ID: <20241103122138.6d0d62f6@kernel.org> (raw)
In-Reply-To: <20241031002326.3426181-2-csander@purestorage.com>
On Wed, 30 Oct 2024 18:23:26 -0600 Caleb Sander Mateos wrote:
> In a heavy TCP workload, mlx5e_handle_rx_dim() consumes 3% of CPU time,
> 94% of which is attributed to the first push instruction to copy
> dim_sample on the stack for the call to net_dim():
Change itself looks fine, so we can apply, but this seems surprising.
Are you sure this is not just some measurement problem?
Do you see 3% higher PPS with this change applied?
next prev parent reply other threads:[~2024-11-03 20:21 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-31 0:23 [Intel-wired-lan] [resend PATCH 1/2] dim: make dim_calc_stats() inputs const pointers Caleb Sander Mateos
2024-10-31 0:23 ` Caleb Sander Mateos
2024-10-31 0:23 ` [Intel-wired-lan] [resend PATCH 2/2] dim: pass dim_sample to net_dim() by reference Caleb Sander Mateos
2024-10-31 0:23 ` Caleb Sander Mateos
2024-10-31 12:49 ` [Intel-wired-lan] " Louis Peens
2024-10-31 12:49 ` Louis Peens
2024-10-31 17:19 ` [Intel-wired-lan] " Caleb Sander
2024-10-31 17:19 ` Caleb Sander
2024-11-01 8:54 ` [Intel-wired-lan] " Louis Peens
2024-11-01 8:54 ` Louis Peens
2024-11-01 14:11 ` [Intel-wired-lan] " Vladimir Oltean
2024-11-01 14:11 ` Vladimir Oltean
2024-10-31 16:48 ` [Intel-wired-lan] " Vladimir Oltean
2024-10-31 16:48 ` Vladimir Oltean
2024-10-31 16:57 ` [Intel-wired-lan] " Nelson, Shannon
2024-10-31 16:57 ` Nelson, Shannon
2024-10-31 17:17 ` [Intel-wired-lan] " Florian Fainelli
2024-10-31 17:17 ` Florian Fainelli
2024-10-31 18:28 ` [Intel-wired-lan] " Kiyanovski, Arthur
2024-10-31 18:28 ` Kiyanovski, Arthur
2024-11-03 20:21 ` Jakub Kicinski [this message]
2024-11-03 20:21 ` Jakub Kicinski
2024-11-03 22:50 ` [Intel-wired-lan] " Caleb Sander
2024-11-03 22:50 ` Caleb Sander
2024-11-04 2:52 ` [Intel-wired-lan] " Xuan Zhuo
2024-11-04 2:52 ` Xuan Zhuo
2024-10-31 16:44 ` [Intel-wired-lan] [resend PATCH 1/2] dim: make dim_calc_stats() inputs const pointers Vladimir Oltean
2024-10-31 16:44 ` Vladimir Oltean
2024-10-31 17:15 ` [Intel-wired-lan] " Florian Fainelli
2024-10-31 17:15 ` Florian Fainelli
2024-10-31 18:22 ` [Intel-wired-lan] " Kiyanovski, Arthur
2024-10-31 18:22 ` Kiyanovski, Arthur
2024-11-04 2:45 ` [Intel-wired-lan] " Xuan Zhuo
2024-11-04 2:45 ` Xuan Zhuo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241103122138.6d0d62f6@kernel.org \
--to=kuba@kernel.org \
--cc=Mark-MC.Lee@mediatek.com \
--cc=Roy.Pledge@nxp.com \
--cc=akiyano@amazon.com \
--cc=andrew+netdev@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=anthony.l.nguyen@intel.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=brett.creeley@amd.com \
--cc=christophe.leroy@csgroup.eu \
--cc=claudiu.manoil@nxp.com \
--cc=corbet@lwn.net \
--cc=csander@purestorage.com \
--cc=darinzon@amazon.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eperezma@redhat.com \
--cc=florian.fainelli@broadcom.com \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jasowang@redhat.com \
--cc=leon@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lorenzo@kernel.org \
--cc=louis.peens@corigine.com \
--cc=matthias.bgg@gmail.com \
--cc=michael.chan@broadcom.com \
--cc=mst@redhat.com \
--cc=nbd@nbd.name \
--cc=ndagan@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
--cc=oss-drivers@corigine.com \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=saeedb@amazon.com \
--cc=saeedm@nvidia.com \
--cc=sbhatta@marvell.com \
--cc=sean.wang@mediatek.com \
--cc=sgoutham@marvell.com \
--cc=shannon.nelson@amd.com \
--cc=shayagr@amazon.com \
--cc=talgi@nvidia.com \
--cc=tariqt@nvidia.com \
--cc=virtualization@lists.linux.dev \
--cc=vladimir.oltean@nxp.com \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.