From: Eric Biggers <ebiggers@kernel.org>
To: WangYuli <wangyuli@uniontech.com>
Cc: ardb@kernel.org, linux-arch@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-crypto@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org,
linux-scsi@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
loongarch@lists.linux.dev, kernel@xen0n.name,
chenhuacai@kernel.org, xry111@xry111.site,
sparclinux@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH v2 06/18] loongarch/crc32: expose CRC32 functions through lib
Date: Sun, 3 Nov 2024 05:57:30 -0800 [thread overview]
Message-ID: <20241103135730.GA813@quark.localdomain> (raw)
In-Reply-To: <DA8BCDFFEACDA1C6+20241103133655.217375-1-wangyuli@uniontech.com>
On Sun, Nov 03, 2024 at 09:36:55PM +0800, WangYuli wrote:
> Even though the narrower CRC instructions doesn't require GRLEN=64, they still *aren't* part of LA32 (LoongArch reference manual v1.10, Volume 1, Table 2-1).
> Link: https://lore.kernel.org/all/0a7d0a9e-c56e-4ee2-a83b-00164a450abe@xen0n.name/
>
> Therefore, we could not directly add ARCH_HAS_CRC32 to config LOONGARCH.
>
There's still a runtime CPU feature check of cpu_has(CPU_FEATURE_CRC32).
See arch/loongarch/lib/crc32-loongarch.c. So it's the same as before.
ARCH_HAS_CRC32 just means that the file will be compiled.
If you're trying to say that you think this file should be built only when
CONFIG_64BIT=y, then that would be an existing bug since the existing file
arch/loongarch/crypto/crc32-loongarch.c was built for both 32-bit and 64-bit.
But if you think this is a bug, I can fix this too.
- Eric
WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: WangYuli <wangyuli@uniontech.com>
Cc: linux-arch@vger.kernel.org, linux-s390@vger.kernel.org,
x86@kernel.org, linux-scsi@vger.kernel.org,
linux-mips@vger.kernel.org, chenhuacai@kernel.org,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, kernel@xen0n.name,
linux-crypto@vger.kernel.org, loongarch@lists.linux.dev,
sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org,
linux-ext4@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
ardb@kernel.org, linux-arm-kernel@lists.infradead.org,
xry111@xry111.site
Subject: Re: [f2fs-dev] [PATCH v2 06/18] loongarch/crc32: expose CRC32 functions through lib
Date: Sun, 3 Nov 2024 05:57:30 -0800 [thread overview]
Message-ID: <20241103135730.GA813@quark.localdomain> (raw)
In-Reply-To: <DA8BCDFFEACDA1C6+20241103133655.217375-1-wangyuli@uniontech.com>
On Sun, Nov 03, 2024 at 09:36:55PM +0800, WangYuli wrote:
> Even though the narrower CRC instructions doesn't require GRLEN=64, they still *aren't* part of LA32 (LoongArch reference manual v1.10, Volume 1, Table 2-1).
> Link: https://lore.kernel.org/all/0a7d0a9e-c56e-4ee2-a83b-00164a450abe@xen0n.name/
>
> Therefore, we could not directly add ARCH_HAS_CRC32 to config LOONGARCH.
>
There's still a runtime CPU feature check of cpu_has(CPU_FEATURE_CRC32).
See arch/loongarch/lib/crc32-loongarch.c. So it's the same as before.
ARCH_HAS_CRC32 just means that the file will be compiled.
If you're trying to say that you think this file should be built only when
CONFIG_64BIT=y, then that would be an existing bug since the existing file
arch/loongarch/crypto/crc32-loongarch.c was built for both 32-bit and 64-bit.
But if you think this is a bug, I can fix this too.
- Eric
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers <ebiggers@kernel.org>
To: WangYuli <wangyuli@uniontech.com>
Cc: ardb@kernel.org, linux-arch@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-crypto@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org,
linux-scsi@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
loongarch@lists.linux.dev, kernel@xen0n.name,
chenhuacai@kernel.org, xry111@xry111.site,
sparclinux@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH v2 06/18] loongarch/crc32: expose CRC32 functions through lib
Date: Sun, 3 Nov 2024 05:57:30 -0800 [thread overview]
Message-ID: <20241103135730.GA813@quark.localdomain> (raw)
In-Reply-To: <DA8BCDFFEACDA1C6+20241103133655.217375-1-wangyuli@uniontech.com>
On Sun, Nov 03, 2024 at 09:36:55PM +0800, WangYuli wrote:
> Even though the narrower CRC instructions doesn't require GRLEN=64, they still *aren't* part of LA32 (LoongArch reference manual v1.10, Volume 1, Table 2-1).
> Link: https://lore.kernel.org/all/0a7d0a9e-c56e-4ee2-a83b-00164a450abe@xen0n.name/
>
> Therefore, we could not directly add ARCH_HAS_CRC32 to config LOONGARCH.
>
There's still a runtime CPU feature check of cpu_has(CPU_FEATURE_CRC32).
See arch/loongarch/lib/crc32-loongarch.c. So it's the same as before.
ARCH_HAS_CRC32 just means that the file will be compiled.
If you're trying to say that you think this file should be built only when
CONFIG_64BIT=y, then that would be an existing bug since the existing file
arch/loongarch/crypto/crc32-loongarch.c was built for both 32-bit and 64-bit.
But if you think this is a bug, I can fix this too.
- Eric
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2024-11-03 13:57 UTC|newest]
Thread overview: 122+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-25 19:14 [PATCH v2 00/18] Wire up CRC32 library functions to arch-optimized code Eric Biggers
2024-10-25 19:14 ` Eric Biggers
2024-10-25 19:14 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2024-10-25 19:14 ` [PATCH v2 01/18] lib/crc32: drop leading underscores from __crc32c_le_base Eric Biggers
2024-10-25 19:14 ` Eric Biggers
2024-10-25 19:14 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2024-10-25 19:14 ` [PATCH v2 02/18] lib/crc32: improve support for arch-specific overrides Eric Biggers
2024-10-25 19:14 ` Eric Biggers
2024-10-25 19:14 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2024-10-25 19:14 ` [PATCH v2 03/18] lib/crc32: expose whether the lib is really optimized at runtime Eric Biggers
2024-10-25 19:14 ` Eric Biggers
2024-10-25 19:14 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2024-10-25 20:32 ` Ard Biesheuvel
2024-10-25 20:32 ` Ard Biesheuvel
2024-10-25 20:32 ` [f2fs-dev] " Ard Biesheuvel via Linux-f2fs-devel
2024-10-25 21:32 ` Eric Biggers
2024-10-25 21:32 ` Eric Biggers
2024-10-25 21:32 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2024-10-25 21:37 ` Ard Biesheuvel
2024-10-25 21:37 ` Ard Biesheuvel
2024-10-25 21:37 ` [f2fs-dev] " Ard Biesheuvel via Linux-f2fs-devel
2024-10-25 22:31 ` Eric Biggers
2024-10-25 22:31 ` Eric Biggers
2024-10-25 22:31 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2024-10-25 19:14 ` [PATCH v2 04/18] crypto: crc32 - don't unnecessarily register arch algorithms Eric Biggers
2024-10-25 19:14 ` Eric Biggers
2024-10-25 19:14 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2024-10-25 20:47 ` Ard Biesheuvel
2024-10-25 20:47 ` Ard Biesheuvel
2024-10-25 20:47 ` [f2fs-dev] " Ard Biesheuvel via Linux-f2fs-devel
2024-10-25 22:02 ` Eric Biggers
2024-10-25 22:02 ` Eric Biggers
2024-10-25 22:02 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2024-10-26 4:09 ` Eric Biggers
2024-10-26 4:09 ` Eric Biggers
2024-10-26 4:09 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2024-10-27 8:14 ` Ard Biesheuvel
2024-10-27 8:14 ` Ard Biesheuvel
2024-10-27 8:14 ` [f2fs-dev] " Ard Biesheuvel via Linux-f2fs-devel
2024-11-02 9:45 ` Herbert Xu
2024-11-02 9:45 ` Herbert Xu
2024-11-02 9:45 ` [f2fs-dev] " Herbert Xu via Linux-f2fs-devel
2024-11-02 9:58 ` Ard Biesheuvel
2024-11-02 9:58 ` Ard Biesheuvel
2024-11-02 9:58 ` [f2fs-dev] " Ard Biesheuvel via Linux-f2fs-devel
2024-11-02 10:19 ` Herbert Xu
2024-11-02 10:19 ` Herbert Xu
2024-11-02 10:19 ` [f2fs-dev] " Herbert Xu via Linux-f2fs-devel
2024-11-02 10:46 ` Ard Biesheuvel
2024-11-02 10:46 ` Ard Biesheuvel
2024-11-02 10:46 ` [f2fs-dev] " Ard Biesheuvel via Linux-f2fs-devel
2024-11-02 11:05 ` Ard Biesheuvel
2024-11-02 11:05 ` Ard Biesheuvel
2024-11-02 11:05 ` [f2fs-dev] " Ard Biesheuvel via Linux-f2fs-devel
2024-11-02 11:08 ` Herbert Xu
2024-11-02 11:08 ` Herbert Xu
2024-11-02 11:08 ` [f2fs-dev] " Herbert Xu via Linux-f2fs-devel
2024-11-02 16:36 ` Eric Biggers
2024-11-02 16:36 ` Eric Biggers
2024-11-02 16:36 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2024-11-02 16:46 ` Ard Biesheuvel
2024-11-02 16:46 ` Ard Biesheuvel
2024-11-02 16:46 ` [f2fs-dev] " Ard Biesheuvel via Linux-f2fs-devel
2024-11-02 17:21 ` Milan Broz
2024-11-02 17:21 ` Milan Broz
2024-11-02 17:21 ` [f2fs-dev] " Milan Broz
2024-10-25 19:14 ` [PATCH v2 05/18] arm/crc32: expose CRC32 functions through lib Eric Biggers
2024-10-25 19:14 ` Eric Biggers
2024-10-25 19:14 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2024-10-25 19:14 ` [PATCH v2 06/18] loongarch/crc32: " Eric Biggers
2024-10-25 19:14 ` Eric Biggers
2024-10-25 19:14 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2024-11-03 13:36 ` WangYuli
2024-11-03 13:36 ` WangYuli
2024-11-03 13:36 ` [f2fs-dev] " WangYuli
2024-11-03 13:57 ` Eric Biggers [this message]
2024-11-03 13:57 ` Eric Biggers
2024-11-03 13:57 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2024-11-04 2:34 ` WangYuli
2024-11-04 2:34 ` WangYuli
2024-10-25 19:14 ` [PATCH v2 07/18] mips/crc32: " Eric Biggers
2024-10-25 19:14 ` Eric Biggers
2024-10-25 19:14 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2024-10-25 19:14 ` [PATCH v2 08/18] powerpc/crc32: " Eric Biggers
2024-10-25 19:14 ` Eric Biggers
2024-10-25 19:14 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2024-10-25 19:14 ` [PATCH v2 09/18] s390/crc32: " Eric Biggers
2024-10-25 19:14 ` Eric Biggers
2024-10-25 19:14 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2024-10-25 19:14 ` [PATCH v2 10/18] sparc/crc32: " Eric Biggers
2024-10-25 19:14 ` Eric Biggers
2024-10-25 19:14 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2024-10-25 19:14 ` [PATCH v2 11/18] x86/crc32: update prototype for crc_pcl() Eric Biggers
2024-10-25 19:14 ` Eric Biggers
2024-10-25 19:14 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2024-10-25 19:14 ` [PATCH v2 12/18] x86/crc32: update prototype for crc32_pclmul_le_16() Eric Biggers
2024-10-25 19:14 ` Eric Biggers
2024-10-25 19:14 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2024-10-25 19:14 ` [PATCH v2 13/18] x86/crc32: expose CRC32 functions through lib Eric Biggers
2024-10-25 19:14 ` Eric Biggers
2024-10-25 19:14 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2024-10-25 19:14 ` [PATCH v2 14/18] lib/crc32: make crc32c() go directly to lib Eric Biggers
2024-10-25 19:14 ` Eric Biggers
2024-10-25 19:14 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2024-10-25 19:14 ` [PATCH v2 15/18] ext4: switch to using the crc32c library Eric Biggers
2024-10-25 19:14 ` Eric Biggers
2024-10-25 19:14 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2024-11-02 22:26 ` Theodore Ts'o
2024-11-02 22:26 ` Theodore Ts'o
2024-11-02 22:26 ` [f2fs-dev] " Theodore Ts'o
2024-10-25 19:14 ` [PATCH v2 16/18] jbd2: " Eric Biggers
2024-10-25 19:14 ` Eric Biggers
2024-10-25 19:14 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2024-10-25 19:14 ` [PATCH v2 17/18] f2fs: switch to using the crc32 library Eric Biggers
2024-10-25 19:14 ` Eric Biggers
2024-10-25 19:14 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2024-10-25 19:14 ` [PATCH v2 18/18] scsi: target: iscsi: switch to using the crc32c library Eric Biggers
2024-10-25 19:14 ` Eric Biggers
2024-10-25 19:14 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2024-10-25 22:14 ` Ard Biesheuvel
2024-10-25 22:14 ` Ard Biesheuvel
2024-10-25 22:14 ` [f2fs-dev] " Ard Biesheuvel via Linux-f2fs-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241103135730.GA813@quark.localdomain \
--to=ebiggers@kernel.org \
--cc=ardb@kernel.org \
--cc=chenhuacai@kernel.org \
--cc=kernel@xen0n.name \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=loongarch@lists.linux.dev \
--cc=sparclinux@vger.kernel.org \
--cc=wangyuli@uniontech.com \
--cc=x86@kernel.org \
--cc=xry111@xry111.site \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.