From: "Krzysztof Wilczyński" <kwilczynski@kernel.org>
To: Richard Zhu <hongxing.zhu@nxp.com>
Cc: bhelgaas@google.com, lorenzo.pieralisi@arm.com, frank.li@nxp.com,
mani@kernel.org, linux-pci@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@pengutronix.de,
imx@lists.linux.dev
Subject: Re: [PATCH v2] PCI: dwc: Fix resume failure if no EP is connected at some platforms
Date: Mon, 4 Nov 2024 05:56:59 +0900 [thread overview]
Message-ID: <20241103205659.GI237624@rocinante> (raw)
In-Reply-To: <1721628913-1449-1-git-send-email-hongxing.zhu@nxp.com>
Hello,
> The dw_pcie_suspend_noirq() function currently returns success directly
> if no endpoint (EP) device is connected. However, on some platforms, power
> loss occurs during suspend, causing dw_resume() to do nothing in this case.
> This results in a system halt because the DWC controller is not initialized
> after power-on during resume.
>
> Change call to deinit() in suspend and init() at resume regardless of
> whether there are EP device connections or not. It is not harmful to
> perform deinit() and init() again for the no power-off case, and it keeps
> the code simple and consistent in logic.
Applied to controller/dwc, thank you!
[01/01] PCI: dwc: Fix resume failure if no EP is connected at some platforms
https://git.kernel.org/pci/pci/c/ec008c493c25
Krzysztof
next prev parent reply other threads:[~2024-11-03 20:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-22 6:15 [PATCH v2] PCI: dwc: Fix resume failure if no EP is connected at some platforms Richard Zhu
2024-11-03 20:56 ` Krzysztof Wilczyński [this message]
2024-11-06 6:18 ` Hongxing Zhu
2024-11-06 15:07 ` Krzysztof Wilczy��ski
2024-11-07 1:51 ` Hongxing Zhu
2024-11-05 23:27 ` Bjorn Helgaas
2024-11-06 1:59 ` Hongxing Zhu
2024-11-06 22:29 ` Bjorn Helgaas
2024-11-07 6:16 ` Hongxing Zhu
2024-11-07 7:20 ` Krzysztof Wilczyński
2024-11-07 8:40 ` Hongxing Zhu
2024-11-07 8:47 ` Hongxing Zhu
2024-11-07 16:30 ` Krzysztof Wilczy��ski
2024-11-07 16:57 ` Frank Li
2024-11-07 19:16 ` Krzysztof Wilczy��ski
2024-11-05 23:35 ` Bjorn Helgaas
2024-11-06 2:06 ` Hongxing Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241103205659.GI237624@rocinante \
--to=kwilczynski@kernel.org \
--cc=bhelgaas@google.com \
--cc=frank.li@nxp.com \
--cc=hongxing.zhu@nxp.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mani@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.