All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Krzysztof Wilczy��ski" <kw@linux.com>
To: Frank Li <Frank.li@nxp.com>
Cc: Hongxing Zhu <hongxing.zhu@nxp.com>,
	Bjorn Helgaas <helgaas@kernel.org>,
	"bhelgaas@google.com" <bhelgaas@google.com>,
	"lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>,
	"mani@kernel.org" <mani@kernel.org>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	"imx@lists.linux.dev" <imx@lists.linux.dev>
Subject: Re: [PATCH v2] PCI: dwc: Fix resume failure if no EP is connected at some platforms
Date: Fri, 8 Nov 2024 04:16:47 +0900	[thread overview]
Message-ID: <20241107191647.GA1869604@rocinante> (raw)
In-Reply-To: <ZyzxdnC4mm4GwoOx@lizhi-Precision-Tower-5810>

Hello,

[...]
> > > > > If the changes aren't too involved, then I would rather fix it or drop
> > > > > the not needed code now, before we sent the Pull Request.
> > > > >
> > > > > So, feel free to sent a small patch against the current branch, or
> > > > > simply let me know how do you wish the current code to be changed, so
> > > > > I can do it against the current branch.
> > > > Thanks for your kindly reminder.
> > > > This clean up small patch is on the way.
> > > Here it is.
> > > https://lkml.org/lkml/2024/11/7/409
> >
> > Thank you!
> >
> > That said, there here have been some concerns raised following a review of
> > the new patch, see:
> >
> >   - https://lore.kernel.org/linux-pci/20241107084455.3623576-1-hongxing.zhu@nxp.com
> >
> > Hence, I wonder whether we should drop this patch and then focus on
> > refinements to the new version, and perhaps, once its ready, then we
> > will include it—this might have to be for the next release at this
> > point, sadly.
> 
> I think we can continue discussion at refine patch. Add kept this patch
> because it really fix some important problem. Refine patch is just make it
> better.

Sounds good!  Thank you!

	Krzysztof

  reply	other threads:[~2024-11-07 19:16 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-22  6:15 [PATCH v2] PCI: dwc: Fix resume failure if no EP is connected at some platforms Richard Zhu
2024-11-03 20:56 ` Krzysztof Wilczyński
2024-11-06  6:18   ` Hongxing Zhu
2024-11-06 15:07     ` Krzysztof Wilczy��ski
2024-11-07  1:51       ` Hongxing Zhu
2024-11-05 23:27 ` Bjorn Helgaas
2024-11-06  1:59   ` Hongxing Zhu
2024-11-06 22:29     ` Bjorn Helgaas
2024-11-07  6:16       ` Hongxing Zhu
2024-11-07  7:20         ` Krzysztof Wilczyński
2024-11-07  8:40           ` Hongxing Zhu
2024-11-07  8:47             ` Hongxing Zhu
2024-11-07 16:30               ` Krzysztof Wilczy��ski
2024-11-07 16:57                 ` Frank Li
2024-11-07 19:16                   ` Krzysztof Wilczy��ski [this message]
2024-11-05 23:35 ` Bjorn Helgaas
2024-11-06  2:06   ` Hongxing Zhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241107191647.GA1869604@rocinante \
    --to=kw@linux.com \
    --cc=Frank.li@nxp.com \
    --cc=bhelgaas@google.com \
    --cc=helgaas@kernel.org \
    --cc=hongxing.zhu@nxp.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=mani@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.