All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alejandro Vallejo <alejandro.vallejo@cloud.com>
To: xen-devel@lists.xenproject.org
Cc: "Alejandro Vallejo" <alejandro.vallejo@cloud.com>,
	"Jan Beulich" <jbeulich@suse.com>,
	"Andrew Cooper" <andrew.cooper3@citrix.com>,
	"Roger Pau Monné" <roger.pau@citrix.com>
Subject: [PATCH v2 01/13] x86/xstate: Remove stale assertions in fpu_x{rstor,save}()
Date: Tue,  5 Nov 2024 14:32:58 +0000	[thread overview]
Message-ID: <20241105143310.28301-2-alejandro.vallejo@cloud.com> (raw)
In-Reply-To: <20241105143310.28301-1-alejandro.vallejo@cloud.com>

After edb48e76458b("x86/fpu: Combine fpu_ctxt and xsave_area in arch_vcpu"),
v->arch.xsave_area is always present and we can just remove these asserts.

Fixes: edb48e76458b("x86/fpu: Combine fpu_ctxt and xsave_area in arch_vcpu")
Signed-off-by: Alejandro Vallejo <alejandro.vallejo@cloud.com>
---
v2:
  * Remove asserts rather than refactor them.
  * Trimmed and adjusted commit message
---
 xen/arch/x86/i387.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/xen/arch/x86/i387.c b/xen/arch/x86/i387.c
index 83f9b2502bff..3add0025e495 100644
--- a/xen/arch/x86/i387.c
+++ b/xen/arch/x86/i387.c
@@ -24,7 +24,6 @@ static inline void fpu_xrstor(struct vcpu *v, uint64_t mask)
 {
     bool ok;
 
-    ASSERT(v->arch.xsave_area);
     /*
      * XCR0 normally represents what guest OS set. In case of Xen itself,
      * we set the accumulated feature mask before doing save/restore.
@@ -136,7 +135,6 @@ static inline void fpu_xsave(struct vcpu *v)
     uint64_t mask = vcpu_xsave_mask(v);
 
     ASSERT(mask);
-    ASSERT(v->arch.xsave_area);
     /*
      * XCR0 normally represents what guest OS set. In case of Xen itself,
      * we set the accumulated feature mask before doing save/restore.
-- 
2.47.0



  reply	other threads:[~2024-11-05 14:34 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-05 14:32 [PATCH v2 00/13] x86: Address Space Isolation FPU preparations Alejandro Vallejo
2024-11-05 14:32 ` Alejandro Vallejo [this message]
2024-11-07 10:29   ` [PATCH v2 01/13] x86/xstate: Remove stale assertions in fpu_x{rstor,save}() Jan Beulich
2024-11-05 14:32 ` [PATCH v2 02/13] x86/xstate: Create map/unmap primitives for xsave areas Alejandro Vallejo
2024-12-09 16:11   ` Jan Beulich
2024-12-16 11:00     ` Alejandro Vallejo
2024-11-05 14:33 ` [PATCH v2 03/13] x86/hvm: Map/unmap xsave area in hvm_save_cpu_ctxt() Alejandro Vallejo
2024-12-09 16:13   ` Jan Beulich
2024-11-05 14:33 ` [PATCH v2 04/13] x86/fpu: Map/umap xsave area in vcpu_{reset,setup}_fpu() Alejandro Vallejo
2024-12-09 16:14   ` Jan Beulich
2024-11-05 14:33 ` [PATCH v2 05/13] x86/xstate: Map/unmap xsave area in xstate_set_init() and handle_setbv() Alejandro Vallejo
2024-12-09 16:16   ` Jan Beulich
2024-12-16 11:02     ` Alejandro Vallejo
2024-11-05 14:33 ` [PATCH v2 06/13] x86/hvm: Map/unmap xsave area in hvmemul_{get,put}_fpu() Alejandro Vallejo
2024-12-09 16:18   ` Jan Beulich
2024-11-05 14:33 ` [PATCH v2 07/13] x86/domctl: Map/unmap xsave area in arch_get_info_guest() Alejandro Vallejo
2024-12-09 16:19   ` Jan Beulich
2024-11-05 14:33 ` [PATCH v2 08/13] x86/xstate: Map/unmap xsave area in {compress,expand}_xsave_states() Alejandro Vallejo
2024-12-09 16:20   ` Jan Beulich
2024-12-16 11:36     ` Alejandro Vallejo
2024-11-05 14:33 ` [PATCH v2 09/13] x86/emulator: Refactor FXSAVE_AREA to use wrappers Alejandro Vallejo
2024-12-09 16:26   ` Jan Beulich
2024-12-16 11:58     ` Alejandro Vallejo
2024-12-16 12:01       ` Jan Beulich
2024-12-16 14:37         ` Alejandro Vallejo
2024-11-05 14:33 ` [PATCH v2 10/13] x86/mpx: Map/unmap xsave area in in read_bndcfgu() Alejandro Vallejo
2024-12-09 16:30   ` Jan Beulich
2024-12-16 12:00     ` Alejandro Vallejo
2024-12-16 12:03       ` Jan Beulich
2024-12-16 14:02         ` Alejandro Vallejo
2025-01-10 11:40           ` Alejandro Vallejo
2024-11-05 14:33 ` [PATCH v2 11/13] x86/fpu: Pass explicit xsave areas to fpu_(f)xsave() Alejandro Vallejo
2024-12-09 16:37   ` Jan Beulich
2024-11-05 14:33 ` [PATCH v2 12/13] x86/fpu: Pass explicit xsave areas to fpu_(f)xrstor() Alejandro Vallejo
2024-12-09 16:39   ` Jan Beulich
2024-11-05 14:33 ` [PATCH v2 13/13] x86/xstate: Make xstate_all() and vcpu_xsave_mask() take explicit xstate Alejandro Vallejo
2024-12-09 16:41   ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241105143310.28301-2-alejandro.vallejo@cloud.com \
    --to=alejandro.vallejo@cloud.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=roger.pau@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.