* [merged mm-stable] mm-cma-fix-useless-return-in-void-function.patch removed from -mm tree
@ 2024-11-06 0:59 Andrew Morton
0 siblings, 0 replies; only message in thread
From: Andrew Morton @ 2024-11-06 0:59 UTC (permalink / raw)
To: mm-commits, shuah, pintu.ping, quic_pintu, akpm
The quilt patch titled
Subject: mm/cma: fix useless return in void function
has been removed from the -mm tree. Its filename was
mm-cma-fix-useless-return-in-void-function.patch
This patch was dropped because it was merged into the mm-stable branch
of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
------------------------------------------------------
From: Pintu Kumar <quic_pintu@quicinc.com>
Subject: mm/cma: fix useless return in void function
Date: Fri, 27 Sep 2024 23:46:37 +0530
There is a unnecessary return statement at the end of void function
cma_activate_area. This can be dropped.
While at it, also fix another warning related to unsigned.
These are reported by checkpatch as well.
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
+unsigned cma_area_count;
WARNING: void function return statements are not generally useful
+ return;
+}
Link: https://lkml.kernel.org/r/20240927181637.19941-1-quic_pintu@quicinc.com
Signed-off-by: Pintu Kumar <quic_pintu@quicinc.com>
Cc: Pintu Agarwal <pintu.ping@gmail.com>
Cc: Shuah Khan <shuah@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
mm/cma.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- a/mm/cma.c~mm-cma-fix-useless-return-in-void-function
+++ a/mm/cma.c
@@ -32,7 +32,7 @@
#include "cma.h"
struct cma cma_areas[MAX_CMA_AREAS];
-unsigned cma_area_count;
+unsigned int cma_area_count;
static DEFINE_MUTEX(cma_mutex);
phys_addr_t cma_get_base(const struct cma *cma)
@@ -135,7 +135,6 @@ out_error:
totalcma_pages -= cma->count;
cma->count = 0;
pr_err("CMA area %s could not be activated\n", cma->name);
- return;
}
static int __init cma_init_reserved_areas(void)
_
Patches currently in -mm which might be from quic_pintu@quicinc.com are
zsmalloc-replace-kmap_atomic-with-kmap_local_page.patch
mm-zsmalloc-use-memcpy_from-to_page-whereever-possible.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-11-06 0:59 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-06 0:59 [merged mm-stable] mm-cma-fix-useless-return-in-void-function.patch removed from -mm tree Andrew Morton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.