* [PATCH 1/3] [PATCH v3] Documentation:leds: Add leds-st1202.rst @ 2024-11-05 16:10 Vicentiu Galanopulo 2024-11-05 16:10 ` [PATCH 2/3] [PATCH v4] dt-bindings: leds: Add LED1202 LED Controller Vicentiu Galanopulo 2024-11-05 16:10 ` [PATCH 3/3] [PATCH v5] leds: Add LED1202 I2C driver Vicentiu Galanopulo 0 siblings, 2 replies; 5+ messages in thread From: Vicentiu Galanopulo @ 2024-11-05 16:10 UTC (permalink / raw) To: Pavel Machek, Lee Jones, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Jonathan Corbet, Vicentiu Galanopulo, linux-leds, devicetree, linux-kernel, linux-doc Add usage for sysfs hw_pattern entry for leds-st1202 Signed-off-by: Vicentiu Galanopulo <vicentiu.galanopulo@remote-tech.co.uk> --- - Changes in v3: Add leds-st1202 to index.rst - Changes in v2: Implement review comments --- Documentation/leds/index.rst | 1 + Documentation/leds/leds-st1202.rst | 36 ++++++++++++++++++++++++++++++ 2 files changed, 37 insertions(+) create mode 100644 Documentation/leds/leds-st1202.rst diff --git a/Documentation/leds/index.rst b/Documentation/leds/index.rst index 3ade16c18328..0ab0a2128a11 100644 --- a/Documentation/leds/index.rst +++ b/Documentation/leds/index.rst @@ -28,4 +28,5 @@ LEDs leds-mlxcpld leds-mt6370-rgb leds-sc27xx + leds-st1202.rst leds-qcom-lpg diff --git a/Documentation/leds/leds-st1202.rst b/Documentation/leds/leds-st1202.rst new file mode 100644 index 000000000000..e647966e496c --- /dev/null +++ b/Documentation/leds/leds-st1202.rst @@ -0,0 +1,36 @@ +.. SPDX-License-Identifier: GPL-2.0 + +============================================ +Kernel driver for STMicroelectronics LED1202 +============================================ + +/sys/class/leds/<led>/hw_pattern +-------------------------------- + +Specify a hardware pattern for the ST1202 LED. The LED +controller implements 12 low-side current generators +with independent dimming control. Internal volatile memory +allows the user to store up to 8 different patterns. +Each pattern is a particular output configuration in terms +of PWM duty-cycle and duration (ms). + +To be compatible with the hardware pattern +format, maximum 8 tuples of brightness (PWM) and duration must +be written to hw_pattern. + +- Min pattern duration: 22 ms +- Max pattern duration: 5660 ms + +The format of the hardware pattern values should be: +"brightness duration brightness duration ..." + +/sys/class/leds/<led>/repeat +---------------------------- + +Specify a pattern repeat number, which is common for all channels. +Default is 1; negative numbers and 0 are invalid. + +This file will always return the originally written repeat number. + +When the 255 value is written to it, all patterns will repeat +indefinitely. -- 2.25.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/3] [PATCH v4] dt-bindings: leds: Add LED1202 LED Controller 2024-11-05 16:10 [PATCH 1/3] [PATCH v3] Documentation:leds: Add leds-st1202.rst Vicentiu Galanopulo @ 2024-11-05 16:10 ` Vicentiu Galanopulo 2024-11-05 16:10 ` [PATCH 3/3] [PATCH v5] leds: Add LED1202 I2C driver Vicentiu Galanopulo 1 sibling, 0 replies; 5+ messages in thread From: Vicentiu Galanopulo @ 2024-11-05 16:10 UTC (permalink / raw) To: Pavel Machek, Lee Jones, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Jonathan Corbet, Vicentiu Galanopulo, linux-leds, devicetree, linux-kernel, linux-doc The LED1202 is a 12-channel low quiescent current LED driver with: * Supply range from 2.6 V to 5 V * 20 mA current capability per channel * 1.8 V compatible I2C control interface * 8-bit analog dimming individual control * 12-bit local PWM resolution * 8 programmable patterns If the led node is present in the controller then the channel is set to active. v1: https://lore.kernel.org/lkml/ZnCnnQfwuRueCIQ0@admins-Air/T/ v2: https://lore.kernel.org/all/ZniNdGgKyUMV-hjq@admins-Air/T/ v3: https://lore.kernel.org/all/ZniNdGgKyUMV-hjq@admins-Air/T/ Signed-off-by: Vicentiu Galanopulo <vicentiu.galanopulo@remote-tech.co.uk> --- Changes in v4: - remove label property, use devm_led_classdev_register_ext instead - use as base patch the v3 Changes in v3: - remove active property Changes in v2: - renamed label to remove color from it - add color property for each node - add function and function-enumerator property for each node --- .../devicetree/bindings/leds/st,led1202.yaml | 132 ++++++++++++++++++ 1 file changed, 132 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/st,led1202.yaml diff --git a/Documentation/devicetree/bindings/leds/st,led1202.yaml b/Documentation/devicetree/bindings/leds/st,led1202.yaml new file mode 100644 index 000000000000..7e49e6464d41 --- /dev/null +++ b/Documentation/devicetree/bindings/leds/st,led1202.yaml @@ -0,0 +1,132 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/leds/st,led1202.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: ST LED1202 LED controllers + +maintainers: + - Vicentiu Galanopulo <vicentiu.galanopulo@remote-tech.co.uk> + +description: | + The LED1202 is a 12-channel low quiescent current LED controller + programmable via I2C; The output current can be adjusted separately + for each channel by 8-bit analog and 12-bit digital dimming control. + Datasheet available at + https://www.st.com/en/power-management/led1202.html + +properties: + compatible: + const: st,led1202 + + reg: + maxItems: 1 + + "#address-cells": + const: 1 + + "#size-cells": + const: 0 + +patternProperties: + "^led@[0-9a-f]$": + type: object + $ref: common.yaml# + unevaluatedProperties: false + + properties: + reg: + minimum: 0 + maximum: 11 + + required: + - reg + +required: + - compatible + - reg + - "#address-cells" + - "#size-cells" + +additionalProperties: false + +examples: + - | + #include <dt-bindings/leds/common.h> + + i2c { + #address-cells = <1>; + #size-cells = <0>; + + led-controller@58 { + compatible = "st,led1202"; + reg = <0x58>; + #address-cells = <1>; + #size-cells = <0>; + + led@0 { + reg = <0x0>; + function = LED_FUNCTION_STATUS; + color = <LED_COLOR_ID_RED>; + function-enumerator = <1>; + }; + + led@1 { + reg = <0x1>; + function = LED_FUNCTION_STATUS; + color = <LED_COLOR_ID_GREEN>; + function-enumerator = <2>; + }; + + led@2 { + reg = <0x2>; + function = LED_FUNCTION_STATUS; + color = <LED_COLOR_ID_BLUE>; + function-enumerator = <3>; + }; + + led@3 { + reg = <0x3>; + function = LED_FUNCTION_STATUS; + color = <LED_COLOR_ID_RED>; + function-enumerator = <4>; + }; + + led@4 { + reg = <0x4>; + function = LED_FUNCTION_STATUS; + color = <LED_COLOR_ID_GREEN>; + function-enumerator = <5>; + }; + + led@5 { + reg = <0x5>; + function = LED_FUNCTION_STATUS; + color = <LED_COLOR_ID_BLUE>; + function-enumerator = <6>; + }; + + led@6 { + reg = <0x6>; + function = LED_FUNCTION_STATUS; + color = <LED_COLOR_ID_RED>; + function-enumerator = <7>; + }; + + led@7 { + reg = <0x7>; + function = LED_FUNCTION_STATUS; + color = <LED_COLOR_ID_GREEN>; + function-enumerator = <8>; + }; + + led@8 { + reg = <0x8>; + function = LED_FUNCTION_STATUS; + color = <LED_COLOR_ID_BLUE>; + function-enumerator = <9>; + }; + }; + }; +... -- 2.25.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 3/3] [PATCH v5] leds: Add LED1202 I2C driver 2024-11-05 16:10 [PATCH 1/3] [PATCH v3] Documentation:leds: Add leds-st1202.rst Vicentiu Galanopulo 2024-11-05 16:10 ` [PATCH 2/3] [PATCH v4] dt-bindings: leds: Add LED1202 LED Controller Vicentiu Galanopulo @ 2024-11-05 16:10 ` Vicentiu Galanopulo 2024-11-06 0:38 ` kernel test robot 2024-11-06 2:03 ` kernel test robot 1 sibling, 2 replies; 5+ messages in thread From: Vicentiu Galanopulo @ 2024-11-05 16:10 UTC (permalink / raw) To: Pavel Machek, Lee Jones, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Jonathan Corbet, Vicentiu Galanopulo, linux-leds, devicetree, linux-kernel, linux-doc The output current can be adjusted separately for each channel by 8-bit analog (current sink input) and 12-bit digital (PWM) dimming control. The LED1202 implements 12 low-side current generators with independent dimming control. Internal volatile memory allows the user to store up to 8 different patterns, each pattern is a particular output configuration in terms of PWM duty-cycle (on 4096 steps). Analog dimming (on 256 steps) is per channel but common to all patterns. Each device tree LED node will have a corresponding entry in /sys/class/leds with the label name. The brightness property corresponds to the per channel analog dimming, while the patterns[1-8] to the PWM dimming control. Signed-off-by: Vicentiu Galanopulo <vicentiu.galanopulo@remote-tech.co.uk> --- Changes in v5: - remove unused macros - switch to using devm_led_classdev_register_ext (struct st1202_led update) - add prescalar_to_milliseconds (convert [22..5660]ms to [0..255] reg value) - remove register range check in dt_init (range protected by yaml) - address all review comments in v4 Changes in v4: - Remove attributes/extended attributes implementation - Use /sys/class/leds/<led>/hw_pattern (Pavel suggestion) - Implement review findings of Christophe JAILLET Changes in v3: - Rename all ll1202 to st1202, including driver file name - Convert all magic numbers to defines - Refactor the show/store callbacks as per Lee's and Thomas's review - Remove ll1202_get_channel and use dev_ext_attributes instead - Log all error values for all the functions - Use sysfs_emit for show callbacks Changes in v2: - Fix build error for device_attribute modes --- drivers/leds/Kconfig | 11 + drivers/leds/Makefile | 1 + drivers/leds/leds-st1202.c | 510 +++++++++++++++++++++++++++++++++++++ 3 files changed, 522 insertions(+) create mode 100644 drivers/leds/leds-st1202.c diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig index b784bb74a837..c4fdacc00066 100644 --- a/drivers/leds/Kconfig +++ b/drivers/leds/Kconfig @@ -931,6 +931,17 @@ config LEDS_LM36274 Say Y to enable the LM36274 LED driver for TI LMU devices. This supports the LED device LM36274. +config LEDS_ST1202 + tristate "LED Support for STMicroelectronics LED1202 I2C chips" + depends on LEDS_CLASS + depends on I2C + depends on OF + select LEDS_TRIGGERS + help + Say Y to enable support for LEDs connected to LED1202 + LED driver chips accessed via the I2C bus. + Supported devices include LED1202. + config LEDS_TPS6105X tristate "LED support for TI TPS6105X" depends on LEDS_CLASS diff --git a/drivers/leds/Makefile b/drivers/leds/Makefile index 18afbb5a23ee..e8b39ef760cc 100644 --- a/drivers/leds/Makefile +++ b/drivers/leds/Makefile @@ -81,6 +81,7 @@ obj-$(CONFIG_LEDS_POWERNV) += leds-powernv.o obj-$(CONFIG_LEDS_PWM) += leds-pwm.o obj-$(CONFIG_LEDS_REGULATOR) += leds-regulator.o obj-$(CONFIG_LEDS_SC27XX_BLTC) += leds-sc27xx-bltc.o +obj-$(CONFIG_LEDS_ST1202) += leds-st1202.o obj-$(CONFIG_LEDS_SUN50I_A100) += leds-sun50i-a100.o obj-$(CONFIG_LEDS_SUNFIRE) += leds-sunfire.o obj-$(CONFIG_LEDS_SYSCON) += leds-syscon.o diff --git a/drivers/leds/leds-st1202.c b/drivers/leds/leds-st1202.c new file mode 100644 index 000000000000..565c8fbfe515 --- /dev/null +++ b/drivers/leds/leds-st1202.c @@ -0,0 +1,510 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * LED driver for STMicroelectronics LED1202 chip + * + * Copyright (C) 2024 Remote-Tech Ltd. UK + */ + +#include <linux/ctype.h> +#include <linux/delay.h> +#include <linux/err.h> +#include <linux/gpio.h> +#include <linux/i2c.h> +#include <linux/leds.h> +#include <linux/module.h> +#include <linux/slab.h> +#include <linux/string.h> + +#define ST1202_CHAN_DISABLE_ALL 0x00 +#define ST1202_CHAN_ENABLE_HIGH 0x03 +#define ST1202_CHAN_ENABLE_LOW 0x02 +#define ST1202_CONFIG_REG 0x04 +/* PATS: Pattern sequence feature enable */ +#define ST1202_CONFIG_REG_PATS BIT(7) +/* PATSR: Pattern sequence runs (self-clear when sequence is finished) */ +#define ST1202_CONFIG_REG_PATSR BIT(6) +#define ST1202_CONFIG_REG_SHFT BIT(3) +#define ST1202_DEV_ENABLE 0x01 +#define ST1202_DEV_ENABLE_ON BIT(0) +#define ST1202_DEV_ENABLE_RESET BIT(7) +#define ST1202_DEVICE_ID 0x00 +#define ST1202_ILED_REG0 0x09 +#define ST1202_MAX_LEDS 12 +#define ST1202_MAX_PATTERNS 8 +#define ST1202_MILLIS_PATTERN_DUR_MAX 5660 +#define ST1202_MILLIS_PATTERN_DUR_MIN 22 +#define ST1202_PATTERN_DUR 0x16 +#define ST1202_PATTERN_PWM 0x1E +#define ST1202_PATTERN_REP 0x15 + +struct st1202_led { + struct fwnode_handle *fwnode; + struct led_classdev led_cdev; + struct st1202_chip *chip; + bool is_active; + int led_num; +}; + +struct st1202_chip { + struct i2c_client *client; + struct mutex lock; + struct st1202_led leds[ST1202_MAX_LEDS]; +}; + +static struct st1202_led *cdev_to_st1202_led(struct led_classdev *cdev) +{ + return container_of(cdev, struct st1202_led, led_cdev); +} + +static int st1202_read_reg(struct st1202_chip *chip, int reg, uint8_t *val) +{ + int ret; + + ret = i2c_smbus_read_byte_data(chip->client, reg); + if (ret < 0) + return ret; + + *val = (uint8_t)ret; + return 0; +} + +static int st1202_write_reg(struct st1202_chip *chip, int reg, uint8_t val) +{ + return i2c_smbus_write_byte_data(chip->client, reg, val); +} + +static uint8_t st1202_prescalar_to_miliseconds(unsigned int value) +{ + return value/ST1202_MILLIS_PATTERN_DUR_MIN - 1; +} + +static int st1202_pwm_pattern_write(struct st1202_chip *chip, int led_num, + int pattern, unsigned int value) +{ + u8 value_l, value_h; + int ret; + + value_l = (u8)value; + value_h = (u8)(value >> 8); + + /* + * Datasheet: Register address low = 1Eh + 2*(xh) + 18h*(yh), + * where x is the channel number (led number) in hexadecimal (x = 00h .. 0Bh) + * and y is the pattern number in hexadecimal (y = 00h .. 07h) + */ + ret = st1202_write_reg(chip, (ST1202_PATTERN_PWM + (led_num * 2) + 0x18 * pattern), + value_l); + if (ret != 0) { + dev_err(&chip->client->dev, "Failed writing value %d to register [0x%x], error: %d\n", + value_l, ST1202_PATTERN_PWM + (led_num * 2) + 0x18 * pattern, ret); + return ret; + } + + /* + * Datasheet: Register address high = 1Eh + 01h + 2(xh) +18h*(yh), + * where x is the channel number in hexadecimal (x = 00h .. 0Bh) + * and y is the pattern number in hexadecimal (y = 00h .. 07h) + */ + ret = st1202_write_reg(chip, (ST1202_PATTERN_PWM + 0x1 + (led_num * 2) + 0x18 * pattern), + value_h); + if (ret != 0) { + dev_err(&chip->client->dev, "Failed writing value %d to register [0x%x], error: %d\n", + value_h, ST1202_PATTERN_PWM + 0x1 + (led_num * 2) + 0x18 * pattern, ret); + return ret; + } + + return 0; +} + +static int st1202_duration_pattern_write(struct st1202_chip *chip, int pattern, + unsigned int value) +{ + int ret; + + ret = st1202_write_reg(chip, (ST1202_PATTERN_DUR + pattern), + st1202_prescalar_to_miliseconds(value)); + if (ret != 0) { + dev_err(&chip->client->dev, "Writing to register [0x%x] failed, value %u\n", + ST1202_PATTERN_DUR + pattern, value); + return ret; + } + + return 0; +} + +static void st1202_brightness_set(struct led_classdev *led_cdev, + enum led_brightness value) +{ + struct st1202_led *led; + struct st1202_chip *chip; + int ret; + + led = cdev_to_st1202_led(led_cdev); + chip = led->chip; + + mutex_lock(&chip->lock); + + ret = st1202_write_reg(chip, ST1202_ILED_REG0 + led->led_num, value); + if (ret != 0) + dev_err(&chip->client->dev, "Reading register [0x%x] failed, error: %d\n", + ST1202_ILED_REG0 + led->led_num, ret); + + mutex_unlock(&chip->lock); +} + +static enum led_brightness st1202_brightness_get(struct led_classdev *led_cdev) +{ + struct st1202_led *led; + struct st1202_chip *chip; + u8 value; + int ret; + + led = cdev_to_st1202_led(led_cdev); + chip = led->chip; + + mutex_lock(&chip->lock); + + ret = st1202_read_reg(chip, ST1202_ILED_REG0 + led->led_num, + &value); + if (ret != 0) + dev_err(&chip->client->dev, "Reading register [0x%x] failed, error: %d\n", + ST1202_ILED_REG0 + led->led_num, ret); + + mutex_unlock(&chip->lock); + + return value; +} + +static int st1202_channel_set(struct st1202_chip *chip, int led_num, bool active) +{ + u8 chan_low, chan_high; + int ret; + + mutex_lock(&chip->lock); + + if (led_num <= 7) { + ret = st1202_read_reg(chip, ST1202_CHAN_ENABLE_LOW, &chan_low); + if (ret < 0) { + dev_err(&chip->client->dev, "Failed reading register [0x%x], error: %d\n", + ST1202_CHAN_ENABLE_LOW, ret); + goto exit; + } + + chan_low = active ? chan_low | BIT(led_num) : chan_low & ~BIT(led_num); + + ret = st1202_write_reg(chip, ST1202_CHAN_ENABLE_LOW, chan_low); + if (ret < 0) { + dev_err(&chip->client->dev, "Failed writing to register [0x%x], error: %d\n", + ST1202_CHAN_ENABLE_LOW, ret); + goto exit; + } + } else { + ret = st1202_read_reg(chip, ST1202_CHAN_ENABLE_HIGH, &chan_high); + if (ret < 0) { + dev_err(&chip->client->dev, "Failed reading register [0x%x], error: %d\n", + ST1202_CHAN_ENABLE_HIGH, ret); + goto exit; + } + + chan_high = active ? chan_high | (BIT(led_num) >> 8) : + chan_high & ~(BIT(led_num) >> 8); + + ret = st1202_write_reg(chip, ST1202_CHAN_ENABLE_HIGH, chan_high); + if (ret < 0) + dev_err(&chip->client->dev, "Failed writing to register [0x%x], error: %d\n", + ST1202_CHAN_ENABLE_HIGH, ret); + } + +exit: + mutex_unlock(&chip->lock); + return ret; +} + +static int st1202_led_set(struct led_classdev *ldev, enum led_brightness value) +{ + struct st1202_led *led; + struct st1202_chip *chip; + int ret; + + led = cdev_to_st1202_led(ldev); + chip = led->chip; + + ret = st1202_channel_set(chip, led->led_num, value == LED_OFF ? false : true); + + return ret; +} + +static int st1202_led_pattern_clear(struct led_classdev *ldev) +{ + struct st1202_led *led; + struct st1202_chip *chip; + int ret; + + led = cdev_to_st1202_led(ldev); + chip = led->chip; + + mutex_lock(&chip->lock); + + for (int patt = 0; patt < ST1202_MAX_PATTERNS; patt++) { + ret = st1202_pwm_pattern_write(chip, led->led_num, patt, LED_OFF); + if (ret != 0) + goto exit; + + ret = st1202_duration_pattern_write(chip, patt, ST1202_MILLIS_PATTERN_DUR_MIN); + if (ret != 0) + goto exit; + } + +exit: + mutex_unlock(&chip->lock); + + return ret; +} + +static int st1202_led_pattern_set(struct led_classdev *ldev, + struct led_pattern *pattern, + u32 len, int repeat) +{ + struct st1202_led *led; + struct st1202_chip *chip; + int ret; + + led = cdev_to_st1202_led(ldev); + chip = led->chip; + + if (len > ST1202_MAX_PATTERNS) + return -EINVAL; + + mutex_lock(&chip->lock); + + for (int patt = 0; patt < len; patt++) { + if (pattern[patt].delta_t < ST1202_MILLIS_PATTERN_DUR_MIN || + pattern[patt].delta_t > ST1202_MILLIS_PATTERN_DUR_MAX) { + ret = -EINVAL; + goto exit; + } + + ret = st1202_pwm_pattern_write(chip, led->led_num, patt, pattern[patt].brightness); + if (ret != 0) + goto exit; + + ret = st1202_duration_pattern_write(chip, patt, pattern[patt].delta_t); + if (ret != 0) + goto exit; + } + + ret = st1202_write_reg(chip, ST1202_PATTERN_REP, repeat); + if (ret != 0) { + dev_err(&chip->client->dev, "Writing register [0x%x] failed, error: %d\n", + ST1202_PATTERN_REP, ret); + goto exit; + } + + ret = st1202_write_reg(chip, ST1202_CONFIG_REG, + (ST1202_CONFIG_REG_PATSR | ST1202_CONFIG_REG_PATS | + ST1202_CONFIG_REG_SHFT)); + if (ret != 0) { + dev_err(&chip->client->dev, "Failed writing value %ld to register [0x%x], error: %d\n", + (ST1202_CONFIG_REG_PATSR | ST1202_CONFIG_REG_PATS | ST1202_CONFIG_REG_SHFT), + ST1202_CONFIG_REG, ret); + goto exit; + } + +exit: + mutex_unlock(&chip->lock); + + return ret; +} + +static int st1202_dt_init(struct st1202_chip *chip) +{ + struct device *dev = &chip->client->dev; + struct st1202_led *led; + int err, reg; + + for_each_available_child_of_node_scoped(dev_of_node(dev), child) { + struct led_init_data init_data = {}; + + err = of_property_read_u32(child, "reg", ®); + if (err) { + of_node_put(child); + return dev_err_probe(dev, err, "Invalid register, error: %d\n", err); + } + + led = &chip->leds[reg]; + led->is_active = true; + led->fwnode = of_fwnode_handle(child); + + led->led_cdev.max_brightness = U8_MAX; + led->led_cdev.brightness_set_blocking = st1202_led_set; + led->led_cdev.pattern_set = st1202_led_pattern_set; + led->led_cdev.pattern_clear = st1202_led_pattern_clear; + led->led_cdev.default_trigger = "pattern"; + + init_data.fwnode = led->fwnode; + init_data.devicename = "st1202"; + init_data.default_label = ":"; + err = devm_led_classdev_register_ext(dev, + &led->led_cdev, &init_data); + if (err < 0) { + dev_err_probe(dev, err, "Failed to register LED class dev, + error: %d\n", err); + return err; + } + led->led_cdev.brightness_set = st1202_brightness_set; + led->led_cdev.brightness_get = st1202_brightness_get; + } + + return 0; +} + +static int st1202_setup(struct st1202_chip *chip) +{ + int ret; + + mutex_lock(&chip->lock); + /* + * Once the supply voltage is applied, the LED1202 executes some internal checks, + * afterwords it stops the oscillator and puts the internal LDO in quiescent mode. + * To start the device, EN bit must be set inside the “Device Enable” register at + * address 01h. As soon as EN is set, the LED1202 loads the adjustment parameters + * from the internal non-volatile memory and performs an auto-calibration procedure + * in order to increase the output current precision. + * Such initialization lasts about 6.5 ms. + */ + + /* Reset the chip during setup */ + ret = st1202_write_reg(chip, ST1202_DEV_ENABLE, ST1202_DEV_ENABLE_RESET); + if (ret < 0) { + dev_err_probe(&chip->client->dev, -EIO, + "Failed to write to register [0x%x], error: %d\n", + ST1202_DEV_ENABLE, ret); + goto exit; + } + + /* Enable phase-shift delay feature */ + ret = st1202_write_reg(chip, ST1202_CONFIG_REG, ST1202_CONFIG_REG_SHFT); + if (ret < 0) { + dev_err_probe(&chip->client->dev, -EIO, + "Failed to write to register [0x%x], error: %d\n", + ST1202_CONFIG_REG, ret); + goto exit; + } + + /* Enable the device */ + ret = st1202_write_reg(chip, ST1202_DEV_ENABLE, ST1202_DEV_ENABLE_ON); + if (ret < 0) { + dev_err_probe(&chip->client->dev, -EIO, + "Failed to write to register [0x%x], error: %d\n", + ST1202_DEV_ENABLE, ret); + goto exit; + } + + /* Duration of initialization */ + usleep_range(6500, 10000); + + /* Deactivate all LEDS (channels) and activate only the ones found in Device Tree */ + ret = st1202_write_reg(chip, ST1202_CHAN_ENABLE_LOW, ST1202_CHAN_DISABLE_ALL); + if (ret < 0) { + dev_err_probe(&chip->client->dev, -EIO, + "Failed writing to register [0x%x], error: %d\n", + ST1202_CHAN_ENABLE_LOW, ret); + goto exit; + } + + ret = st1202_write_reg(chip, ST1202_CHAN_ENABLE_HIGH, ST1202_CHAN_DISABLE_ALL); + if (ret < 0) { + dev_err_probe(&chip->client->dev, -EIO, + "Failed writing to register [0x%x], error: %d\n", + ST1202_CHAN_ENABLE_HIGH, ret); + goto exit; + } + + ret = st1202_write_reg(chip, ST1202_CONFIG_REG, + ST1202_CONFIG_REG_PATS | ST1202_CONFIG_REG_PATSR); + if (ret < 0) { + dev_err_probe(&chip->client->dev, -EIO, + "Failed writing to register [0x%lx], error: %d\n", + ST1202_CONFIG_REG_PATS | ST1202_CONFIG_REG_PATSR, ret); + goto exit; + } + +exit: + mutex_unlock(&chip->lock); + return ret; +} + +static int st1202_probe(struct i2c_client *client) +{ + struct st1202_chip *chip; + struct st1202_led *led; + int ret; + + if (!i2c_check_functionality(client->adapter, I2C_FUNC_SMBUS_BYTE_DATA)) + return dev_err_probe(&client->dev, -EIO, "SMBUS Byte Data not Supported\n"); + + chip = devm_kzalloc(&client->dev, sizeof(*chip), GFP_KERNEL); + if (!chip) + return -ENOMEM; + + i2c_set_clientdata(client, chip); + + devm_mutex_init(&client->dev, &chip->lock); + chip->client = client; + + ret = st1202_dt_init(chip); + if (ret < 0) + return ret; + + ret = st1202_setup(chip); + if (ret < 0) + return ret; + + for (int i = 0; i < ST1202_MAX_LEDS; i++) { + led = &chip->leds[i]; + led->chip = chip; + led->led_num = i; + + if (led->is_active) { + ret = st1202_channel_set(led->chip, led->led_num, true); + if (ret < 0) { + return dev_err_probe(&client->dev, -EIO, + "Failed to activate LED channel, error: %d\n", ret); + } + + ret = st1202_led_pattern_clear(&led->led_cdev); + if (ret < 0) { + return dev_err_probe(&client->dev, -EIO, + "Failed to clear LED pattern, error: %d\n", ret); + } + } + } + + return 0; +} + +static const struct i2c_device_id st1202_id[] = { + { "st1202-i2c" }, + { /* sentinel */ }, +}; +MODULE_DEVICE_TABLE(i2c, st1202_id); + +static const struct of_device_id st1202_dt_ids[] = { + { .compatible = "st,led1202", }, + { /* sentinel */ }, +}; +MODULE_DEVICE_TABLE(of, st1202_dt_ids); + +static struct i2c_driver st1202_driver = { + .driver = { + .name = "leds-st1202", + .of_match_table = of_match_ptr(st1202_dt_ids), + }, + .probe = st1202_probe, + .id_table = st1202_id, +}; +module_i2c_driver(st1202_driver); + +MODULE_AUTHOR("Remote Tech LTD"); +MODULE_DESCRIPTION("STMicroelectronics LED1202 : 12-channel constant current LED driver"); +MODULE_LICENSE("GPL"); -- 2.25.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 3/3] [PATCH v5] leds: Add LED1202 I2C driver 2024-11-05 16:10 ` [PATCH 3/3] [PATCH v5] leds: Add LED1202 I2C driver Vicentiu Galanopulo @ 2024-11-06 0:38 ` kernel test robot 2024-11-06 2:03 ` kernel test robot 1 sibling, 0 replies; 5+ messages in thread From: kernel test robot @ 2024-11-06 0:38 UTC (permalink / raw) To: Vicentiu Galanopulo, Pavel Machek, Lee Jones, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Jonathan Corbet, linux-leds, devicetree, linux-kernel, linux-doc Cc: oe-kbuild-all Hi Vicentiu, kernel test robot noticed the following build errors: [auto build test ERROR on lee-leds/for-leds-next] [also build test ERROR on robh/for-next linus/master v6.12-rc6 next-20241105] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Vicentiu-Galanopulo/dt-bindings-leds-Add-LED1202-LED-Controller/20241106-001305 base: https://git.kernel.org/pub/scm/linux/kernel/git/lee/leds.git for-leds-next patch link: https://lore.kernel.org/r/20241105161041.4813-3-vicentiu.galanopulo%40remote-tech.co.uk patch subject: [PATCH 3/3] [PATCH v5] leds: Add LED1202 I2C driver config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20241106/202411060859.fqkOY75Z-lkp@intel.com/config) compiler: alpha-linux-gcc (GCC) 13.3.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241106/202411060859.fqkOY75Z-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202411060859.fqkOY75Z-lkp@intel.com/ All error/warnings (new ones prefixed by >>): drivers/leds/leds-st1202.c: In function 'st1202_dt_init': >> drivers/leds/leds-st1202.c:350:49: warning: missing terminating " character 350 | dev_err_probe(dev, err, "Failed to register LED class dev, | ^ >> drivers/leds/leds-st1202.c:350:49: error: missing terminating " character 350 | dev_err_probe(dev, err, "Failed to register LED class dev, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> drivers/leds/leds-st1202.c:351:41: error: 'error' undeclared (first use in this function); did you mean 'err'? 351 | error: %d\n", err); | ^~~~~ | err drivers/leds/leds-st1202.c:351:41: note: each undeclared identifier is reported only once for each function it appears in >> drivers/leds/leds-st1202.c:351:46: error: expected ')' before ':' token 351 | error: %d\n", err); | ^ | ) drivers/leds/leds-st1202.c:350:38: note: to match this '(' 350 | dev_err_probe(dev, err, "Failed to register LED class dev, | ^ >> drivers/leds/leds-st1202.c:351:50: error: stray '\' in program 351 | error: %d\n", err); | ^ drivers/leds/leds-st1202.c:351:52: warning: missing terminating " character 351 | error: %d\n", err); | ^ drivers/leds/leds-st1202.c:351:52: error: missing terminating " character 351 | error: %d\n", err); | ^~~~~~~~ >> drivers/leds/leds-st1202.c:352:36: error: expected ';' before '}' token 352 | return err; | ^ | ; 353 | } | ~ vim +350 drivers/leds/leds-st1202.c 318 319 static int st1202_dt_init(struct st1202_chip *chip) 320 { 321 struct device *dev = &chip->client->dev; 322 struct st1202_led *led; 323 int err, reg; 324 325 for_each_available_child_of_node_scoped(dev_of_node(dev), child) { 326 struct led_init_data init_data = {}; 327 328 err = of_property_read_u32(child, "reg", ®); 329 if (err) { 330 of_node_put(child); 331 return dev_err_probe(dev, err, "Invalid register, error: %d\n", err); 332 } 333 334 led = &chip->leds[reg]; 335 led->is_active = true; 336 led->fwnode = of_fwnode_handle(child); 337 338 led->led_cdev.max_brightness = U8_MAX; 339 led->led_cdev.brightness_set_blocking = st1202_led_set; 340 led->led_cdev.pattern_set = st1202_led_pattern_set; 341 led->led_cdev.pattern_clear = st1202_led_pattern_clear; 342 led->led_cdev.default_trigger = "pattern"; 343 344 init_data.fwnode = led->fwnode; 345 init_data.devicename = "st1202"; 346 init_data.default_label = ":"; 347 err = devm_led_classdev_register_ext(dev, 348 &led->led_cdev, &init_data); 349 if (err < 0) { > 350 dev_err_probe(dev, err, "Failed to register LED class dev, > 351 error: %d\n", err); > 352 return err; 353 } 354 led->led_cdev.brightness_set = st1202_brightness_set; 355 led->led_cdev.brightness_get = st1202_brightness_get; 356 } 357 358 return 0; 359 } 360 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 3/3] [PATCH v5] leds: Add LED1202 I2C driver 2024-11-05 16:10 ` [PATCH 3/3] [PATCH v5] leds: Add LED1202 I2C driver Vicentiu Galanopulo 2024-11-06 0:38 ` kernel test robot @ 2024-11-06 2:03 ` kernel test robot 1 sibling, 0 replies; 5+ messages in thread From: kernel test robot @ 2024-11-06 2:03 UTC (permalink / raw) To: Vicentiu Galanopulo, Pavel Machek, Lee Jones, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Jonathan Corbet, linux-leds, devicetree, linux-kernel, linux-doc Cc: llvm, oe-kbuild-all Hi Vicentiu, kernel test robot noticed the following build errors: [auto build test ERROR on lee-leds/for-leds-next] [also build test ERROR on robh/for-next linus/master v6.12-rc6 next-20241105] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Vicentiu-Galanopulo/dt-bindings-leds-Add-LED1202-LED-Controller/20241106-001305 base: https://git.kernel.org/pub/scm/linux/kernel/git/lee/leds.git for-leds-next patch link: https://lore.kernel.org/r/20241105161041.4813-3-vicentiu.galanopulo%40remote-tech.co.uk patch subject: [PATCH 3/3] [PATCH v5] leds: Add LED1202 I2C driver config: hexagon-allmodconfig (https://download.01.org/0day-ci/archive/20241106/202411060929.dw469eSa-lkp@intel.com/config) compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project 592c0fe55f6d9a811028b5f3507be91458ab2713) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241106/202411060929.dw469eSa-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202411060929.dw469eSa-lkp@intel.com/ All errors (new ones prefixed by >>): In file included from drivers/leds/leds-st1202.c:12: In file included from include/linux/i2c.h:19: In file included from include/linux/regulator/consumer.h:35: In file included from include/linux/suspend.h:5: In file included from include/linux/swap.h:9: In file included from include/linux/memcontrol.h:13: In file included from include/linux/cgroup.h:26: In file included from include/linux/kernel_stat.h:8: In file included from include/linux/interrupt.h:11: In file included from include/linux/hardirq.h:11: In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1: In file included from include/asm-generic/hardirq.h:17: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:14: In file included from arch/hexagon/include/asm/io.h:328: include/asm-generic/io.h:548:31: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 548 | val = __raw_readb(PCI_IOBASE + addr); | ~~~~~~~~~~ ^ include/asm-generic/io.h:561:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 561 | val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr)); | ~~~~~~~~~~ ^ include/uapi/linux/byteorder/little_endian.h:37:51: note: expanded from macro '__le16_to_cpu' 37 | #define __le16_to_cpu(x) ((__force __u16)(__le16)(x)) | ^ In file included from drivers/leds/leds-st1202.c:12: In file included from include/linux/i2c.h:19: In file included from include/linux/regulator/consumer.h:35: In file included from include/linux/suspend.h:5: In file included from include/linux/swap.h:9: In file included from include/linux/memcontrol.h:13: In file included from include/linux/cgroup.h:26: In file included from include/linux/kernel_stat.h:8: In file included from include/linux/interrupt.h:11: In file included from include/linux/hardirq.h:11: In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1: In file included from include/asm-generic/hardirq.h:17: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:14: In file included from arch/hexagon/include/asm/io.h:328: include/asm-generic/io.h:574:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 574 | val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr)); | ~~~~~~~~~~ ^ include/uapi/linux/byteorder/little_endian.h:35:51: note: expanded from macro '__le32_to_cpu' 35 | #define __le32_to_cpu(x) ((__force __u32)(__le32)(x)) | ^ In file included from drivers/leds/leds-st1202.c:12: In file included from include/linux/i2c.h:19: In file included from include/linux/regulator/consumer.h:35: In file included from include/linux/suspend.h:5: In file included from include/linux/swap.h:9: In file included from include/linux/memcontrol.h:13: In file included from include/linux/cgroup.h:26: In file included from include/linux/kernel_stat.h:8: In file included from include/linux/interrupt.h:11: In file included from include/linux/hardirq.h:11: In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1: In file included from include/asm-generic/hardirq.h:17: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:14: In file included from arch/hexagon/include/asm/io.h:328: include/asm-generic/io.h:585:33: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 585 | __raw_writeb(value, PCI_IOBASE + addr); | ~~~~~~~~~~ ^ include/asm-generic/io.h:595:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 595 | __raw_writew((u16 __force)cpu_to_le16(value), PCI_IOBASE + addr); | ~~~~~~~~~~ ^ include/asm-generic/io.h:605:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 605 | __raw_writel((u32 __force)cpu_to_le32(value), PCI_IOBASE + addr); | ~~~~~~~~~~ ^ In file included from drivers/leds/leds-st1202.c:12: In file included from include/linux/i2c.h:19: In file included from include/linux/regulator/consumer.h:35: In file included from include/linux/suspend.h:5: In file included from include/linux/swap.h:9: In file included from include/linux/memcontrol.h:21: In file included from include/linux/mm.h:2213: include/linux/vmstat.h:518:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] 518 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_" | ~~~~~~~~~~~ ^ ~~~ drivers/leds/leds-st1202.c:350:28: warning: missing terminating '"' character [-Winvalid-pp-token] 350 | dev_err_probe(dev, err, "Failed to register LED class dev, | ^ >> drivers/leds/leds-st1202.c:350:28: error: expected expression drivers/leds/leds-st1202.c:351:17: warning: missing terminating '"' character [-Winvalid-pp-token] 351 | error: %d\n", err); | ^ 9 warnings and 1 error generated. Kconfig warnings: (for reference only) WARNING: unmet direct dependencies detected for MODVERSIONS Depends on [n]: MODULES [=y] && !COMPILE_TEST [=y] Selected by [y]: - RANDSTRUCT_FULL [=y] && (CC_HAS_RANDSTRUCT [=y] || GCC_PLUGINS [=n]) && MODULES [=y] WARNING: unmet direct dependencies detected for GET_FREE_REGION Depends on [n]: SPARSEMEM [=n] Selected by [m]: - RESOURCE_KUNIT_TEST [=m] && RUNTIME_TESTING_MENU [=y] && KUNIT [=m] vim +350 drivers/leds/leds-st1202.c 318 319 static int st1202_dt_init(struct st1202_chip *chip) 320 { 321 struct device *dev = &chip->client->dev; 322 struct st1202_led *led; 323 int err, reg; 324 325 for_each_available_child_of_node_scoped(dev_of_node(dev), child) { 326 struct led_init_data init_data = {}; 327 328 err = of_property_read_u32(child, "reg", ®); 329 if (err) { 330 of_node_put(child); 331 return dev_err_probe(dev, err, "Invalid register, error: %d\n", err); 332 } 333 334 led = &chip->leds[reg]; 335 led->is_active = true; 336 led->fwnode = of_fwnode_handle(child); 337 338 led->led_cdev.max_brightness = U8_MAX; 339 led->led_cdev.brightness_set_blocking = st1202_led_set; 340 led->led_cdev.pattern_set = st1202_led_pattern_set; 341 led->led_cdev.pattern_clear = st1202_led_pattern_clear; 342 led->led_cdev.default_trigger = "pattern"; 343 344 init_data.fwnode = led->fwnode; 345 init_data.devicename = "st1202"; 346 init_data.default_label = ":"; 347 err = devm_led_classdev_register_ext(dev, 348 &led->led_cdev, &init_data); 349 if (err < 0) { > 350 dev_err_probe(dev, err, "Failed to register LED class dev, 351 error: %d\n", err); 352 return err; 353 } 354 led->led_cdev.brightness_set = st1202_brightness_set; 355 led->led_cdev.brightness_get = st1202_brightness_get; 356 } 357 358 return 0; 359 } 360 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-11-06 2:04 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-11-05 16:10 [PATCH 1/3] [PATCH v3] Documentation:leds: Add leds-st1202.rst Vicentiu Galanopulo 2024-11-05 16:10 ` [PATCH 2/3] [PATCH v4] dt-bindings: leds: Add LED1202 LED Controller Vicentiu Galanopulo 2024-11-05 16:10 ` [PATCH 3/3] [PATCH v5] leds: Add LED1202 I2C driver Vicentiu Galanopulo 2024-11-06 0:38 ` kernel test robot 2024-11-06 2:03 ` kernel test robot
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.