All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
Cc: oe-kbuild-all@lists.linux.dev, Florian Westphal <fw@strlen.de>,
	Nadia Pinaeva <n.m.pinaeva@gmail.com>,
	Pablo Neira Ayuso <pablo@netfilter.org>
Subject: Re: [PATCH nf-next] netfilter: conntrack: add conntrack event timestamp
Date: Fri, 8 Nov 2024 08:09:41 +0800	[thread overview]
Message-ID: <202411080731.bDRRTgah-lkp@intel.com> (raw)
In-Reply-To: <20241107194117.32116-1-fw@strlen.de>

Hi Florian,

kernel test robot noticed the following build warnings:

[auto build test WARNING on netfilter-nf/main]
[also build test WARNING on linus/master v6.12-rc6 next-20241107]
[cannot apply to nf-next/master horms-ipvs/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Florian-Westphal/netfilter-conntrack-add-conntrack-event-timestamp/20241108-034444
base:   https://git.kernel.org/pub/scm/linux/kernel/git/netfilter/nf.git main
patch link:    https://lore.kernel.org/r/20241107194117.32116-1-fw%40strlen.de
patch subject: [PATCH nf-next] netfilter: conntrack: add conntrack event timestamp
config: x86_64-defconfig (https://download.01.org/0day-ci/archive/20241108/202411080731.bDRRTgah-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-12) 11.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241108/202411080731.bDRRTgah-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411080731.bDRRTgah-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> net/netfilter/nf_conntrack_netlink.c:386:1: warning: 'ctnetlink_dump_event_timestamp' defined but not used [-Wunused-function]
     386 | ctnetlink_dump_event_timestamp(struct sk_buff *skb, const struct nf_conn *ct)
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/ctnetlink_dump_event_timestamp +386 net/netfilter/nf_conntrack_netlink.c

   384	
   385	static int
 > 386	ctnetlink_dump_event_timestamp(struct sk_buff *skb, const struct nf_conn *ct)
   387	{
   388	#ifdef CONFIG_NF_CONNTRACK_TIMESTAMP
   389		const struct nf_conntrack_ecache *e = nf_ct_ecache_find(ct);
   390	
   391		if (e) {
   392			u64 ts = local64_read(&e->timestamp);
   393	
   394			if (ts)
   395				return nla_put_be64(skb, CTA_TIMESTAMP_EVENT,
   396						    cpu_to_be64(ts), CTA_TIMESTAMP_PAD);
   397		}
   398	#endif
   399		return 0;
   400	}
   401	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

  reply	other threads:[~2024-11-08  0:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-07 19:41 [PATCH nf-next] netfilter: conntrack: add conntrack event timestamp Florian Westphal
2024-11-08  0:09 ` kernel test robot [this message]
2024-11-08  1:33 ` kernel test robot
2024-11-08  6:34 ` kernel test robot
2024-11-12 18:25 ` Florian Westphal
  -- strict thread matches above, loose matches on Subject: below --
2024-11-15 13:46 Florian Westphal
2025-01-07 15:53 ` Florian Westphal
2025-01-08 23:48   ` Pablo Neira Ayuso
2025-01-09  0:31     ` Florian Westphal
2025-01-09 10:25       ` Antonio Ojea

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202411080731.bDRRTgah-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=fw@strlen.de \
    --cc=n.m.pinaeva@gmail.com \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.