* [PATCH] arm: dts: aspeed: Blueridge and Rainer: Add VRM presence GPIOs
@ 2024-11-08 14:58 Eddie James
2024-11-10 23:45 ` Andrew Jeffery
0 siblings, 1 reply; 3+ messages in thread
From: Eddie James @ 2024-11-08 14:58 UTC (permalink / raw)
To: linux-aspeed
Cc: andrew, joel, robh, krzk+dt, conor+dt, devicetree, linux-kernel,
Eddie James
Add GPIO line names to the GPIO expander to describe DCM and
VRM presence detection lines.
Signed-off-by: Eddie James <eajames@linux.ibm.com>
---
arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-blueridge.dts | 4 ++--
arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier.dts | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-blueridge.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-blueridge.dts
index 5f9a46c2abb8..d504ae84db89 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-blueridge.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-blueridge.dts
@@ -1232,8 +1232,8 @@ led-controller@60 {
#gpio-cells = <2>;
gpio-line-names =
- "", "", "", "", "", "", "", "",
- "", "", "", "", "", "", "power-config-full-load", "";
+ "", "", "", "", "", "", "P10_DCM0_PRES", "P10_DCM1_PRES",
+ "", "", "", "", "PRESENT_VRM_DCM0_N", "PRESENT_VRM_DCM1_N", "power-config-full-load", "";
};
led-controller@61 {
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier.dts
index a4aec3010456..eefc69d0d032 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier.dts
@@ -1280,8 +1280,8 @@ pca_pres3: pca9552@60 {
#gpio-cells = <2>;
gpio-line-names =
- "", "", "", "", "", "", "", "",
- "", "", "", "", "", "", "power-config-full-load", "";
+ "", "", "", "", "", "", "P10_DCM0_PRES", "P10_DCM1_PRES",
+ "", "", "", "", "PRESENT_VRM_DCM0_N", "PRESENT_VRM_DCM1_N", "power-config-full-load", "";
};
pca_pres2: pca9552@61 {
--
2.43.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] arm: dts: aspeed: Blueridge and Rainer: Add VRM presence GPIOs
2024-11-08 14:58 [PATCH] arm: dts: aspeed: Blueridge and Rainer: Add VRM presence GPIOs Eddie James
@ 2024-11-10 23:45 ` Andrew Jeffery
2024-11-12 20:46 ` Eddie James
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Jeffery @ 2024-11-10 23:45 UTC (permalink / raw)
To: Eddie James, linux-aspeed
Cc: joel, robh, krzk+dt, conor+dt, devicetree, linux-kernel
On Fri, 2024-11-08 at 08:58 -0600, Eddie James wrote:
> Add GPIO line names to the GPIO expander to describe DCM and
> VRM presence detection lines.
>
> Signed-off-by: Eddie James <eajames@linux.ibm.com>
> ---
> arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-blueridge.dts | 4 ++--
> arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier.dts | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-blueridge.dts
> b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-blueridge.dts
> index 5f9a46c2abb8..d504ae84db89 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-blueridge.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-blueridge.dts
> @@ -1232,8 +1232,8 @@ led-controller@60 {
> #gpio-cells = <2>;
>
> gpio-line-names =
> - "", "", "", "", "", "", "", "",
> - "", "", "", "", "", "", "power-config-full-
> load", "";
> + "", "", "", "", "", "", "P10_DCM0_PRES",
> "P10_DCM1_PRES",
> + "", "", "", "", "PRESENT_VRM_DCM0_N",
> "PRESENT_VRM_DCM1_N", "power-config-full-load", "";
> };
This ends up generating checkpatch warnings about long lines when I
apply it.
I did a quick, incomplete and random survey of some other devicetrees,
and perhaps exploding out like in [1] might help.
[1]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d85b2ad35a2ab
>
> led-controller@61 {
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier.dts
> b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier.dts
> index a4aec3010456..eefc69d0d032 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier.dts
> @@ -1280,8 +1280,8 @@ pca_pres3: pca9552@60 {
> #gpio-cells = <2>;
>
> gpio-line-names =
> - "", "", "", "", "", "", "", "",
> - "", "", "", "", "", "", "power-config-full-
> load", "";
> + "", "", "", "", "", "", "P10_DCM0_PRES",
> "P10_DCM1_PRES",
> + "", "", "", "", "PRESENT_VRM_DCM0_N",
> "PRESENT_VRM_DCM1_N", "power-config-full-load", "";
Similarly here.
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] arm: dts: aspeed: Blueridge and Rainer: Add VRM presence GPIOs
2024-11-10 23:45 ` Andrew Jeffery
@ 2024-11-12 20:46 ` Eddie James
0 siblings, 0 replies; 3+ messages in thread
From: Eddie James @ 2024-11-12 20:46 UTC (permalink / raw)
To: Andrew Jeffery, linux-aspeed
Cc: joel, robh, krzk+dt, conor+dt, devicetree, linux-kernel
On 11/10/24 17:45, Andrew Jeffery wrote:
> On Fri, 2024-11-08 at 08:58 -0600, Eddie James wrote:
>> Add GPIO line names to the GPIO expander to describe DCM and
>> VRM presence detection lines.
>>
>> Signed-off-by: Eddie James <eajames@linux.ibm.com>
>> ---
>> arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-blueridge.dts | 4 ++--
>> arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier.dts | 4 ++--
>> 2 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-blueridge.dts
>> b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-blueridge.dts
>> index 5f9a46c2abb8..d504ae84db89 100644
>> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-blueridge.dts
>> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-blueridge.dts
>> @@ -1232,8 +1232,8 @@ led-controller@60 {
>> #gpio-cells = <2>;
>>
>> gpio-line-names =
>> - "", "", "", "", "", "", "", "",
>> - "", "", "", "", "", "", "power-config-full-
>> load", "";
>> + "", "", "", "", "", "", "P10_DCM0_PRES",
>> "P10_DCM1_PRES",
>> + "", "", "", "", "PRESENT_VRM_DCM0_N",
>> "PRESENT_VRM_DCM1_N", "power-config-full-load", "";
>> };
> This ends up generating checkpatch warnings about long lines when I
> apply it.
>
> I did a quick, incomplete and random survey of some other devicetrees,
> and perhaps exploding out like in [1] might help.
>
> [1]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d85b2ad35a2ab
Oh, oops, sure thing.
Thanks,
Eddie
>
>>
>> led-controller@61 {
>> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier.dts
>> b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier.dts
>> index a4aec3010456..eefc69d0d032 100644
>> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier.dts
>> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier.dts
>> @@ -1280,8 +1280,8 @@ pca_pres3: pca9552@60 {
>> #gpio-cells = <2>;
>>
>> gpio-line-names =
>> - "", "", "", "", "", "", "", "",
>> - "", "", "", "", "", "", "power-config-full-
>> load", "";
>> + "", "", "", "", "", "", "P10_DCM0_PRES",
>> "P10_DCM1_PRES",
>> + "", "", "", "", "PRESENT_VRM_DCM0_N",
>> "PRESENT_VRM_DCM1_N", "power-config-full-load", "";
> Similarly here.
>
> Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-11-12 20:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-08 14:58 [PATCH] arm: dts: aspeed: Blueridge and Rainer: Add VRM presence GPIOs Eddie James
2024-11-10 23:45 ` Andrew Jeffery
2024-11-12 20:46 ` Eddie James
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.