Re: [Buildroot] [PATCH 1/1] package/libvpl: not supported on mips64

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Bernd Kuhls <bernd@kuhls.net>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/libvpl: not supported on mips64
Date: Sun, 10 Nov 2024 18:13:34 +0100	[thread overview]
Message-ID: <20241110181334.0746f1a8@windsurf> (raw)
In-Reply-To: <20241110103624.1041337-1-bernd@kuhls.net>

Hello Bernd,

On Sun, 10 Nov 2024 11:36:24 +0100
Bernd Kuhls <bernd@kuhls.net> wrote:

> diff --git a/package/libvpl/Config.in b/package/libvpl/Config.in
> index b9e9a20fd7..5a370ed2e3 100644
> --- a/package/libvpl/Config.in
> +++ b/package/libvpl/Config.in
> @@ -1,6 +1,6 @@
>  config BR2_PACKAGE_LIBVPL_ARCH_SUPPORTS
>  	bool
> -	default y if BR2_ARCH_IS_64
> +	default y if BR2_ARCH_IS_64 && !BR2_mips64 && !BR2_mips64el
>  	default y if BR2_arm

Thanks for the fix. However, would it be possible to do something a bit
more consistent with what the code does?

#if defined(_WIN64) || defined(__LP64__)
    #define MFX_PACK_BEGIN_STRUCT_W_PTR()    MFX_PACK_BEGIN_X(8)
    #define MFX_PACK_BEGIN_STRUCT_W_L_TYPE() MFX_PACK_BEGIN_X(8)
/* 32-bit ILP32 data model Windows* (Intel(r) architecture) */
#elif defined(_WIN32) || defined(_M_IX86) && !defined(__linux__)
    #define MFX_PACK_BEGIN_STRUCT_W_PTR()    MFX_PACK_BEGIN_X(4)
    #define MFX_PACK_BEGIN_STRUCT_W_L_TYPE() MFX_PACK_BEGIN_X(8)
/* 32-bit ILP32 data model Linux* */
#elif defined(__ILP32__) || defined(__arm__)
    #define MFX_PACK_BEGIN_STRUCT_W_PTR()    MFX_PACK_BEGIN_X(4)
    #define MFX_PACK_BEGIN_STRUCT_W_L_TYPE() MFX_PACK_BEGIN_X(4)

So in our case, the code works on:

- Architectures that define __LP64__
- Architectures that define __ILP32__
- Architectures that define __arm__

Currently we only enable for 64-bit architectures and ARM, but other
32-bit architectures are also supported (the ones that define
__ILP32__).

This can easily be checked by looking at the built-in cross-compiler
defines:

$ ARCH-linux-gcc -dM -E - < /dev/null | grep -E "(LP|ILP)"

For example, it looks like i386 would be supported.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot