[Buildroot] [PATCH 1/1] package/libvpl: not supported on mips64

[Buildroot] [PATCH 1/1] package/libvpl: not supported on mips64

[Bernd Kuhls]

Although adding " || defined(__mips__)" here:
https://github.com/intel/libvpl/blob/main/api/vpl/mfxdefs.h#L71

would fix the problem, libvpl alone makes no sense and the only
dependee, intel-vpl-gpu-rt, is unsupported on mips anyway.

Fixes:
http://autobuild.buildroot.net/results/50d/50d64ab2d547c70b39e2421ee2763d8309873125/

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
 package/libvpl/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/libvpl/Config.in b/package/libvpl/Config.in
index b9e9a20fd7..5a370ed2e3 100644
--- a/package/libvpl/Config.in
+++ b/package/libvpl/Config.in
@@ -1,6 +1,6 @@
 config BR2_PACKAGE_LIBVPL_ARCH_SUPPORTS
 	bool
-	default y if BR2_ARCH_IS_64
+	default y if BR2_ARCH_IS_64 && !BR2_mips64 && !BR2_mips64el
 	default y if BR2_arm
 
 config BR2_PACKAGE_LIBVPL
-- 
2.39.5

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/libvpl: not supported on mips64

[Thomas Petazzoni via buildroot]

Hello Bernd,

On Sun, 10 Nov 2024 11:36:24 +0100
Bernd Kuhls <bernd@kuhls.net> wrote:

> diff --git a/package/libvpl/Config.in b/package/libvpl/Config.in
> index b9e9a20fd7..5a370ed2e3 100644
> --- a/package/libvpl/Config.in
> +++ b/package/libvpl/Config.in
> @@ -1,6 +1,6 @@
>  config BR2_PACKAGE_LIBVPL_ARCH_SUPPORTS
>  	bool
> -	default y if BR2_ARCH_IS_64
> +	default y if BR2_ARCH_IS_64 && !BR2_mips64 && !BR2_mips64el
>  	default y if BR2_arm

Thanks for the fix. However, would it be possible to do something a bit
more consistent with what the code does?

#if defined(_WIN64) || defined(__LP64__)
    #define MFX_PACK_BEGIN_STRUCT_W_PTR()    MFX_PACK_BEGIN_X(8)
    #define MFX_PACK_BEGIN_STRUCT_W_L_TYPE() MFX_PACK_BEGIN_X(8)
/* 32-bit ILP32 data model Windows* (Intel(r) architecture) */
#elif defined(_WIN32) || defined(_M_IX86) && !defined(__linux__)
    #define MFX_PACK_BEGIN_STRUCT_W_PTR()    MFX_PACK_BEGIN_X(4)
    #define MFX_PACK_BEGIN_STRUCT_W_L_TYPE() MFX_PACK_BEGIN_X(8)
/* 32-bit ILP32 data model Linux* */
#elif defined(__ILP32__) || defined(__arm__)
    #define MFX_PACK_BEGIN_STRUCT_W_PTR()    MFX_PACK_BEGIN_X(4)
    #define MFX_PACK_BEGIN_STRUCT_W_L_TYPE() MFX_PACK_BEGIN_X(4)

So in our case, the code works on:

- Architectures that define __LP64__
- Architectures that define __ILP32__
- Architectures that define __arm__

Currently we only enable for 64-bit architectures and ARM, but other
32-bit architectures are also supported (the ones that define
__ILP32__).

This can easily be checked by looking at the built-in cross-compiler
defines:

$ ARCH-linux-gcc -dM -E - < /dev/null | grep -E "(LP|ILP)"

For example, it looks like i386 would be supported.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/libvpl: not supported on mips64

[Bernd Kuhls]

Am Sun, 10 Nov 2024 18:13:34 +0100 schrieb Thomas Petazzoni via buildroot:

> $ ARCH-linux-gcc -dM -E - < /dev/null | grep -E "(LP|ILP)"
> 
> For example, it looks like i386 would be supported.

Hi Thomas,

tested a defconfig based on support/config-fragments/autobuild/br-i386-
pentium4-full.config

BR2_x86_pentium4=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_TOOLCHAIN_EXTERNAL_CUSTOM=y
BR2_TOOLCHAIN_EXTERNAL_DOWNLOAD=y
BR2_TOOLCHAIN_EXTERNAL_URL="http://autobuild.buildroot.org/toolchains/
tarballs/br-i386-pentium4-full-2020.11.2.tar.bz2"
BR2_TOOLCHAIN_EXTERNAL_GCC_9=y
BR2_TOOLCHAIN_EXTERNAL_HEADERS_4_4=y
BR2_TOOLCHAIN_EXTERNAL_LOCALE=y
# BR2_TOOLCHAIN_EXTERNAL_HAS_THREADS_DEBUG is not set
BR2_TOOLCHAIN_EXTERNAL_CXX=y
BR2_PACKAGE_LIBVPL=y

libvpl build is broken:

output/build/libvpl-2.13.0/api/vpl/mfxdefs.h:75:6: error: #error Unknown 
packing
   75 |     #error Unknown packing

because the compiler does not define __ILP32__

$ i686-linux-gcc -dM -E - < /dev/null | grep -E "(LP|ILP)"
$ 

The same is valid for support/config-fragments/autobuild/bootlin-riscv32-
glibc.config

$ riscv32-linux-gcc  -dM -E - < /dev/null | grep -E "(LP|ILP)"
$ 

I did not test other 32bit platforms because the only dependee of libvpl, 
intel-vpl-gpu-rt, is unsupported on 32bit archs anyway.

Regards, Bernd

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/libvpl: not supported on mips64

[Arnout Vandecappelle via buildroot]

On 10/11/2024 11:36, Bernd Kuhls wrote:
> Although adding " || defined(__mips__)" here:
> https://github.com/intel/libvpl/blob/main/api/vpl/mfxdefs.h#L71
> 
> would fix the problem, libvpl alone makes no sense and the only
> dependee, intel-vpl-gpu-rt, is unsupported on mips anyway.
> 
> Fixes:
> http://autobuild.buildroot.net/results/50d/50d64ab2d547c70b39e2421ee2763d8309873125/
> 
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>

  Applied to master, thanks.

  Regards,
  Arnout

> ---
>   package/libvpl/Config.in | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/libvpl/Config.in b/package/libvpl/Config.in

> index b9e9a20fd7..5a370ed2e3 100644
> --- a/package/libvpl/Config.in
> +++ b/package/libvpl/Config.in
> @@ -1,6 +1,6 @@
>   config BR2_PACKAGE_LIBVPL_ARCH_SUPPORTS
>   	bool
> -	default y if BR2_ARCH_IS_64
> +	default y if BR2_ARCH_IS_64 && !BR2_mips64 && !BR2_mips64el
>   	default y if BR2_arm
>   
>   config BR2_PACKAGE_LIBVPL

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/libvpl: not supported on mips64

[Peter Korsgaard]

>>>>> "Bernd" == Bernd Kuhls <bernd@kuhls.net> writes:

 > Although adding " || defined(__mips__)" here:
 > https://github.com/intel/libvpl/blob/main/api/vpl/mfxdefs.h#L71

 > would fix the problem, libvpl alone makes no sense and the only
 > dependee, intel-vpl-gpu-rt, is unsupported on mips anyway.

 > Fixes:
 > http://autobuild.buildroot.net/results/50d/50d64ab2d547c70b39e2421ee2763d8309873125/

 > Signed-off-by: Bernd Kuhls <bernd@kuhls.net>

Committed to 2024.02.x and 2024.08.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot