From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Julia Lawall <julia.lawall@inria.fr>
Subject: drivers/md/md-bitmap.c:2892:31-48: opportunity for str_false_true(bitmap -> need_sync)
Date: Mon, 11 Nov 2024 00:53:59 +0800 [thread overview]
Message-ID: <202411110015.MDaB5V8P-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Yu Kuai <yukuai3@huawei.com>
CC: Song Liu <song@kernel.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: de2f378f2b771b39594c04695feee86476743a69
commit: 59fdd43304f4cbb7ee8e281ca337afd803c309f6 md/md-bitmap: make in memory structure internal
date: 3 months ago
:::::: branch date: 20 hours ago
:::::: commit date: 3 months ago
config: csky-randconfig-r061-20241110 (https://download.01.org/0day-ci/archive/20241111/202411110015.MDaB5V8P-lkp@intel.com/config)
compiler: csky-linux-gcc (GCC) 14.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Julia Lawall <julia.lawall@inria.fr>
| Closes: https://lore.kernel.org/r/202411110015.MDaB5V8P-lkp@intel.com/
cocci warnings: (new ones prefixed by >>)
>> drivers/md/md-bitmap.c:2892:31-48: opportunity for str_false_true(bitmap -> need_sync)
vim +2892 drivers/md/md-bitmap.c
ece5cff0da9e69 drivers/md/bitmap.c NeilBrown 2009-12-14 2883
fd01b88c75a718 drivers/md/bitmap.c NeilBrown 2011-10-11 2884 static ssize_t can_clear_show(struct mddev *mddev, char *page)
ece5cff0da9e69 drivers/md/bitmap.c NeilBrown 2009-12-14 2885 {
ece5cff0da9e69 drivers/md/bitmap.c NeilBrown 2009-12-14 2886 int len;
59fdd43304f4cb drivers/md/md-bitmap.c Yu Kuai 2024-08-26 2887 struct bitmap *bitmap;
59fdd43304f4cb drivers/md/md-bitmap.c Yu Kuai 2024-08-26 2888
b7b17c9b67e598 drivers/md/bitmap.c NeilBrown 2014-12-15 2889 spin_lock(&mddev->lock);
59fdd43304f4cb drivers/md/md-bitmap.c Yu Kuai 2024-08-26 2890 bitmap = mddev->bitmap;
59fdd43304f4cb drivers/md/md-bitmap.c Yu Kuai 2024-08-26 2891 if (bitmap)
59fdd43304f4cb drivers/md/md-bitmap.c Yu Kuai 2024-08-26 @2892 len = sprintf(page, "%s\n", (bitmap->need_sync ? "false" :
59fdd43304f4cb drivers/md/md-bitmap.c Yu Kuai 2024-08-26 2893 "true"));
ece5cff0da9e69 drivers/md/bitmap.c NeilBrown 2009-12-14 2894 else
ece5cff0da9e69 drivers/md/bitmap.c NeilBrown 2009-12-14 2895 len = sprintf(page, "\n");
b7b17c9b67e598 drivers/md/bitmap.c NeilBrown 2014-12-15 2896 spin_unlock(&mddev->lock);
ece5cff0da9e69 drivers/md/bitmap.c NeilBrown 2009-12-14 2897 return len;
ece5cff0da9e69 drivers/md/bitmap.c NeilBrown 2009-12-14 2898 }
ece5cff0da9e69 drivers/md/bitmap.c NeilBrown 2009-12-14 2899
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2024-11-10 16:54 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202411110015.MDaB5V8P-lkp@intel.com \
--to=lkp@intel.com \
--cc=julia.lawall@inria.fr \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.