drivers/md/md-bitmap.c:2892:31-48: opportunity for str_false_true(bitmap -> need_sync)

drivers/md/md-bitmap.c:2892:31-48: opportunity for str_false_true(bitmap -> need_sync)

[kernel test robot]

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Yu Kuai <yukuai3@huawei.com>
CC: Song Liu <song@kernel.org>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   de2f378f2b771b39594c04695feee86476743a69
commit: 59fdd43304f4cbb7ee8e281ca337afd803c309f6 md/md-bitmap: make in memory structure internal
date:   3 months ago
:::::: branch date: 20 hours ago
:::::: commit date: 3 months ago
config: csky-randconfig-r061-20241110 (https://download.01.org/0day-ci/archive/20241111/202411110015.MDaB5V8P-lkp@intel.com/config)
compiler: csky-linux-gcc (GCC) 14.2.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Julia Lawall <julia.lawall@inria.fr>
| Closes: https://lore.kernel.org/r/202411110015.MDaB5V8P-lkp@intel.com/

cocci warnings: (new ones prefixed by >>)
>> drivers/md/md-bitmap.c:2892:31-48: opportunity for str_false_true(bitmap -> need_sync)

vim +2892 drivers/md/md-bitmap.c

ece5cff0da9e69 drivers/md/bitmap.c    NeilBrown 2009-12-14  2883  
fd01b88c75a718 drivers/md/bitmap.c    NeilBrown 2011-10-11  2884  static ssize_t can_clear_show(struct mddev *mddev, char *page)
ece5cff0da9e69 drivers/md/bitmap.c    NeilBrown 2009-12-14  2885  {
ece5cff0da9e69 drivers/md/bitmap.c    NeilBrown 2009-12-14  2886  	int len;
59fdd43304f4cb drivers/md/md-bitmap.c Yu Kuai   2024-08-26  2887  	struct bitmap *bitmap;
59fdd43304f4cb drivers/md/md-bitmap.c Yu Kuai   2024-08-26  2888  
b7b17c9b67e598 drivers/md/bitmap.c    NeilBrown 2014-12-15  2889  	spin_lock(&mddev->lock);
59fdd43304f4cb drivers/md/md-bitmap.c Yu Kuai   2024-08-26  2890  	bitmap = mddev->bitmap;
59fdd43304f4cb drivers/md/md-bitmap.c Yu Kuai   2024-08-26  2891  	if (bitmap)
59fdd43304f4cb drivers/md/md-bitmap.c Yu Kuai   2024-08-26 @2892  		len = sprintf(page, "%s\n", (bitmap->need_sync ? "false" :
59fdd43304f4cb drivers/md/md-bitmap.c Yu Kuai   2024-08-26  2893  								 "true"));
ece5cff0da9e69 drivers/md/bitmap.c    NeilBrown 2009-12-14  2894  	else
ece5cff0da9e69 drivers/md/bitmap.c    NeilBrown 2009-12-14  2895  		len = sprintf(page, "\n");
b7b17c9b67e598 drivers/md/bitmap.c    NeilBrown 2014-12-15  2896  	spin_unlock(&mddev->lock);
ece5cff0da9e69 drivers/md/bitmap.c    NeilBrown 2009-12-14  2897  	return len;
ece5cff0da9e69 drivers/md/bitmap.c    NeilBrown 2009-12-14  2898  }
ece5cff0da9e69 drivers/md/bitmap.c    NeilBrown 2009-12-14  2899  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki