From: Jakub Kicinski <kuba@kernel.org>
To: Ahmed Zaki <ahmed.zaki@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
Sudheer Mogilappagari <sudheer.mogilappagari@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-net 1/2] idpf: preserve IRQ affinity settings across resets
Date: Mon, 11 Nov 2024 18:53:34 -0800 [thread overview]
Message-ID: <20241111185334.447a5253@kernel.org> (raw)
In-Reply-To: <20241109001206.213581-2-ahmed.zaki@intel.com>
On Fri, 8 Nov 2024 17:12:05 -0700 Ahmed Zaki wrote:
> From: Sudheer Mogilappagari <sudheer.mogilappagari@intel.com>
>
> Currently the IRQ affinity settings are getting lost when interface
> goes through a soft reset (due to MTU configuration, changing number
> of queues etc). Use irq_set_affinity_notifier() callbacks to keep
> the IRQ affinity info in sync between driver and kernel.
Could you try doing this in the core? Store the mask in napi_struct
if it has IRQ associated with it?
Barely any drivers get this right.
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Ahmed Zaki <ahmed.zaki@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
Sudheer Mogilappagari <sudheer.mogilappagari@intel.com>
Subject: Re: [PATCH iwl-net 1/2] idpf: preserve IRQ affinity settings across resets
Date: Mon, 11 Nov 2024 18:53:34 -0800 [thread overview]
Message-ID: <20241111185334.447a5253@kernel.org> (raw)
In-Reply-To: <20241109001206.213581-2-ahmed.zaki@intel.com>
On Fri, 8 Nov 2024 17:12:05 -0700 Ahmed Zaki wrote:
> From: Sudheer Mogilappagari <sudheer.mogilappagari@intel.com>
>
> Currently the IRQ affinity settings are getting lost when interface
> goes through a soft reset (due to MTU configuration, changing number
> of queues etc). Use irq_set_affinity_notifier() callbacks to keep
> the IRQ affinity info in sync between driver and kernel.
Could you try doing this in the core? Store the mask in napi_struct
if it has IRQ associated with it?
Barely any drivers get this right.
next prev parent reply other threads:[~2024-11-12 2:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-09 0:12 [Intel-wired-lan] [PATCH iwl-net 0/2] idpf: Preserve IRQ affinity and sync IRQ Ahmed Zaki
2024-11-09 0:12 ` Ahmed Zaki
2024-11-09 0:12 ` [Intel-wired-lan] [PATCH iwl-net 1/2] idpf: preserve IRQ affinity settings across resets Ahmed Zaki
2024-11-09 0:12 ` Ahmed Zaki
2024-11-12 2:53 ` Jakub Kicinski [this message]
2024-11-12 2:53 ` Jakub Kicinski
2024-12-02 13:03 ` [Intel-wired-lan] " Ahmed Zaki
2024-12-02 13:03 ` Ahmed Zaki
2024-12-02 14:26 ` [Intel-wired-lan] " Jakub Kicinski
2024-12-02 14:26 ` Jakub Kicinski
2024-11-09 0:12 ` [Intel-wired-lan] [PATCH iwl-net 2/2] idpf: finish pending IRQ handling before freeing interrupt Ahmed Zaki
2024-11-09 0:12 ` Ahmed Zaki
2024-11-12 2:54 ` [Intel-wired-lan] " Jakub Kicinski
2024-11-12 2:54 ` Jakub Kicinski
2024-12-02 13:11 ` [Intel-wired-lan] " Ahmed Zaki
2024-12-02 13:11 ` Ahmed Zaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241111185334.447a5253@kernel.org \
--to=kuba@kernel.org \
--cc=ahmed.zaki@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=netdev@vger.kernel.org \
--cc=sudheer.mogilappagari@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.