From: Rob Herring <robh@kernel.org>
To: Frank Wunderlich <linux@fw-web.de>
Cc: Mark Brown <broonie@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Frank Wunderlich <frank-w@public-files.de>,
Leilk Liu <leilk.liu@mediatek.com>,
linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] dt-bindings: spi: add compatibles for mt7988
Date: Mon, 11 Nov 2024 14:38:03 -0600 [thread overview]
Message-ID: <20241111203803.GA1917413-robh@kernel.org> (raw)
In-Reply-To: <20241109105029.52748-1-linux@fw-web.de>
On Sat, Nov 09, 2024 at 11:50:28AM +0100, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
>
> MT7988 has 2 different spi controllers. Add their compatibles.
>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> ---
> Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml b/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
> index e1f5bfa4433c..ed17815263a8 100644
> --- a/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
> +++ b/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
> @@ -35,6 +35,8 @@ properties:
> - enum:
> - mediatek,mt7981-spi-ipm
> - mediatek,mt7986-spi-ipm
> + - mediatek,mt7988-spi-quad
> + - mediatek,mt7988-spi-single
> - mediatek,mt8188-spi-ipm
> - const: mediatek,spi-ipm
Does the fallback make sense for both? Is there some common subset of
functionality where they are the same?
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Frank Wunderlich <linux@fw-web.de>
Cc: devicetree@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
Leilk Liu <leilk.liu@mediatek.com>,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
Mark Brown <broonie@kernel.org>,
linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Subject: Re: [PATCH] dt-bindings: spi: add compatibles for mt7988
Date: Mon, 11 Nov 2024 14:38:03 -0600 [thread overview]
Message-ID: <20241111203803.GA1917413-robh@kernel.org> (raw)
In-Reply-To: <20241109105029.52748-1-linux@fw-web.de>
On Sat, Nov 09, 2024 at 11:50:28AM +0100, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
>
> MT7988 has 2 different spi controllers. Add their compatibles.
>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> ---
> Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml b/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
> index e1f5bfa4433c..ed17815263a8 100644
> --- a/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
> +++ b/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
> @@ -35,6 +35,8 @@ properties:
> - enum:
> - mediatek,mt7981-spi-ipm
> - mediatek,mt7986-spi-ipm
> + - mediatek,mt7988-spi-quad
> + - mediatek,mt7988-spi-single
> - mediatek,mt8188-spi-ipm
> - const: mediatek,spi-ipm
Does the fallback make sense for both? Is there some common subset of
functionality where they are the same?
Rob
next prev parent reply other threads:[~2024-11-11 20:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-09 10:50 [PATCH] dt-bindings: spi: add compatibles for mt7988 Frank Wunderlich
2024-11-09 10:50 ` Frank Wunderlich
2024-11-11 19:45 ` Conor Dooley
2024-11-11 19:45 ` Conor Dooley
2024-11-11 20:38 ` Rob Herring [this message]
2024-11-11 20:38 ` Rob Herring
2024-11-11 21:41 ` Aw: " Frank Wunderlich
2025-03-14 15:53 ` Mark Brown
2025-03-14 15:53 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241111203803.GA1917413-robh@kernel.org \
--to=robh@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frank-w@public-files.de \
--cc=krzk+dt@kernel.org \
--cc=leilk.liu@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux@fw-web.de \
--cc=matthias.bgg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.