* [PATCH] ceph: Use str_true_false() helper in status_show()
@ 2024-11-12 21:14 Thorsten Blum
2024-11-18 14:19 ` Ilya Dryomov
0 siblings, 1 reply; 2+ messages in thread
From: Thorsten Blum @ 2024-11-12 21:14 UTC (permalink / raw)
To: Xiubo Li, Ilya Dryomov; +Cc: Thorsten Blum, ceph-devel, linux-kernel
Remove hard-coded strings by using the str_true_false() helper function.
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
fs/ceph/debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ceph/debugfs.c b/fs/ceph/debugfs.c
index 24c08078f5aa..fdf9dc15eafa 100644
--- a/fs/ceph/debugfs.c
+++ b/fs/ceph/debugfs.c
@@ -357,7 +357,7 @@ static int status_show(struct seq_file *s, void *p)
seq_printf(s, "instance: %s.%lld %s/%u\n", ENTITY_NAME(inst->name),
ceph_pr_addr(client_addr), le32_to_cpu(client_addr->nonce));
- seq_printf(s, "blocklisted: %s\n", fsc->blocklisted ? "true" : "false");
+ seq_printf(s, "blocklisted: %s\n", str_true_false(fsc->blocklisted));
return 0;
}
--
2.47.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ceph: Use str_true_false() helper in status_show()
2024-11-12 21:14 [PATCH] ceph: Use str_true_false() helper in status_show() Thorsten Blum
@ 2024-11-18 14:19 ` Ilya Dryomov
0 siblings, 0 replies; 2+ messages in thread
From: Ilya Dryomov @ 2024-11-18 14:19 UTC (permalink / raw)
To: Thorsten Blum; +Cc: Xiubo Li, ceph-devel, linux-kernel
On Tue, Nov 12, 2024 at 10:16 PM Thorsten Blum <thorsten.blum@linux.dev> wrote:
>
> Remove hard-coded strings by using the str_true_false() helper function.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
> fs/ceph/debugfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ceph/debugfs.c b/fs/ceph/debugfs.c
> index 24c08078f5aa..fdf9dc15eafa 100644
> --- a/fs/ceph/debugfs.c
> +++ b/fs/ceph/debugfs.c
> @@ -357,7 +357,7 @@ static int status_show(struct seq_file *s, void *p)
>
> seq_printf(s, "instance: %s.%lld %s/%u\n", ENTITY_NAME(inst->name),
> ceph_pr_addr(client_addr), le32_to_cpu(client_addr->nonce));
> - seq_printf(s, "blocklisted: %s\n", fsc->blocklisted ? "true" : "false");
> + seq_printf(s, "blocklisted: %s\n", str_true_false(fsc->blocklisted));
>
> return 0;
> }
> --
> 2.47.0
>
Applied.
Thanks,
Ilya
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-11-18 14:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-12 21:14 [PATCH] ceph: Use str_true_false() helper in status_show() Thorsten Blum
2024-11-18 14:19 ` Ilya Dryomov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.