All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
To: intel-wired-lan@lists.osuosl.org
Cc: pmenzel@molgen.mpg.de, wojciech.drewek@intel.com,
	marcin.szycik@intel.com, netdev@vger.kernel.org,
	rafal.romanowski@intel.com, konrad.knitter@intel.com,
	pawel.chmielewski@intel.com, horms@kernel.org,
	David.Laight@ACULAB.COM, nex.sw.ncis.nat.hpm.dev@intel.com,
	pio.raczynski@gmail.com, sridhar.samudrala@intel.com,
	jacob.e.keller@intel.com, jiri@resnulli.us,
	przemyslaw.kitszel@intel.com
Subject: [Intel-wired-lan] [PATCH 8/8] ice: init flow director before RDMA
Date: Thu, 14 Nov 2024 13:18:40 +0100	[thread overview]
Message-ID: <20241114122009.97416-9-michal.swiatkowski@linux.intel.com> (raw)
In-Reply-To: <20241114122009.97416-1-michal.swiatkowski@linux.intel.com>

Flow director needs only one MSI-X. Load it before RDMA to save MSI-X
for it.

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
---
 drivers/net/ethernet/intel/ice/ice_main.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
index a6f586f9bfd1..b6997481fd42 100644
--- a/drivers/net/ethernet/intel/ice/ice_main.c
+++ b/drivers/net/ethernet/intel/ice/ice_main.c
@@ -5175,11 +5175,12 @@ int ice_load(struct ice_pf *pf)
 
 	ice_napi_add(vsi);
 
+	ice_init_features(pf);
+
 	err = ice_init_rdma(pf);
 	if (err)
 		goto err_init_rdma;
 
-	ice_init_features(pf);
 	ice_service_task_restart(pf);
 
 	clear_bit(ICE_DOWN, pf->state);
@@ -5187,6 +5188,7 @@ int ice_load(struct ice_pf *pf)
 	return 0;
 
 err_init_rdma:
+	ice_deinit_features(pf);
 	ice_tc_indir_block_unregister(vsi);
 err_tc_indir_block_register:
 	ice_unregister_netdev(vsi);
@@ -5210,8 +5212,8 @@ void ice_unload(struct ice_pf *pf)
 
 	devl_assert_locked(priv_to_devlink(pf));
 
-	ice_deinit_features(pf);
 	ice_deinit_rdma(pf);
+	ice_deinit_features(pf);
 	ice_tc_indir_block_unregister(vsi);
 	ice_unregister_netdev(vsi);
 	ice_devlink_destroy_pf_port(pf);
-- 
2.42.0


WARNING: multiple messages have this Message-ID (diff)
From: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
To: intel-wired-lan@lists.osuosl.org
Cc: netdev@vger.kernel.org, pawel.chmielewski@intel.com,
	sridhar.samudrala@intel.com, jacob.e.keller@intel.com,
	pio.raczynski@gmail.com, konrad.knitter@intel.com,
	marcin.szycik@intel.com, wojciech.drewek@intel.com,
	nex.sw.ncis.nat.hpm.dev@intel.com, przemyslaw.kitszel@intel.com,
	jiri@resnulli.us, horms@kernel.org, David.Laight@ACULAB.COM,
	pmenzel@molgen.mpg.de, mschmidt@redhat.com,
	rafal.romanowski@intel.com
Subject: [PATCH 8/8] ice: init flow director before RDMA
Date: Thu, 14 Nov 2024 13:18:40 +0100	[thread overview]
Message-ID: <20241114122009.97416-9-michal.swiatkowski@linux.intel.com> (raw)
In-Reply-To: <20241114122009.97416-1-michal.swiatkowski@linux.intel.com>

Flow director needs only one MSI-X. Load it before RDMA to save MSI-X
for it.

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
---
 drivers/net/ethernet/intel/ice/ice_main.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
index a6f586f9bfd1..b6997481fd42 100644
--- a/drivers/net/ethernet/intel/ice/ice_main.c
+++ b/drivers/net/ethernet/intel/ice/ice_main.c
@@ -5175,11 +5175,12 @@ int ice_load(struct ice_pf *pf)
 
 	ice_napi_add(vsi);
 
+	ice_init_features(pf);
+
 	err = ice_init_rdma(pf);
 	if (err)
 		goto err_init_rdma;
 
-	ice_init_features(pf);
 	ice_service_task_restart(pf);
 
 	clear_bit(ICE_DOWN, pf->state);
@@ -5187,6 +5188,7 @@ int ice_load(struct ice_pf *pf)
 	return 0;
 
 err_init_rdma:
+	ice_deinit_features(pf);
 	ice_tc_indir_block_unregister(vsi);
 err_tc_indir_block_register:
 	ice_unregister_netdev(vsi);
@@ -5210,8 +5212,8 @@ void ice_unload(struct ice_pf *pf)
 
 	devl_assert_locked(priv_to_devlink(pf));
 
-	ice_deinit_features(pf);
 	ice_deinit_rdma(pf);
+	ice_deinit_features(pf);
 	ice_tc_indir_block_unregister(vsi);
 	ice_unregister_netdev(vsi);
 	ice_devlink_destroy_pf_port(pf);
-- 
2.42.0


  parent reply	other threads:[~2024-11-14 12:20 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-14 12:18 [Intel-wired-lan] [iwl-next v8 0/9] ice: managing MSI-X in driver Michal Swiatkowski
2024-11-14 12:18 ` Michal Swiatkowski
2024-11-14 12:18 ` [Intel-wired-lan] [PATCH 1/8] ice: devlink PF MSI-X max and min parameter Michal Swiatkowski
2024-11-14 12:18   ` Michal Swiatkowski
2024-11-14 12:18 ` [Intel-wired-lan] [PATCH 2/8] ice: remove splitting MSI-X between features Michal Swiatkowski
2024-11-14 12:18   ` Michal Swiatkowski
2024-11-14 12:18 ` [Intel-wired-lan] [PATCH 3/8] ice: get rid of num_lan_msix field Michal Swiatkowski
2024-11-14 12:18   ` Michal Swiatkowski
2024-11-14 12:18 ` [Intel-wired-lan] [PATCH 4/8] ice, irdma: move interrupts code to irdma Michal Swiatkowski
2024-11-14 12:18   ` Michal Swiatkowski
2024-11-18 10:16   ` [Intel-wired-lan] " Pawel Chmielewski
2024-11-18 10:16     ` Pawel Chmielewski
2024-12-02  9:17     ` [Intel-wired-lan] " Michal Swiatkowski
2024-12-02  9:17       ` Michal Swiatkowski
2024-11-14 12:18 ` [Intel-wired-lan] [PATCH 5/8] ice: treat dyn_allowed only as suggestion Michal Swiatkowski
2024-11-14 12:18   ` Michal Swiatkowski
2024-11-14 12:18 ` [Intel-wired-lan] [PATCH 6/8] ice: enable_rdma devlink param Michal Swiatkowski
2024-11-14 12:18   ` Michal Swiatkowski
2024-11-14 12:18 ` [Intel-wired-lan] [PATCH 7/8] ice: simplify VF MSI-X managing Michal Swiatkowski
2024-11-14 12:18   ` Michal Swiatkowski
2024-11-14 12:18 ` Michal Swiatkowski [this message]
2024-11-14 12:18   ` [PATCH 8/8] ice: init flow director before RDMA Michal Swiatkowski
2024-11-14 12:22 ` [Intel-wired-lan] [iwl-next v8 9/9] " Michal Swiatkowski
2024-11-14 12:22   ` Michal Swiatkowski
2024-11-14 12:23 ` [Intel-wired-lan] [iwl-next v8 0/9] ice: managing MSI-X in driver Michal Swiatkowski
2024-11-14 12:23   ` Michal Swiatkowski
2024-11-18 23:13 ` [Intel-wired-lan] " Tony Nguyen
2024-11-18 23:13   ` Tony Nguyen
2024-12-02  9:20   ` [Intel-wired-lan] " Michal Swiatkowski
2024-12-02  9:20     ` Michal Swiatkowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241114122009.97416-9-michal.swiatkowski@linux.intel.com \
    --to=michal.swiatkowski@linux.intel.com \
    --cc=David.Laight@ACULAB.COM \
    --cc=horms@kernel.org \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jacob.e.keller@intel.com \
    --cc=jiri@resnulli.us \
    --cc=konrad.knitter@intel.com \
    --cc=marcin.szycik@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=nex.sw.ncis.nat.hpm.dev@intel.com \
    --cc=pawel.chmielewski@intel.com \
    --cc=pio.raczynski@gmail.com \
    --cc=pmenzel@molgen.mpg.de \
    --cc=przemyslaw.kitszel@intel.com \
    --cc=rafal.romanowski@intel.com \
    --cc=sridhar.samudrala@intel.com \
    --cc=wojciech.drewek@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.