All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Milena Olech <milena.olech@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
	anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com,
	Alexander Lobakin <aleksander.lobakin@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-net 01/10] idpf: initial PTP support
Date: Fri, 15 Nov 2024 12:38:18 +0000	[thread overview]
Message-ID: <20241115123818.GM1062410@kernel.org> (raw)
In-Reply-To: <20241113154616.2493297-2-milena.olech@intel.com>

On Wed, Nov 13, 2024 at 04:46:09PM +0100, Milena Olech wrote:
> PTP feature is supported if the VIRTCHNL2_CAP_PTP is negotiated during the
> capabilities recognition. Initial PTP support includes PTP initialization
> and registration of the clock.
> 
> Reviewed-by: Alexander Lobakin <aleksander.lobakin@intel.com>
> Signed-off-by: Milena Olech <milena.olech@intel.com>

...

> diff --git a/drivers/net/ethernet/intel/idpf/idpf_ptp.h b/drivers/net/ethernet/intel/idpf/idpf_ptp.h
> new file mode 100644
> index 000000000000..cb19988ca60f
> --- /dev/null
> +++ b/drivers/net/ethernet/intel/idpf/idpf_ptp.h
> @@ -0,0 +1,32 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +/* Copyright (C) 2024 Intel Corporation */
> +
> +#ifndef _IDPF_PTP_H
> +#define _IDPF_PTP_H
> +
> +#include <linux/ptp_clock_kernel.h>
> +
> +/**
> + * struct idpf_ptp - PTP parameters
> + * @info: structure defining PTP hardware capabilities
> + * @clock: pointer to registered PTP clock device
> + * @adapter: back pointer to the adapter
> + */
> +struct idpf_ptp {
> +	struct ptp_clock_info info;
> +	struct ptp_clock *clock;
> +	struct idpf_adapter *adapter;
> +};
> +
> +#if IS_ENABLED(CONFIG_PTP_1588_CLOCK)
> +int idpf_ptp_init(struct idpf_adapter *adapter);
> +void idpf_ptp_release(struct idpf_adapter *adapter);
> +#else /* CONFIG_PTP_1588_CLOCK */
> +static inline int idpf_ptp_init(struct idpf_adapter *adpater)

nit: adapter

> +{
> +	return 0;
> +}
> +
> +static inline void idpf_ptp_release(struct idpf_adapter *adpater) { }

Ditto

> +#endif /* CONFIG_PTP_1588_CLOCK */
> +#endif /* _IDPF_PTP_H */

...

WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Milena Olech <milena.olech@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
	anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com,
	Alexander Lobakin <aleksander.lobakin@intel.com>
Subject: Re: [PATCH iwl-net 01/10] idpf: initial PTP support
Date: Fri, 15 Nov 2024 12:38:18 +0000	[thread overview]
Message-ID: <20241115123818.GM1062410@kernel.org> (raw)
In-Reply-To: <20241113154616.2493297-2-milena.olech@intel.com>

On Wed, Nov 13, 2024 at 04:46:09PM +0100, Milena Olech wrote:
> PTP feature is supported if the VIRTCHNL2_CAP_PTP is negotiated during the
> capabilities recognition. Initial PTP support includes PTP initialization
> and registration of the clock.
> 
> Reviewed-by: Alexander Lobakin <aleksander.lobakin@intel.com>
> Signed-off-by: Milena Olech <milena.olech@intel.com>

...

> diff --git a/drivers/net/ethernet/intel/idpf/idpf_ptp.h b/drivers/net/ethernet/intel/idpf/idpf_ptp.h
> new file mode 100644
> index 000000000000..cb19988ca60f
> --- /dev/null
> +++ b/drivers/net/ethernet/intel/idpf/idpf_ptp.h
> @@ -0,0 +1,32 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +/* Copyright (C) 2024 Intel Corporation */
> +
> +#ifndef _IDPF_PTP_H
> +#define _IDPF_PTP_H
> +
> +#include <linux/ptp_clock_kernel.h>
> +
> +/**
> + * struct idpf_ptp - PTP parameters
> + * @info: structure defining PTP hardware capabilities
> + * @clock: pointer to registered PTP clock device
> + * @adapter: back pointer to the adapter
> + */
> +struct idpf_ptp {
> +	struct ptp_clock_info info;
> +	struct ptp_clock *clock;
> +	struct idpf_adapter *adapter;
> +};
> +
> +#if IS_ENABLED(CONFIG_PTP_1588_CLOCK)
> +int idpf_ptp_init(struct idpf_adapter *adapter);
> +void idpf_ptp_release(struct idpf_adapter *adapter);
> +#else /* CONFIG_PTP_1588_CLOCK */
> +static inline int idpf_ptp_init(struct idpf_adapter *adpater)

nit: adapter

> +{
> +	return 0;
> +}
> +
> +static inline void idpf_ptp_release(struct idpf_adapter *adpater) { }

Ditto

> +#endif /* CONFIG_PTP_1588_CLOCK */
> +#endif /* _IDPF_PTP_H */

...

  parent reply	other threads:[~2024-11-15 12:38 UTC|newest]

Thread overview: 83+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-13 15:46 [Intel-wired-lan] [PATCH iwl-net 00/10] initial PTP support Milena Olech
2024-11-13 15:46 ` Milena Olech
2024-11-13 15:46 ` [Intel-wired-lan] [PATCH iwl-net 01/10] idpf: " Milena Olech
2024-11-13 15:46   ` Milena Olech
2024-11-14 11:01   ` [Intel-wired-lan] " Vadim Fedorenko
2024-11-14 11:01     ` Vadim Fedorenko
2024-11-14 17:27   ` [Intel-wired-lan] " Willem de Bruijn
2024-11-14 17:27     ` Willem de Bruijn
2024-11-15 12:38   ` Simon Horman [this message]
2024-11-15 12:38     ` Simon Horman
2024-11-15 13:43   ` [Intel-wired-lan] " Paul Menzel
2024-11-15 16:07     ` Olech, Milena
2024-11-15 16:07       ` Olech, Milena
2024-11-13 15:46 ` [Intel-wired-lan] [PATCH iwl-net 02/10] virtchnl: add PTP virtchnl definitions Milena Olech
2024-11-13 15:46   ` Milena Olech
2024-11-14 17:28   ` [Intel-wired-lan] " Willem de Bruijn
2024-11-14 17:28     ` Willem de Bruijn
2024-11-18 12:57     ` [Intel-wired-lan] " Olech, Milena
2024-11-18 12:57       ` Olech, Milena
2024-11-15 12:42   ` Simon Horman
2024-11-15 12:42     ` Simon Horman
2024-11-13 15:46 ` [Intel-wired-lan] [PATCH iwl-net 03/10] idpf: move virtchnl structures to the header file Milena Olech
2024-11-13 15:46   ` Milena Olech
2024-11-14 20:02   ` [Intel-wired-lan] " Willem de Bruijn
2024-11-14 20:02     ` Willem de Bruijn
2024-11-13 15:46 ` [Intel-wired-lan] [PATCH iwl-net 04/10] idpf: negotiate PTP capabilies and get PTP clock Milena Olech
2024-11-13 15:46   ` Milena Olech
2024-11-14 12:17   ` [Intel-wired-lan] " Vadim Fedorenko
2024-11-14 12:17     ` Vadim Fedorenko
2024-11-14 20:57     ` [Intel-wired-lan] " Willem de Bruijn
2024-11-14 20:57       ` Willem de Bruijn
2024-11-15 16:34       ` [Intel-wired-lan] " Olech, Milena
2024-11-15 16:34         ` Olech, Milena
2024-11-14 20:20   ` Willem de Bruijn
2024-11-14 20:20     ` Willem de Bruijn
2024-11-18 14:36     ` [Intel-wired-lan] " Olech, Milena
2024-11-18 14:36       ` Olech, Milena
2024-11-18 15:21       ` Willem de Bruijn
2024-11-18 15:21         ` Willem de Bruijn
2024-11-14 23:26   ` Willem de Bruijn
2024-11-14 23:26     ` Willem de Bruijn
2024-11-15 12:51   ` [Intel-wired-lan] " Simon Horman
2024-11-15 12:51     ` Simon Horman
2024-11-13 15:46 ` [Intel-wired-lan] [PATCH iwl-net 05/10] idpf: add mailbox access to read PTP clock time Milena Olech
2024-11-13 15:46   ` Milena Olech
2024-11-14 20:22   ` [Intel-wired-lan] " Willem de Bruijn
2024-11-14 20:22     ` Willem de Bruijn
2024-11-13 15:46 ` [Intel-wired-lan] [PATCH iwl-net 06/10] idpf: add PTP clock configuration Milena Olech
2024-11-13 15:46   ` Milena Olech
2024-11-14 20:27   ` [Intel-wired-lan] " Willem de Bruijn
2024-11-14 20:27     ` Willem de Bruijn
2024-11-13 15:46 ` [Intel-wired-lan] [PATCH iwl-net 07/10] idpf: add Tx timestamp capabilities negotiation Milena Olech
2024-11-13 15:46   ` Milena Olech
2024-11-14 20:49   ` [Intel-wired-lan] " Willem de Bruijn
2024-11-14 20:49     ` Willem de Bruijn
2024-11-15 12:45     ` [Intel-wired-lan] " Simon Horman
2024-11-15 12:45       ` Simon Horman
2024-11-15 13:45   ` [Intel-wired-lan] " Simon Horman
2024-11-15 13:45     ` Simon Horman
2024-11-13 15:46 ` [Intel-wired-lan] [PATCH iwl-net 08/10] idpf: add Tx timestamp flows Milena Olech
2024-11-13 15:46   ` Milena Olech
2024-11-14 12:52   ` [Intel-wired-lan] " Vadim Fedorenko
2024-11-14 12:52     ` Vadim Fedorenko
2024-11-18 15:07     ` [Intel-wired-lan] " Olech, Milena
2024-11-18 15:07       ` Olech, Milena
2024-11-18 17:24       ` [Intel-wired-lan] " Vadim Fedorenko
2024-11-18 17:24         ` Vadim Fedorenko
2024-11-14 23:20   ` [Intel-wired-lan] " Willem de Bruijn
2024-11-14 23:20     ` Willem de Bruijn
2024-11-18 15:18     ` [Intel-wired-lan] " Olech, Milena
2024-11-18 15:18       ` Olech, Milena
2024-11-18 15:52       ` Willem de Bruijn
2024-11-18 15:52         ` Willem de Bruijn
2024-11-13 15:46 ` [Intel-wired-lan] [PATCH iwl-net 09/10] idpf: add support for Rx timestamping Milena Olech
2024-11-13 15:46   ` Milena Olech
2024-11-14 20:53   ` [Intel-wired-lan] " Willem de Bruijn
2024-11-14 20:53     ` Willem de Bruijn
2024-11-18 15:31     ` [Intel-wired-lan] " Olech, Milena
2024-11-18 15:31       ` Olech, Milena
2024-11-18 15:53       ` [Intel-wired-lan] " Willem de Bruijn
2024-11-18 15:53         ` Willem de Bruijn
2024-11-13 15:46 ` [Intel-wired-lan] [PATCH iwl-net 10/10] idpf: change the method for mailbox workqueue allocation Milena Olech
2024-11-13 15:46   ` Milena Olech

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241115123818.GM1062410@kernel.org \
    --to=horms@kernel.org \
    --cc=aleksander.lobakin@intel.com \
    --cc=anthony.l.nguyen@intel.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=milena.olech@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=przemyslaw.kitszel@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.