* [PATCH media-next] media: rkisp1: Fix unused value issue
@ 2024-11-18 8:27 ` Dheeraj Reddy Jonnalagadda
0 siblings, 0 replies; 2+ messages in thread
From: Dheeraj Reddy Jonnalagadda @ 2024-11-18 8:27 UTC (permalink / raw)
To: dafna, laurent.pinchart, linux-media
Cc: mchehab, heiko, linux-rockchip, linux-arm-kernel, linux-kernel,
Dheeraj Reddy Jonnalagadda
This commit fixes an unused value issue detected by Coverity (CID
1519008). If ret is set to an error value in the switch statement, it is not
handled before being overwritten later.
Signed-off-by: Dheeraj Reddy Jonnalagadda <dheeraj.linuxdev@gmail.com>
---
drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c
index dd114ab77800..9ad5026ab10a 100644
--- a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c
+++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c
@@ -228,6 +228,9 @@ static int rkisp1_subdev_notifier_register(struct rkisp1_device *rkisp1)
break;
}
+ if (ret)
+ break;
+
/* Parse the endpoint and validate the bus type. */
ret = v4l2_fwnode_endpoint_parse(ep, &vep);
if (ret) {
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH media-next] media: rkisp1: Fix unused value issue
@ 2024-11-18 8:27 ` Dheeraj Reddy Jonnalagadda
0 siblings, 0 replies; 2+ messages in thread
From: Dheeraj Reddy Jonnalagadda @ 2024-11-18 8:27 UTC (permalink / raw)
To: dafna, laurent.pinchart, linux-media
Cc: mchehab, heiko, linux-rockchip, linux-arm-kernel, linux-kernel,
Dheeraj Reddy Jonnalagadda
This commit fixes an unused value issue detected by Coverity (CID
1519008). If ret is set to an error value in the switch statement, it is not
handled before being overwritten later.
Signed-off-by: Dheeraj Reddy Jonnalagadda <dheeraj.linuxdev@gmail.com>
---
drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c
index dd114ab77800..9ad5026ab10a 100644
--- a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c
+++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c
@@ -228,6 +228,9 @@ static int rkisp1_subdev_notifier_register(struct rkisp1_device *rkisp1)
break;
}
+ if (ret)
+ break;
+
/* Parse the endpoint and validate the bus type. */
ret = v4l2_fwnode_endpoint_parse(ep, &vep);
if (ret) {
--
2.34.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-11-18 8:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-18 8:27 [PATCH media-next] media: rkisp1: Fix unused value issue Dheeraj Reddy Jonnalagadda
2024-11-18 8:27 ` Dheeraj Reddy Jonnalagadda
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.