From: Christoph Hellwig <hch@lst.de>
To: John Garry <john.g.garry@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>,
axboe@kernel.dk, linux-block@vger.kernel.org
Subject: Re: [PATCH] block: return unsigned int from bdev_io_min
Date: Tue, 19 Nov 2024 13:54:40 +0100 [thread overview]
Message-ID: <20241119125440.GA31381@lst.de> (raw)
In-Reply-To: <5108f61a-c471-457c-ba32-3003925a4de1@oracle.com>
On Tue, Nov 19, 2024 at 12:52:40PM +0000, John Garry wrote:
> On 19/11/2024 07:26, Christoph Hellwig wrote:
>> The underlying limit is defined as an unsigned int, so return that from
>> bdev_io_min as well.
>>
>
> There seem to be other helpers with the same condition.
>
> Even bdev_io_opt() is defined as returning an int, but actually returns an
> unsigned int. And even though not a bdev helper, queue_dma_alignment() is
> similar.
True. I'll cook up patches - I just noticed this one because of a
series that added casts to the return value which made me look there.
next prev parent reply other threads:[~2024-11-19 12:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-19 7:26 [PATCH] block: return unsigned int from bdev_io_min Christoph Hellwig
2024-11-19 11:23 ` Martin K. Petersen
2024-11-19 12:52 ` John Garry
2024-11-19 12:54 ` Christoph Hellwig [this message]
2024-11-19 14:20 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241119125440.GA31381@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=john.g.garry@oracle.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.