[PATCH] block: return unsigned int from bdev_io_min

[PATCH] block: return unsigned int from bdev_io_min

[Christoph Hellwig]

The underlying limit is defined as an unsigned int, so return that from
bdev_io_min as well.

Fixes: ac481c20ef8f ("block: Topology ioctls")
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 include/linux/blkdev.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 00212e96261a..4825469c2fa1 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -1261,7 +1261,7 @@ static inline unsigned int queue_io_min(const struct request_queue *q)
 	return q->limits.io_min;
 }
 
-static inline int bdev_io_min(struct block_device *bdev)
+static inline unsigned int bdev_io_min(struct block_device *bdev)
 {
 	return queue_io_min(bdev_get_queue(bdev));
 }
-- 
2.45.2

Re: [PATCH] block: return unsigned int from bdev_io_min

[Martin K. Petersen]

Christoph,

> The underlying limit is defined as an unsigned int, so return that
> from bdev_io_min as well.

Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>

-- 
Martin K. Petersen	Oracle Linux Engineering

Re: [PATCH] block: return unsigned int from bdev_io_min

[John Garry]

On 19/11/2024 07:26, Christoph Hellwig wrote:
> The underlying limit is defined as an unsigned int, so return that from
> bdev_io_min as well.
> 

There seem to be other helpers with the same condition.

Even bdev_io_opt() is defined as returning an int, but actually returns 
an unsigned int. And even though not a bdev helper, 
queue_dma_alignment() is similar.

> Fixes: ac481c20ef8f ("block: Topology ioctls")
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Reviewed-by: John Garry <john.g.garry@oracle.com>

> ---
>   include/linux/blkdev.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
> index 00212e96261a..4825469c2fa1 100644
> --- a/include/linux/blkdev.h
> +++ b/include/linux/blkdev.h
> @@ -1261,7 +1261,7 @@ static inline unsigned int queue_io_min(const struct request_queue *q)
>   	return q->limits.io_min;
>   }
>   
> -static inline int bdev_io_min(struct block_device *bdev)
> +static inline unsigned int bdev_io_min(struct block_device *bdev)
>   {
>   	return queue_io_min(bdev_get_queue(bdev));
>   }

Re: [PATCH] block: return unsigned int from bdev_io_min

[Christoph Hellwig]

On Tue, Nov 19, 2024 at 12:52:40PM +0000, John Garry wrote:
> On 19/11/2024 07:26, Christoph Hellwig wrote:
>> The underlying limit is defined as an unsigned int, so return that from
>> bdev_io_min as well.
>>
>
> There seem to be other helpers with the same condition.
>
> Even bdev_io_opt() is defined as returning an int, but actually returns an 
> unsigned int. And even though not a bdev helper, queue_dma_alignment() is 
> similar.

True.  I'll cook up patches - I just noticed this one because of a
series that added casts to the return value which made me look there.

Re: [PATCH] block: return unsigned int from bdev_io_min

[Jens Axboe]

On Tue, 19 Nov 2024 08:26:02 +0100, Christoph Hellwig wrote:
> The underlying limit is defined as an unsigned int, so return that from
> bdev_io_min as well.
> 
> 

Applied, thanks!

[1/1] block: return unsigned int from bdev_io_min
      commit: 46fd48ab3ea3eb3bb215684bd66ea3d260b091a9

Best regards,
-- 
Jens Axboe