From: Christoph Hellwig <hch@lst.de>
To: John Garry <john.g.garry@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org
Subject: Re: [PATCH 1/2] block: don't bother checking the data direction for merges
Date: Tue, 19 Nov 2024 17:49:57 +0100 [thread overview]
Message-ID: <20241119164957.GA17438@lst.de> (raw)
In-Reply-To: <427189c2-dff8-4af8-a805-31d78019cc7b@oracle.com>
On Tue, Nov 19, 2024 at 04:48:15PM +0000, John Garry wrote:
> I tried to check what is meant by "already started", but that comment
> pre-dates git. And even the code from then does not make it obvious, but I
> don't want to check further, so:
Back in the bad old days there was a separare prep_fn callback into
the driver to prepare a request while it was still on the scheduler
lists, and that then set a started flag. In other words the comment
is long obsolete.
next prev parent reply other threads:[~2024-11-19 16:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-19 16:11 clean up bio merge conditions Christoph Hellwig
2024-11-19 16:11 ` [PATCH 1/2] block: don't bother checking the data direction for merges Christoph Hellwig
2024-11-19 16:48 ` John Garry
2024-11-19 16:49 ` Christoph Hellwig [this message]
2024-11-19 16:11 ` [PATCH 2/2] block: req->bio is always set in the merge code Christoph Hellwig
2024-11-19 16:59 ` John Garry
2024-11-19 16:36 ` clean up bio merge conditions Martin K. Petersen
2024-11-19 16:56 ` Johannes Thumshirn
2024-11-20 2:07 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241119164957.GA17438@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=john.g.garry@oracle.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.