From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>, linux-block@vger.kernel.org
Subject: Re: clean up bio merge conditions
Date: Tue, 19 Nov 2024 11:36:29 -0500 [thread overview]
Message-ID: <yq134jnrxj1.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20241119161157.1328171-1-hch@lst.de> (Christoph Hellwig's message of "Tue, 19 Nov 2024 17:11:49 +0100")
Christoph,
> Dan's smatch run pointed out that there is no need to check for a NULL
> req->bio in the merge bio into request and request merge helpers
> because they can't ever be reached by flush or passthrough requests.
>
> While validing that I also found a few other odd bits directly next
> to it, so this two-patch series fixes all of that.
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2024-11-19 16:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-19 16:11 clean up bio merge conditions Christoph Hellwig
2024-11-19 16:11 ` [PATCH 1/2] block: don't bother checking the data direction for merges Christoph Hellwig
2024-11-19 16:48 ` John Garry
2024-11-19 16:49 ` Christoph Hellwig
2024-11-19 16:11 ` [PATCH 2/2] block: req->bio is always set in the merge code Christoph Hellwig
2024-11-19 16:59 ` John Garry
2024-11-19 16:36 ` Martin K. Petersen [this message]
2024-11-19 16:56 ` clean up bio merge conditions Johannes Thumshirn
2024-11-20 2:07 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq134jnrxj1.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.