Re: [RFC PATCH v2 10/20] fwctl/cxl: Add support for get driver information

[Jason Gunthorpe <jgg@nvidia.com>]

On Fri, Nov 15, 2024 at 02:25:43PM -0700, Dave Jiang wrote:

> +/**
> + * cxl_mailbox_user_commands_supported() - Return number of user mailbox
> + *                                         commands supported.
> + * @cxl_mbox: cxl mailbox context
> + *
> + * Return: number of commands supported
> + */
> +int cxl_mailbox_user_commands_supported(struct cxl_mailbox *cxl_mbox)
> +{
> +	int nr_cmds = 0;
> +
> +	for (int i = 0; i < FWCTL_CXL_MAX_COMMANDS; i++) {
> +		nr_cmds += !!fwctl_cxl_find_command(cxl_mbox,
> +						    fwctl_command_sets[i]);

I'd just use an if here, adding a boolean is weird

> +/**
> + * struct fwctl_info_cxl - ioctl(FWCTL_INFO) out_device_data
> + * @uctx_caps: The number of commands the driver and device supports

Comment needs an update to nr_commands

Maybe write a few words about what userspace is supposed to do with
nr_commands?

Jason