Re: [RFC PATCH v2 14/20] cxl: Move defines and error codes from cxlmem.h to cxl/mailbox.h

[Jonathan Cameron <Jonathan.Cameron@huawei.com>]

On Fri, 15 Nov 2024 14:25:47 -0700
Dave Jiang <dave.jiang@intel.com> wrote:

> Moving some internal definitions to cxl/mailbox.h in order to be accessed
> by FWCTL CXL driver.
> 
> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
I'm not keen on the rename being in this patch which is otherwise
just a move.  If that can't get pushed back to earlier patch
then do it as a precursor.

Jonathan

> diff --git a/include/cxl/mailbox.h b/include/cxl/mailbox.h
> index f48eebb855f7..e753d5d1d708 100644
> --- a/include/cxl/mailbox.h
> +++ b/include/cxl/mailbox.h

> +/**
> + * struct cxl_feat_entry - CXL Spec r3.1 Table 8-97
> + * @uuid: Feature identifier
> + * @id: Feature Index
> + * @get_feat_size: Get Feature Size
> + * @set_feat_size: Set Feature Size
> + * @flags: Attribute Flags
> + * @get_feat_ver: Get Feature Version
> + * @set_feat_ver: Set Feature Version
> + * @reserved: reserved, must be 0
> + */
> +struct cxl_feat_entry {
> +	uuid_t uuid;
> +	__le16 id;
> +	__le16 get_feat_size;
> +	__le16 set_feat_size;
> +	__le32 flags;
> +	u8 get_feat_ver;
> +	u8 set_feat_ver;
> +	__le16 effects;
Not documented.

> +	u8 reserved[18];
> +} __packed;

> diff --git a/tools/testing/cxl/test/mem.c b/tools/testing/cxl/test/mem.c
> index e0c7e49795ed..9103bac054b9 100644
> --- a/tools/testing/cxl/test/mem.c
> +++ b/tools/testing/cxl/test/mem.c
> @@ -1354,7 +1354,7 @@ static void fill_feature_vendor_test(struct cxl_feat_entry *feat)
>  	feat->flags = cpu_to_le32(BIT(5));
>  	feat->get_feat_ver = 1;
>  	feat->set_feat_ver = 1;
> -	feat->set_effects = cpu_to_le16(BIT(0) | BIT(9));
> +	feat->effects = cpu_to_le16(BIT(0) | BIT(9));

Feels like the rename should be in the earlier patch.

>  }
>  
>  static int mock_get_supported_features(struct cxl_mockmem_data *mdata,